Skip to content

fix(release): pin manifest writes to directory descriptors - #56

Closed
seonghobae wants to merge 8 commits into
agent/reproducible-release-acceptancefrom
agent/release-evidence-dirfd-hardening
Closed

fix(release): pin manifest writes to directory descriptors#56
seonghobae wants to merge 8 commits into
agent/reproducible-release-acceptancefrom
agent/release-evidence-dirfd-hardening

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Superseded by #57

Closed unmerged after live ancestry and security-boundary review proved that #57's unchanged final release-evidence head contains this PR in full and should be the only protected-main release-evidence slice.

Exact consolidation evidence:

All source history, fail-first evidence, and prior CI/Release Acceptance runs remain available on this branch as development provenance. No old-base evidence transfers to the retargeted #57. #57 must reacquire every required exact-head/exact-base gate and independent approval before merge.

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 508276e2-24fd-4293-8630-82228aaf2d6c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

Please review exact current draft head 5dff29b234977048171dbdd9d50c394301337a90 against exact stacked base 3660bb9edd6351a9c02d9507f08ed647ddbf0d3a. The automatic draft review was skipped and all predecessor-head results are stale. Exact-head CI run 31069097321 and Release Acceptance run 31069097349 are complete and successful.

Review the descriptor-relative capability gate; absolute and relative parent traversal with O_DIRECTORY/O_NOFOLLOW; destination no-follow validation; exclusive mode-0600 temporary creation; file and final-parent fsync() boundaries; descriptor-relative atomic os.rename(); owned-temporary cleanup; bounded exception diagnostics; parent-swap concurrency regression; unsupported-platform fail-closed behavior; canonical bounded manifest semantics; immutable/read-only workflow context inherited from the stacked base; and the CWE-367/Python 3.14/POSIX.1-2024 operator contract. Report only exact-head actionable findings. Do not treat draft-stage absence of default-branch required workflows, a comment, or predecessor evidence as approval or success.

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

@seonghobae I will review pull request #56 at the specified head and stacked base. I will report only actionable findings from that comparison.

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

The prior exact-head request 5200129959 was rate-limited and is superseded by this single retry after the advertised availability interval. Review exact unchanged head 5dff29b234977048171dbdd9d50c394301337a90 against exact unchanged stacked base 3660bb9edd6351a9c02d9507f08ed647ddbf0d3a; do not reuse predecessor evidence. CI run 31069097321 and Release Acceptance run 31069097349 are complete and successful. Report only exact-head actionable findings covering descriptor-relative no-follow traversal, destination and temporary-entry safety, file and parent-directory durability, owned-temporary cleanup, bounded diagnostics, capability fail-closed behavior, the parent-swap regression, and the authoritative CWE-367/Python/POSIX contract. This draft-stage review is not independent merge approval and default-branch required gates remain absent by design.

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

@seonghobae I will review pull request #56 at head 5dff29b234977048171dbdd9d50c394301337a90 against base 3660bb9edd6351a9c02d9507f08ed647ddbf0d3a. I will report only actionable findings from this exact comparison.

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link
Copy Markdown
Contributor Author

@opencode-agent @cwl-noema-review

Perform a fresh independent review of exact draft head 5dff29b234977048171dbdd9d50c394301337a90 against exact stacked base 3660bb9edd6351a9c02d9507f08ed647ddbf0d3a. Exact-head CI 31069097321 and Release Acceptance 31069097349 are complete and successful; unresolved review threads are zero. Review descriptor-relative no-follow traversal, capability fail-closed behavior, destination and temporary-entry safety, two durability boundaries, owned-temporary cleanup, bounded diagnostics, parent-swap concurrency evidence, and the authoritative CWE-367/Python 3.14/POSIX.1-2024 contract. Report only exact-head actionable findings. This is a stacked draft: do not count absent default-branch required workflows as success and do not issue merge approval until prerequisites are integrated and all current default-branch gates rerun.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant