feat(reconcile): add bounded content-free sweep evidence - #253
Draft
seonghobae wants to merge 5 commits into
Draft
feat(reconcile): add bounded content-free sweep evidence#253seonghobae wants to merge 5 commits into
seonghobae wants to merge 5 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
changed the base branch from
main
to
fix/recovery-evidence-weakref-coverage-b84f0c9
August 19, 2026 01:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buyer-visible operability slice
This Draft adds a bounded, content-free reconciliation sweep evidence primitive for the operator-evidence part of #102. It intentionally does not claim scheduling, crash recovery, durable leasing, terminal retirement, or distributed exactly-once semantics.
RED -> GREEN contract
Test-only commit
0216d1d6cc2ea885bbbb98b40bf989014e6673bcdefined immutable fixed-category counts; exact non-negative integer types; the protected reconciliation candidate ceiling; attempted work bounded by the candidate page; and applied/deferred/failed outcomes partitioning attempted work. The required module is absent from that RED tree while the test imports it. Those transient test-only workflows were cancelled by normal PR concurrency after GREEN and are not counted as passing RED evidence.The product implementation adds
pg_llm_batch/reconciliation_sweep_evidence.pyandtests/test_reconciliation_sweep_evidence.py.ReconciliationSweepEvidenceis frozen/slotted, accepts exact built-in integers only, bounds every count toMAX_RECONCILIATION_CANDIDATES, rejects attempted work above the candidate page, requires applied + deferred + failed to partition attempted work, and serializes only five fixed count categories with rejected values redacted. Focused isolated validation produced10 passedand 100% statement/branch coverage for the touched production module.Exact coverage RCA and stack boundary
The original direct-main GREEN head
f0cdbd2e169618c6eba104e9b9f6fe9715c9af6dcompleted Security Scan32201655359, SAST Semgrep32201655177, and Release Acceptance32201655324successfully. CI32201655351failed only at repository-wide coverage after checking out that exact head: all 1,342 non-integration tests passed, but protected main still lacked exactly two weakref guard arcs (postgres_backup_evidence.py:65->exitandpostgres_schema_evidence.py:49->exit), producing 99.96% aggregate coverage. Those arcs are already owned by root PR #233; duplicating that regression here would create competing ownership.This lane is therefore non-destructively stacked on exact #233 head
5951b7a4d779903b8924abaef2a387cae50b7f54. Current exact head13fc0156c6c044b5932a60660b2aad7aafd10150has #233 as a merge parent and is three commits ahead / zero behind it. Relative to #233, this PR changes only:pg_llm_batch/reconciliation_sweep_evidence.py; andtests/test_reconciliation_sweep_evidence.py.Current exact-head validation
Fresh repository-local workflows on unchanged exact
13fc0156c6c044b5932a60660b2aad7aafd10150are now terminal-success:32203505994: success;32203506018: success;32203506094: success; and32203506064: success.CI independently checked out and verified exact
13fc0156c6c044b5932a60660b2aad7aafd10150with persisted checkout credentials disabled. Python 3.10/3.12/3.14 unit jobs and PostgreSQL/container smokes succeeded; compile and Ruff succeeded; public-docstring coverage was exactly 100%; repository production statement/branch coverage was exactly 100.00% (3660statements,1014branches, zero misses/partials); lock freshness succeeded; anduv build --no-sourcesproduced both sdist and wheel. The Python 3.14.7 coverage run completed1344 passed, 5 deselected, 5 warnings.Those five warnings are inherited test-harness hygiene defects outside this reconciliation-sweep diff: four schema-evidence finalizer warnings owned by Draft #251 and one compose/runpy warning owned by Draft #252. They are not suppressed here. #251 and #252 separately prove their bounded fixes on exact stacked heads, but their evidence does not transfer to this PR.
Fresh formal-review and inline-thread inventories remain empty; absence of review is not approval. Keep this PR Draft because predecessor #233 must integrate first and then this child must be reconciled/revalidated against then-current protected main with qualifying final review.
Writer and governance boundary
The source branch remains the only
reconciliation-sweep-evidencelane in the fresh branch inventory. It does not change existing reconciliation worker source, schema, workflows, canonical docs, or the #233-owned weakref regression itself. No source/documentation mutation was made directly to protected main.#233 remains the exact predecessor. Its pg-local quality/security/release evidence is terminal-success, but its current-head independent-review state remains non-passing because the required review-evidence path is owned by read-only central
.github. This child neither duplicates nor bypasses that blocker.After #233 integrates, retarget this PR to then-current protected main, prove the reconciled descendant diff remains only this sweep-evidence slice, and reacquire every exact-final-head quality/security/coverage/package/SBOM/provenance/release/review gate. No predecessor, pre-stack, infrastructure-failed, status-only, author-only, or other-branch evidence transfers.
Refs #102, #233, #244, #250, #251, #252.