test(compose): eliminate runpy module-execution warning - #252
Draft
seonghobae wants to merge 2 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 18, 2026
seonghobae
changed the base branch from
main
to
fix/schema-evidence-close-warning-b84f0c9
August 19, 2026 00:04
This was referenced Aug 19, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
python -m pg_llm_batch.compose_bootstrapregression from the already-imported test moduleRuntimeWarningto an error around therunpyexecution so the warning cannot silently returnExact stack boundary
This branch was originally created explicitly from protected
main@b84f0c94154043a3473939c01bb6471de5a129ae. It is now an explicit Draft child of #251 so the already-isolated warning repairs can be validated together behind dependency-root #233 without duplicating either predecessor change.fix/schema-evidence-close-warning-b84f0c9a2d5fea66a580f0538d07a7c1e3cae9ff18de10299821587d289ffd0adfa010650514a95532717f5tests/test_compose_bootstrap.pyThe stack merge commit is non-destructive and retains both histories. It does not alter #251, #233, protected main, production source, or canonical docs.
RED evidence
Exact-head CI run
32176653098on the predecessor warning lane completed the non-integration suite on Python 3.14.7 but emitted one independent warning:test_module_execution_invokes_health_without_secret_in_argvtriggeredRuntimeWarning: 'pg_llm_batch.compose_bootstrap' found in sys.modules ... prior to execution. The test importscompose_bootstrapat module collection time and later callsrunpy.run_module, so it did not model a cleanpython -mlookup.Narrow GREEN candidate
Immediately before
runpy.run_module, the test uses the pytest monkeypatch fixture to temporarily remove onlypg_llm_batch.compose_bootstrapfromsys.modules; pytest restores it after the test. The runpy call is wrapped in aRuntimeWarning-as-error boundary, making recurrence a deterministic failure rather than a warning-only signal. Production module behavior, secret handling, argv boundaries, health seams, and package exports are unchanged.The pre-stack exact head
6e91e8cd50f287467307389055c977203ad22755already proved the branch-local repair: Python 3.10/3.12/3.14 unit lanes and container/PostgreSQL smokes passed, and the Python 3.14.7 unit lane completed1332 passed, 5 deselectedwith no compose/runpy RuntimeWarning. SAST Semgrep, Security Scan, and Release Acceptance were terminal-success. Its aggregate CI remained non-passing only because protected main still lacked #233 coverage and still emitted the separate schema-finalizer warnings now owned by #251.That pre-stack evidence is causal context only and is not transferred as current-head gate evidence.
Fresh writer safety
Fresh targeted branch inventory still finds
fix/compose-bootstrap-runpy-warning-b84f0c9as the only branch with this warning-repair name. Fresh formal-review and inline-thread inventories are empty. The branch head, exact stack base, and contributor ancestry were refetched immediately before this metadata repair; no competing actor moved this branch.Current exact-head validation
The genuinely new repository-local validation set for exact stacked head
99821587d289ffd0adfa010650514a95532717f5is now terminal-success:32199790867: success;32199790923: success;32199790936: success; and32199791032: success.CI independently checked out and verified exact
99821587d289ffd0adfa010650514a95532717f5. Python 3.10, 3.12, and 3.14 unit jobs all succeeded; PostgreSQL/container smokes succeeded; compile and Ruff succeeded; public-docstring coverage was exactly 100%; repository production statement/branch coverage was exactly 100.00% (3633statements,1006branches, zero misses/partials); lock freshness succeeded; anduv build --no-sourcesproduced both wheel and sdist. The Python 3.14.7 coverage run completed1334 passed, 5 deselectedwith no warnings.This exact head therefore proves that the compose/runpy warning is eliminated while preserving the predecessor #251 schema-finalizer repair and the #233 coverage root. Fresh formal-review and inline-thread inventories remain empty; absence of review is not approval.
Integration boundary
The required stack order is #233 → #251 → #252. #233 must merge first, then #251 must be retargeted/revalidated against protected main and integrated before this child can become merge-eligible. #233 itself remains blocked by current-head independent-review evidence owned by the read-only central
.githubcontrol plane.After the predecessors integrate, retarget this PR to the then-current protected main (or exact live predecessor while the stack is still active), prove the reconciled diff remains only the compose warning repair, and reacquire every exact-final-head quality/security/package/provenance/release/review gate. No pre-stack, predecessor, queued, infrastructure-failed, status-only, or author-only evidence transfers.
Refs #233, #250, #251.