fix(cron): decommission unsafe direct SQL provider retrieval - #101
Conversation
|
Warning Review limit reached
Next review available in: 26 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (8)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
|
RCA
Protected main historically shipped an every-minute
pg_cron+pgsql-httpprovider retriever. That path bypasses the validated Python credential/destination/response boundary, can consume only the weaker database-visible secret form, and treats a local batch UUID as a remote provider identity without a reviewed binding. The bounded remedy is fail-closed retirement rather than maintaining a second provider client in PL/pgSQL.Cleanup is identity-safe: it unschedules only the exact legacy job and drops each helper only after matching the retired
pg_proc.prosrcplus reviewed language/volatility/invoker-security metadata. The cleanup transaction uses a finite lock timeout and catalog lock so same-signature operator replacements cannot race the proof/drop boundary. Historicalgateway_retrieval_logsremain intact.Test-first evidence
Earlier RED→GREEN cycles established fresh-install retirement, exact job/helper identity, substituted-helper refusal, existing-volume recovery, and the live PostgreSQL cleanup smoke. In particular, a realistic existing-volume regression caught and then corrected the historical
get_secret_value(text)source fingerprint. Pre-#88 synthetic-merge workflow results remain development provenance only.Current exact state
44f4c11cbb353eb6848cb2d7160ca9e743315923.main:06f88be7f7c3a3ce5e756bc3bf03f298031a0286.f5f9629184d881bdc16869402497a237a1a293f3.31543246176, SAST Semgrep31543246275, and Security Scan31543246303are queued. Queued evidence is not acceptance.Integration boundary
This PR owns retirement/cleanup of the legacy SQL provider path only. Issue #102 owns future automatic reconciliation; Issue #103 owns later removal of now-cleanup-only
pg_cron/httpimage compatibility. Do not fold either into this branch.Merge only if this unchanged source head receives terminal success for every then-live repository/central CI, security, package/provenance and policy gate, remains mergeable against the then-live protected base, and has zero valid unresolved findings. No predecessor, synthetic, queued, pending, cancelled, skipped, absent, status-only, author-only, infrastructure-only, rate-limited, or failed evidence transfers.