Hash lifecycle operability evidence at the descriptor-safe read boundary - #579
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthrough엄격한 JSON 증거 판독기가 검증된 원본 바이트의 SHA-256을 계산합니다. 감사 출력은 성공한 증거의 다이제스트를 포함하고 실패 시 Changes증거 다이제스트 검증
Estimated code review effort: 2 (Simple) | ~10 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 9, 2026
seonghobae
marked this pull request as ready for review
September 9, 2026 19:12
This was referenced Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buyer/runtime gap
#561 requires lifecycle operability evidence to be cryptographically bound to the exact retained bytes. Protected
main@32537d9b1f420666bf97c455c3f9a09fc17d0be1could parse descriptor-safe retained JSON and #578 could consume a caller-supplied digest, but the operability audit did not yet compute that digest from the same descriptor read.RED → causal repair
The first commit added a regression requiring a retained-evidence SHA-256 API that performs exactly one descriptor-safe read and withholds any digest for duplicate-key JSON. A second regression requires the bounded lifecycle audit output to expose only that digest, never the evidence pathname or raw latency samples.
The implementation now:
readStrictJsonEvidenceWithSha256, hashing the exact Buffer already used for fatal UTF-8 decoding, duplicate-key rejection andJSON.parse;evidence_sha256fromoperations:lifecycle-operabilityonly after strict evidence collection succeeds;Remaining acceptance
This Draft does not close #561. A trusted release/deployment workflow still must produce or collect the actual remote Durable Object evidence, attest those exact retained bytes, cryptographically verify that attestation, retain the verification receipt, and then run the deployment-authority gate. Real p95/storage/contention/recovery evidence and immutable release provenance remain required.
Summary by CodeRabbit
새 기능
문서
테스트