Bind lifecycle operability evidence to deployment authority - #578
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthrough외부 확장 수명주기 증거를 배포 권한과 검증된 영수증에 연결하는 평가 함수를 추가했습니다. 배포 커밋, digest, 릴리스 provenance, 서명 워크플로 불일치와 정상 결합을 검증하는 테스트를 추가했습니다. Changes외부 확장 증명서 기반 운영성 검증
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant Caller
participant DeploymentAuthorityEvaluator
participant LifecycleEvidenceEvaluator
participant AttestationReceipt
Caller->>DeploymentAuthorityEvaluator: 배포 권한 및 배포 증거 전달
DeploymentAuthorityEvaluator-->>Caller: 배포 권한 평가 결과
Caller->>LifecycleEvidenceEvaluator: 수명주기 증거 평가
LifecycleEvidenceEvaluator->>AttestationReceipt: 영수증 필드 일치 여부 검증
AttestationReceipt-->>LifecycleEvidenceEvaluator: 영수증 검사 결과
LifecycleEvidenceEvaluator-->>Caller: PASS 또는 FAIL와 실패 코드 반환
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
marked this pull request as ready for review
September 9, 2026 19:01
This was referenced Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#561 now has deterministic remote Durable Object operability evidence validation on protected main, but that evaluator explicitly validates evidence self-consistency only. Shape-valid lifecycle metrics can therefore be fabricated unless the retained evidence is bound to the canonical immutable deployment and to an independently verified evidence artifact.
RED → causal repair
This lane started from protected
main@86fa0b2f662adc18f75a34e0fd1ff9682decaa4bwith a regression requiring a provenance-bound evaluator; protected source had no such function.The repair now:
evaluateExternalExtensionLifecycleOperabilityEvidenceas the lifecycle content/denominator/recovery validator;evaluateAcquisitionDeploymentEvidenceas the single canonical release/deployment/governance/Sigstore authority rather than copying its truth;protected_main_shaanddeployed_worker_shato equal the exact canonical deployment commit;The first implementation revision that only matched lifecycle SHA to deployment SHA was reviewed as insufficient because an attacker could forge metrics while reusing the real deployed SHA. The current exact adds the independent lifecycle-artifact receipt boundary instead of treating a matching commit string as producer authentication.
Remaining acceptance
This Draft does not close #561 and does not claim production deployment or release readiness. A descriptor-safe CLI/producer path still must compute the lifecycle evidence SHA-256 from the exact retained bytes, obtain/retain the cryptographic verification receipt, and then feed this gate. Actual remote Durable Object p95/storage/contention/recovery evidence tied to a real immutable release remains required.
Summary by CodeRabbit
새 기능
테스트