Skip to content
Merged
Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
b44897f
test(acquisition): refresh manifest after license inventory
seonghobae Aug 30, 2026
cd90d8e
fix(acquisition): refresh manifest before integrity audit
seonghobae Aug 30, 2026
67544d8
test(acquisition): reject stale pre-audit manifest artifact
seonghobae Aug 30, 2026
8840166
fix(acquisition): eliminate stale pre-audit manifest artifact
seonghobae Aug 30, 2026
b5bdfc3
test(acquisition): bind source revalidation to canonical audit
seonghobae Aug 30, 2026
c7b4e4e
test(acquisition): prevent duplicate manifest materialization
seonghobae Aug 30, 2026
79ff003
merge main into acquisition audit repair
seonghobae Aug 30, 2026
e254098
merge main into acquisition audit manifest refresh
seonghobae Aug 30, 2026
28d45cf
merge main into acquisition audit manifest refresh
seonghobae Aug 31, 2026
cf2da98
merge(main): converge acquisition audit repair
seonghobae Aug 31, 2026
d89afcd
Merge remote-tracking branch 'origin/main' into fix/acquisition-audit…
seonghobae Aug 31, 2026
7d875a0
fix(acquisition): share audit output authority
seonghobae Aug 31, 2026
fdbe0c3
fix(acquisition): unify conflicting output overrides
seonghobae Aug 31, 2026
a7c2994
Merge remote-tracking branch 'origin/main' into fix/acquisition-audit…
seonghobae Aug 31, 2026
c078a8b
fix(acquisition): make audit orchestration portable
seonghobae Aug 31, 2026
bcce8b6
Merge remote-tracking branch 'origin/main' into fix/acquisition-audit…
seonghobae Aug 31, 2026
60d40c1
test(acquisition): require audit executable in buyer catalog
seonghobae Aug 31, 2026
67f91b3
test(acquisition): hash canonical audit executable
seonghobae Aug 31, 2026
4846e5d
test(acquisition): bind audit executable in composed catalog
seonghobae Aug 31, 2026
5a56834
fix(acquisition): hash canonical audit executable
seonghobae Aug 31, 2026
b445074
test(acquisition): require one canonical hourly audit
seonghobae Aug 31, 2026
3368c13
fix(acquisition): remove duplicate hourly manifest
seonghobae Aug 31, 2026
ae3bd1d
fix(acquisition): hash tracked blobs in process
seonghobae Aug 31, 2026
2eb5e45
fix(acquisition): support SHA-256 exact heads
seonghobae Aug 31, 2026
60e581b
fix(acquisition): carry SHA-256 commit identity
seonghobae Aug 31, 2026
03682c7
Merge remote-tracking branch 'origin/main' into fix/acquisition-audit…
seonghobae Aug 31, 2026
9ff8923
fix(release): produce SHA-256 commit evidence
seonghobae Aug 31, 2026
7858a26
fix(acquisition): pin stages to initial head
seonghobae Aug 31, 2026
06bf671
Merge remote-tracking branch 'origin/main' into fix/acquisition-audit…
seonghobae Aug 31, 2026
7df4326
fix(acquisition): canonicalize stage revision
seonghobae Aug 31, 2026
652c4ce
Merge remote-tracking branch 'origin/main' into fix/acquisition-audit…
seonghobae Aug 31, 2026
7e80488
fix: support legacy Git tree inventory
seonghobae Aug 31, 2026
f79b920
chore(acquisition): preserve protected-main changelog truth
seonghobae Aug 31, 2026
7da63c0
chore(acquisition): converge protected main
seonghobae Aug 31, 2026
609c018
test(acquisition): reject source movement between audit stages
seonghobae Aug 31, 2026
0d3bcd7
fix(acquisition): fail closed on source movement between stages
seonghobae Aug 31, 2026
caa8d88
test(acquisition): reject tracked source drift during audit
seonghobae Aug 31, 2026
8ff8a65
fix(acquisition): authenticate tracked source between audit stages
seonghobae Aug 31, 2026
cccddc3
Merge remote-tracking branch 'origin/main' into fix/acquisition-audit…
seonghobae Aug 31, 2026
de8324d
fix(acquisition): authenticate inventory input bytes
seonghobae Aug 31, 2026
ce82139
test(acquisition): bind dependency inventory to claimed commit
seonghobae Aug 31, 2026
431c734
Merge remote-tracking branch 'origin/fix/acquisition-audit-manifest-r…
seonghobae Aug 31, 2026
26a7b79
test(acquisition): preserve source-binding diagnostic
seonghobae Aug 31, 2026
db1a730
test(acquisition): revalidate source after failed stage
seonghobae Aug 31, 2026
3541bed
fix(acquisition): revalidate source after stage failure
seonghobae Aug 31, 2026
85ad4e8
fix(acquisition): revalidate failed stages
seonghobae Aug 31, 2026
f63c97b
docs(acquisition): document SHA-256 commit identities
seonghobae Aug 31, 2026
6d31d58
Merge remote-tracking branch 'origin/fix/acquisition-audit-manifest-r…
seonghobae Aug 31, 2026
6d84683
test(acquisition): match failed-stage preflight diagnostic
seonghobae Aug 31, 2026
6fe5dbb
test(acquisition): cover empty pinned file bytes
seonghobae Sep 1, 2026
bffb5ba
merge(main): converge acquisition audit after #525
seonghobae Sep 1, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/acquisition-readiness-scan.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,6 @@ jobs:
fi
test "$(git rev-parse HEAD)" = "${{ github.sha }}"

- name: build data-room manifest
run: npm run acquisition:manifest

- name: run acquisition audit
env:
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
Resolved
NOEMA_AUDIT_REPORT_ONLY: ${{ github.event_name == 'schedule' && '1' || '0' }}
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## Unreleased
- `acquisition:audit`가 exact HEAD 기반 단일 기본 output directory를 manifest·integrity·readiness·deployment 단계에 전달해 새 manifest를 같은 실행에서 소비하며, 기존 `NOEMA_ACQUISITION_AUDIT_OUTPUT_DIR`·`NOEMA_DATA_ROOM_OUTPUT_DIR` 경로 override는 유지한다.
- `ErrorCode`/`errorHints` 분류 체계를 `src/error-codes.ts` 공유 모듈로 추출해 네 개 layered entrypoint(`index.ts` → `worker.ts` → `entrypoint.ts` → `runtime-entrypoint.ts`) 전부가 import한다. 이전에는 `ErrorCode` union이 `index.ts`에만 선언되어 있었고 나머지 세 layer는 `error_code`를 bare string literal로 구성했기 때문에, `runtime-entrypoint.ts`가 실제로 반환하는 `ERR_SERVICE_NOT_READY`(`docs/api-spec.md`의 `GET /ready` 503 계약)가 taxonomy와 hint map 어디에도 없어도 컴파일이 통과했다. 공유 union에 `ERR_SERVICE_NOT_READY`를 추가하고, 세 outer layer의 모든 `error_code` literal에 `satisfies ErrorCode`를 붙여 어느 layer에서 선언되지 않은 code를 추가하더라도 컴파일 타임에 잡히도록 한다.
- `wrangler.toml`의 미사용 `GITHUB_APP_SLUG` var를 제거한다. `src/**/*.ts`의 어떤 `Env` 인터페이스에도 선언되지 않았고 어느 소스 라인에서도 읽히지 않는 빈 설정값이었으며, README `[vars]` 표에도 없었다. 설치 토큰 발급은 이미 `GITHUB_APP_ID`/`GITHUB_APP_PRIVATE_KEY_PEM`과 repository 기반 installation 조회로만 동작하므로 동작 변화는 없다.
- buyer-visible dependency-license inventory의 resolved artifact URL path parameter 검증을 fail-closed로 강화한다. literal·percent-encoded matrix/path parameter의 민감 key와 nested absolute/network-path credential 값을 거부하되, 일반 세미콜론 파일명·benign parameter 및 이후의 ordinary path segment는 credential authority로 오인하지 않는다.
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"patch-validator:image:verify-receipts": "node scripts/verify-patch-validator-image.mjs",
"acquisition:deployment-evidence": "node scripts/acquisition-deployment-evidence-audit.mjs",
"acquisition:integrity": "node scripts/acquisition-data-room-integrity-audit.mjs",
"acquisition:audit": "npm run release:dependency-license-inventory && npm run acquisition:integrity && node scripts/acquisition-readiness-audit.mjs && npm run acquisition:deployment-evidence",
"acquisition:audit": "export NOEMA_ACQUISITION_AUDIT_OUTPUT_DIR=\"${NOEMA_ACQUISITION_AUDIT_OUTPUT_DIR:-${NOEMA_DATA_ROOM_OUTPUT_DIR:-$(pwd)/artifacts/acquisition-readiness/$(git rev-parse HEAD)}}\" && export NOEMA_DATA_ROOM_OUTPUT_DIR=\"${NOEMA_ACQUISITION_AUDIT_OUTPUT_DIR}\" && npm run release:dependency-license-inventory && npm run acquisition:manifest && npm run acquisition:integrity && node scripts/acquisition-readiness-audit.mjs && npm run acquisition:deployment-evidence",
Comment thread
seonghobae marked this conversation as resolved.
Resolved
"acquisition:manifest": "node scripts/acquisition-data-room-manifest.mjs",
"readiness:audit": "node scripts/saleable-readiness-audit.mjs"
},
Expand Down
9 changes: 5 additions & 4 deletions test/acquisition-readiness-scan-toolchain-integrity.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,19 +32,20 @@ describe("acquisition-readiness workflow supply-chain integrity", () => {
expect(workflow).not.toContain(" - name: install");
});

it("revalidates tracked buyer-evidence source before evidence generation", () => {
it("revalidates tracked buyer-evidence source before canonical audit generation", () => {
const integrityIndex = workflow.indexOf(
" - name: verify tracked acquisition source before evidence generation",
);
const manifestIndex = workflow.indexOf(" - name: build data-room manifest");
const auditIndex = workflow.indexOf(" - name: run acquisition audit");

expect(integrityIndex).toBeGreaterThan(-1);
expect(manifestIndex).toBeGreaterThan(integrityIndex);
expect(auditIndex).toBeGreaterThan(integrityIndex);

const integrityBlock = workflow.slice(integrityIndex, manifestIndex);
const integrityBlock = workflow.slice(integrityIndex, auditIndex);
expect(integrityBlock).toContain("git status --porcelain=v1 --untracked-files=no");
expect(integrityBlock).toContain('git rev-parse HEAD');
expect(integrityBlock).toContain('github.sha');
expect(workflow.slice(auditIndex)).toContain("npm run acquisition:audit");
Comment thread
seonghobae marked this conversation as resolved.
Resolved
});

it("fails closed when retained acquisition evidence is missing", () => {
Expand Down
129 changes: 121 additions & 8 deletions test/dependency-license-inventory-release-wiring.test.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,14 @@
import { readFileSync } from "node:fs";
import {
chmodSync,
mkdtempSync,
readFileSync,
rmSync,
writeFileSync,
} from "node:fs";
import { tmpdir } from "node:os";
import { join } from "node:path";
import { spawnSync } from "node:child_process";
import { fileURLToPath } from "node:url";
import { describe, expect, it } from "vitest";

describe("release dependency-license evidence wiring", () => {
Expand All @@ -11,21 +21,124 @@ describe("release dependency-license evidence wiring", () => {
const script = packageJson.scripts[scriptName];

expect(script).toContain("npm run release:dependency-license-inventory");
expect(script.indexOf("npm run release:dependency-license-inventory")).toBeLessThan(
script.indexOf("npm run acquisition:manifest"),
);
expect(
script.indexOf("npm run release:dependency-license-inventory"),
).toBeLessThan(script.indexOf("npm run acquisition:manifest"));
},
);

it("acquisition:audit refreshes deterministic license evidence before integrity verification", () => {
it("acquisition:audit refreshes the manifest exactly once after deterministic license evidence and before integrity verification", () => {
const packageJson = JSON.parse(
readFileSync(new URL("../package.json", import.meta.url), "utf8"),
);
const script = packageJson.scripts["acquisition:audit"];
const inventoryIndex = script.indexOf(
"npm run release:dependency-license-inventory",
);
const manifestIndex = script.indexOf("npm run acquisition:manifest");
const integrityIndex = script.indexOf("npm run acquisition:integrity");

expect(inventoryIndex).toBeGreaterThanOrEqual(0);
expect(manifestIndex).toBeGreaterThanOrEqual(0);
expect(integrityIndex).toBeGreaterThanOrEqual(0);
expect(inventoryIndex).toBeLessThan(manifestIndex);
expect(manifestIndex).toBeLessThan(integrityIndex);
expect(script.match(/npm run acquisition:manifest/g) ?? []).toHaveLength(1);
});

it.each([
{ dataRoomName: undefined, auditName: undefined },
{ dataRoomName: "data-room-output", auditName: undefined },
{ dataRoomName: "conflicting-data-room", auditName: "audit-output" },
])(
"shares one acquisition output directory across every audit stage ($dataRoomName, $auditName)",
({ dataRoomName, auditName }) => {
const root = fileURLToPath(new URL("..", import.meta.url));
const temporaryDirectory = mkdtempSync(
join(tmpdir(), "noema-acquisition-audit-"),
);
const tracePath = join(temporaryDirectory, "trace");
const dataRoomPath = dataRoomName
? join(temporaryDirectory, dataRoomName)
: undefined;
const auditPath = auditName
? join(temporaryDirectory, auditName)
: undefined;
const packageJson = JSON.parse(
readFileSync(join(root, "package.json"), "utf8"),
);
const stub = `#!/bin/sh
set -eu
printf '%s|%s\\n' "$NOEMA_ACQUISITION_AUDIT_OUTPUT_DIR" "$NOEMA_DATA_ROOM_OUTPUT_DIR" >> "$NOEMA_AUDIT_TRACE"
if [ "\${1}" = "run" ] && [ "\${2}" = "acquisition:manifest" ]; then
mkdir -p "$NOEMA_DATA_ROOM_OUTPUT_DIR"
: > "$NOEMA_DATA_ROOM_OUTPUT_DIR/data-room-manifest.json"
elif [ "\${1}" = "run" ]; then
test -f "$NOEMA_ACQUISITION_AUDIT_OUTPUT_DIR/data-room-manifest.json" || [ "\${2}" = "release:dependency-license-inventory" ]
else
test -f "$NOEMA_ACQUISITION_AUDIT_OUTPUT_DIR/data-room-manifest.json"
fi
`;
writeFileSync(join(temporaryDirectory, "npm"), stub);
writeFileSync(join(temporaryDirectory, "node"), stub);
chmodSync(join(temporaryDirectory, "npm"), 0o755);
chmodSync(join(temporaryDirectory, "node"), 0o755);

try {
const result = spawnSync(
"/bin/sh",
["-c", packageJson.scripts["acquisition:audit"]],
Comment thread
seonghobae marked this conversation as resolved.
Resolved
{
cwd: root,
encoding: "utf8",
env: {
PATH: `${temporaryDirectory}:${process.env.PATH ?? ""}`,
NOEMA_AUDIT_TRACE: tracePath,
...(dataRoomPath
? { NOEMA_DATA_ROOM_OUTPUT_DIR: dataRoomPath }
: {}),
...(auditPath
? { NOEMA_ACQUISITION_AUDIT_OUTPUT_DIR: auditPath }
: {}),
},
},
);
expect(result.stderr).toBe("");
expect(result.status).toBe(0);
const observedPaths = readFileSync(tracePath, "utf8")
.trim()
.split("\n");
const expectedPath =
auditPath ??
dataRoomPath ??
join(
root,
"artifacts",
"acquisition-readiness",
spawnSync("git", ["rev-parse", "HEAD"], {
cwd: root,
encoding: "utf8",
}).stdout.trim(),
);
expect(new Set(observedPaths)).toEqual(
new Set([`${expectedPath}|${expectedPath}`]),
);
} finally {
rmSync(temporaryDirectory, { recursive: true, force: true });
}
},
);

expect(script).toContain("npm run release:dependency-license-inventory");
expect(script.indexOf("npm run release:dependency-license-inventory")).toBeLessThan(
script.indexOf("npm run acquisition:integrity"),
it("scheduled acquisition scan delegates one audit and never pre-materializes the buyer manifest", () => {
const workflow = readFileSync(
new URL(
"../.github/workflows/acquisition-readiness-scan.yml",
import.meta.url,
),
"utf8",
);

expect(workflow.match(/npm run acquisition:audit/g) ?? []).toHaveLength(1);
expect(workflow).not.toContain("npm run acquisition:manifest");
});
});
Loading