fix(acquisition): refresh manifest before integrity audit - #510
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (7)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough인수 감사 실행을 단일 Node 오케스트레이터로 통합했습니다. 워크플로에서 별도 manifest 생성을 제거했습니다. tracked-byte 검증은 로컬 Git blob 해시를 사용합니다. SHA-1과 SHA-256 commit 식별자를 지원합니다. Changes인수 감사 파이프라인
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: 🔵 Low · up to The PR now binds acquisition evidence to one revision and verifies source stability, but a later failure can still leave earlier artifacts retained without a completion marker, allowing incomplete evidence to be mistaken for valid buyer evidence. The change is mergeable with explicit owner awareness or follow-up to gate retention or clearly mark failed outputs. Sequence Diagram(s)sequenceDiagram
participant Workflow
participant AcquisitionAudit as acquisition-audit.mjs
participant Npm
participant AuditSteps as 감사 단계
Workflow->>AcquisitionAudit: npm run acquisition:audit
AcquisitionAudit->>Npm: 의존성 라이선스 인벤토리 실행
Npm->>AuditSteps: manifest, integrity, readiness, deployment 실행
AuditSteps-->>AcquisitionAudit: 단계별 종료 상태
AcquisitionAudit-->>Workflow: 감사 결과와 종료 코드
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 8.70% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 23 functions across 24 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
⚔️ Resolve merge conflicts 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…-manifest-refresh
…-manifest-refresh # Conflicts: # CHANGELOG.md
…-manifest-refresh # Conflicts: # CHANGELOG.md
…-manifest-refresh # Conflicts: # CHANGELOG.md # test/acquisition-git-exact-tree-binding.test.ts
…efresh' into fix/acquisition-audit-manifest-refresh
…efresh' into fix/acquisition-audit-manifest-refresh # Conflicts: # docs/acquisition-data-room-integrity.md # scripts/acquisition-audit.mjs
Scope
Repair Noema acquisition-readiness evidence sequencing so deterministic dependency-license evidence, buyer manifest generation, integrity verification, readiness/deployment evaluation, and retained buyer evidence remain bound to one exact source/output authority.
The canonical audit owns one ordered path: dependency-license inventory -> manifest -> integrity -> readiness -> deployment evidence. The branch preserves cross-platform execution, exact tracked-checkout authentication, SHA-1/SHA-256 Git object formats, immutable audit-executable inventory, and fail-closed tree/content verification.
Repair lineage
db1a73052cf6a9a0c2c33e846b4a2f0ac59b0accadded a direct CLI regression where a failing stage mutates tracked source; post-stage authentication must win over child-status propagation.3541bed0a1b7834969a2240693d7819f5d294171and6d84683c3a1dc1d1906e792dbce61bb90ad33468repaired that boundary while retaining SHA-1/SHA-256 identity and exact package-lock byte authentication.6fe5dbba440eb24216c780b4353c1563e4b99442added a real Git-backed empty-file regression and closed the earlier 99.97% branch-coverage gap without excluding production code.mainthen moved by fix(operations): preserve external scheduler evidence source #525 todd6ff2aa46f8daa8aa9a4e19e0d6825f4a98f383, causing Application33454068355to fail correctly at the live-base guard before product tests.bffb5ba5a416650c6f5876a27e29dfc6649d8318is a non-destructive two-parent convergence of the unchanged acquisition head with current protected main. Its tree was verified from both parents before the branch ref moved: relative to current main it preserves the acquisition delta and both acquisition CHANGELOG lines; relative to predecessor head it preserves all nine fix(operations): preserve external scheduler evidence source #525 changes, including the scheduler evidence source/test hardening and scheduler CHANGELOG line. The branch ref moved withforce=falseonly after both comparisons passed.Current exact authority
Only evidence for unchanged exact head
bffb5ba5a416650c6f5876a27e29dfc6649d8318on protectedmain@dd6ff2aa46f8daa8aa9a4e19e0d6825f4a98f383is eligible.33461927255, reviewer-ci33461927279, and required Security Scan33461927313are terminal-success;33461927548remains in progress and is non-passing until its image/runtime/SBOM/vulnerability/provenance checks finish terminal-success;Guardrails
.github, naruon, contextual-orchestrator, or another dedicated-writer repository from this lane.