fix(kpi): reject compact credential-shaped source IDs (#496 merge-result promotion) #507
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,32 @@ | ||
| const compactCredentialLabelPattern = /(^|[^a-z0-9])(clientsecret|sessiontoken|authtoken|accesstoken|refreshtoken|accesskeyid|secretaccesskey|signingkey)([^a-z0-9]|$)/i; | ||
| const credentialHeaderAssignmentPattern = /(^|[^a-z0-9])(authorization|bearer|credential|sig|signature|pwd|passphrase)\s*[:=]/i; | ||
| const githubCredentialTokenPattern = /(^|[^a-z0-9])(github_pat_|gh[pousr]_)/i; | ||
| const npmCredentialTokenPattern = /(^|[^a-z0-9])npm_[a-z0-9]{36}([^a-z0-9]|$)/i; | ||
| const unsafeIdentityCodePointPattern = /[\p{Cc}\p{Cf}\p{Cs}\p{Zl}\p{Zp}]/u; | ||
| const nonCanonicalSpacePattern = /[\u00A0\u1680\u2000-\u200A\u202F\u205F\u3000]/u; | ||
| const percentEncodedIdentityPattern = /%[0-9A-Fa-f]{2}/; | ||
| const nonHierarchicalLocatorSchemePattern = /^(?:about|data|javascript|mailto|sms|tel|vbscript):/i; | ||
|
|
||
| export function hasUnsafeSourceId(value) { | ||
| const rawSourceId = String(value ?? ""); | ||
| const sourceId = rawSourceId.trim(); | ||
| const normalized = sourceId.toLowerCase(); | ||
| const camelSeparatedSourceId = sourceId.replace(/([a-z0-9])([A-Z])/g, "$1_$2"); | ||
| return rawSourceId !== sourceId | ||
| || sourceId !== sourceId.normalize("NFKC") | ||
| || unsafeIdentityCodePointPattern.test(sourceId) | ||
| || nonCanonicalSpacePattern.test(sourceId) | ||
| || percentEncodedIdentityPattern.test(sourceId) | ||
| || normalized === "placeholder" | ||
| || normalized === "todo" | ||
| || normalized === "tbd" | ||
| || normalized.startsWith("replace-with-") | ||
| || sourceId.includes("://") | ||
| || nonHierarchicalLocatorSchemePattern.test(sourceId) | ||
| || sourceId.includes("?") | ||
| || githubCredentialTokenPattern.test(sourceId) | ||
| || npmCredentialTokenPattern.test(sourceId) | ||
| || /(^|[^a-z0-9])(token|secret|password|passwd|api[_-]?key|access[_-]?key|private[_-]?key)([^a-z0-9]|$)/i.test(camelSeparatedSourceId) | ||
| || compactCredentialLabelPattern.test(sourceId) | ||
| || credentialHeaderAssignmentPattern.test(sourceId); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| import { describe, expect, it } from "vitest"; | ||
| import { hasUnsafeSourceId } from "../scripts/lib/source-id.mjs"; | ||
|
|
||
| describe("source-id exact production coverage", () => { | ||
| it.each([ | ||
| " source", | ||
| "source ", | ||
| "ｓｏｕｒｃｅ", | ||
| "source\u0000id", | ||
| "source\u202Eid", | ||
| "source\uD800id", | ||
| "source\u2028id", | ||
| "source\u2029id", | ||
| "source\u00A0id", | ||
| "placeholder", | ||
| "todo", | ||
| "tbd", | ||
| "replace-with-source", | ||
| "https://logs.noema.internal/export", | ||
| "source?token=redacted", | ||
| "ghp_EXAMPLEVALUE123456", | ||
| "npm_abcdefghijklmnopqrstuvwxyz0123456789", | ||
| "token=EXAMPLEVALUE123456", | ||
| "apiKey=EXAMPLEVALUE123456", | ||
| "clientSecret=EXAMPLEVALUE123456", | ||
| "authorization=Bearer EXAMPLEVALUE123456", | ||
| ])("executes a fail-closed source identity branch for %j", (sourceId) => { | ||
| expect(hasUnsafeSourceId(sourceId)).toBe(true); | ||
| }); | ||
|
|
||
| it.each([ | ||
| undefined, | ||
| null, | ||
| "", | ||
| "cloudflare-logpush:noema-production", | ||
| "github-app:noema-reviewer", | ||
| "npm-package-metadata", | ||
| "source-é", | ||
| ])("executes a non-secret source identity branch for %j", (sourceId) => { | ||
| expect(hasUnsafeSourceId(sourceId)).toBe(false); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 Behavior change lacks changelog entry
New
hasUnsafeSourceIdrejections are absent from the Unreleased changelog. Repository policy requires every behavior change to be recorded.Was this helpful? React with 👍 or 👎 to provide feedback.