fix(kpi): reject compact credential-shaped source IDs (#496 merge-result promotion) - #507
fix(kpi): reject compact credential-shaped source IDs (#496 merge-result promotion)#507seonghobae wants to merge 36 commits into
Conversation
|
Warning Review limit reachedNext included review available in 51 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| export function hasUnsafeSourceId(value) { | ||
| const rawSourceId = String(value ?? ""); | ||
| const sourceId = rawSourceId.trim(); | ||
| const normalized = sourceId.toLowerCase(); | ||
| const camelSeparatedSourceId = sourceId.replace(/([a-z0-9])([A-Z])/g, "$1_$2"); | ||
| return rawSourceId !== sourceId | ||
| || sourceId !== sourceId.normalize("NFKC") | ||
| || unsafeIdentityCodePointPattern.test(sourceId) | ||
| || nonCanonicalSpacePattern.test(sourceId) |
There was a problem hiding this comment.
🔍 Behavior change lacks changelog entry
New hasUnsafeSourceId rejections are absent from the Unreleased changelog. Repository policy requires every behavior change to be recorded.
Was this helpful? React with 👍 or 👎 to provide feedback.
| "scripts/prepare-agent-pr-message.mjs", | ||
| "scripts/verify-orchestrator-gateway.mjs", | ||
| "scripts/lib/orchestrator-gateway.mjs", | ||
| "scripts/lib/source-id.mjs", |
There was a problem hiding this comment.
🔍 Local test result unavailable
npm test cannot run without installed dependencies. Exact-head CI must establish the test and 100% coverage results.
Was this helpful? React with 👍 or 👎 to provide feedback.
|
Temporarily closing this promotion while its branch is extended into a single backlog-integration tree. This prevents one full promotion workflow set per Draft PR. The branch will be reopened only after #497, #501, #503, #504, and the salvageable #425 documentation delta are either incorporated with verified GitHub merge parents or explicitly excluded for a demonstrated conflict/defect. Temporary workflow trigger guards used only on the staging branch will be removed before reopening, so the final tree receives one fresh CI, reviewer-ci, required Security Scan, and image/SBOM run. |
1 participant
Promotes GitHub's verified current-base merge result for draft PR #496 without force-updating or rewriting the source branch.
Source PR: #496
Source tree head after no-content refresh:
f1357b02cb457d9a0d606c6207f84267526f3a93Protected base incorporated:
9fd64b184a7df52922efe0b6c121d714f6f6217dExact promotion head:
34d37b0f02ab52e5982884df1defc50f068e1ceaThe promotion head is a GitHub-signed two-parent merge commit. Its first parent is the current protected base and its second parent is the source PR head. The refresh commit preserved the exact source tree of predecessor head
4e2cadbb56cff3b143d70dc99a78b7f7347a8afe.The predecessor exact source tree passed CI, reviewer-ci, Security Scan, and patch-validator-image. This current-base merge result must pass its own CI, reviewer-ci, and required Security Scan before merge. After verified merge, #496 will be closed as superseded.