Skip to content

fix(oidc): roll forward trusted central workflow source #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seonghobae merged 5 commits into from
Aug 21, 2026
Merged

fix(oidc): roll forward trusted central workflow source #438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2117e44
test(oidc): require current central workflow source
seonghobae Aug 21, 2026
0b4ba5c
fix(oidc): roll forward trusted workflow source
seonghobae Aug 21, 2026
4286ba6
test(oidc): require latest central workflow source
seonghobae Aug 21, 2026
61d6cb4
fix(oidc): advance trusted workflow source again
seonghobae Aug 21, 2026
b2b1b31
chore(oidc): restore wrangler newline
seonghobae Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/trusted-workflow-source-rollforward.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { readFileSync } from "node:fs";
import { describe, expect, it } from "vitest";

const auditedCentralWorkflowSourceSha =
"55a8b576725451dfe0a21a57d36a2f1a41619b24";
"731af58e954901c4f1cc853231c592abb1eaf617";

describe("trusted central workflow source revision", () => {
it("binds the deployed OIDC trust configuration to the audited central source commit", () => {
Expand Down
2 changes: 1 addition & 1 deletion wrangler.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ ALLOWED_AUDIENCE = "cwl-noema-review"
ALLOWED_REPOSITORY_OWNER = "ContextualWisdomLab"
ALLOWED_WORKFLOW_REPOSITORY = "ContextualWisdomLab/.github"
ALLOWED_WORKFLOW_REF_PREFIX = "ContextualWisdomLab/.github/.github/workflows/noema-review.yml@refs/heads/main"
ALLOWED_WORKFLOW_SHA = "55a8b576725451dfe0a21a57d36a2f1a41619b24"
ALLOWED_WORKFLOW_SHA = "731af58e954901c4f1cc853231c592abb1eaf617"

@devin-ai-integration devin-ai-integration Bot Aug 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 SHA rollforward consistent; external commit identity unverifiable

The new SHA matches between the test constant and wrangler.toml ALLOWED_WORKFLOW_SHA, and no reference to the old SHA remains. Whether 731af58... actually points to the intended central .github commit with a byte-identical noema-review.yml blob cannot be verified from this repo; it rests on external evidence in the PR description.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

GITHUB_API_BASE = "https://api.github.com"
GITHUB_APP_SLUG = "noema"
NOEMA_RATE_LIMIT_PER_MINUTE = "60"
Expand Down
Loading