fix(oidc): roll forward trusted central workflow source - #438
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthrough감사된 중앙 워크플로 소스의 커밋 SHA를 새 값으로 갱신했습니다. Changes감사된 워크플로 소스 갱신
Estimated code review effort: 1 (매우 낮음) | ~2분 ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| ALLOWED_WORKFLOW_REPOSITORY = "ContextualWisdomLab/.github" | ||
| ALLOWED_WORKFLOW_REF_PREFIX = "ContextualWisdomLab/.github/.github/workflows/noema-review.yml@refs/heads/main" | ||
| ALLOWED_WORKFLOW_SHA = "55a8b576725451dfe0a21a57d36a2f1a41619b24" | ||
| ALLOWED_WORKFLOW_SHA = "731af58e954901c4f1cc853231c592abb1eaf617" |
There was a problem hiding this comment.
🔍 SHA rollforward consistent; external commit identity unverifiable
The new SHA matches between the test constant and wrangler.toml ALLOWED_WORKFLOW_SHA, and no reference to the old SHA remains. Whether 731af58... actually points to the intended central .github commit with a byte-identical noema-review.yml blob cannot be verified from this repo; it rests on external evidence in the PR description.
Was this helpful? React with 👍 or 👎 to provide feedback.
Scope
Roll Noema's immutable OIDC reusable-workflow source trust to the current protected central
.githubcommit without changing the trusted workflow bytes or widening the trusted ref.Exact evidence
6b8e4ddcdbf3a6f4a20b9859fc51af1f24e9aa71.githubprotected source commit:731af58e954901c4f1cc853231c592abb1eaf617noema-review.ymlblob at that commit:59b25e343444d0b97fc1c7ba33cb15543dd701024c7077b3b061f8d674f0932dfecccfe8ad85f93a; the central main movement changed repository source revision, not the trusted workflow bytes.Test-first repair
0b4ba5c040a87344e7546f15742556a700b850dfcorrectly bound Noema to then-current central4c7077....mainsubsequently advanced to731af58..., so immutable source trust became stale even thoughnoema-review.ymlstayed byte-identical.4286ba60ed60827f981c6afdc14556256d9394c6: the executable trust regression requires current central commit731af58...whilewrangler.tomlstill trusted4c7077....b2b1b31b7046604f475d3db98fdc8b775ae20a44: productionALLOWED_WORKFLOW_SHAis rolled forward to731af58...; an intermediate whole-file write briefly removed the canonical final newline fromwrangler.toml, exact diff verification caught it, and the final candidate restores that newline.0b4ba5c..., the final candidate changes exactly one line in the trust regression and one line inwrangler.toml.The trusted workflow path/ref and blob bytes are unchanged; this does not widen workflow authority.
Current exact-head evidence
32460183414: queued32460183364: queued32460183360: queuedQueued evidence is non-passing and predecessor runs are not reused.
Merge boundary
Keep Draft until application CI, reviewer-ci and eligible central Security Scan are terminal-success on unchanged exact head
b2b1b31..., protectedmainis freshly confirmed as its live base, central workflow source commit/blob authority is unchanged, and review/thread state is freshly clean.Summary by CodeRabbit