fix(ci): fall back to REST for live-base availability - #416
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughCI 워크플로의 두 기준 브랜치 조회 경로가 일시적인 GraphQL 오류를 최대 3회 재시도합니다. 재시도 후 실패하면 REST API로 SHA를 조회합니다. 새 Vitest 테스트가 두 REST 폴백과 실패 메시지를 검증합니다. Changes기준 브랜치 SHA 조회
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant CI워크플로
participant GitHubGraphQLAPI
participant GitHubRESTAPI
CI워크플로->>GitHubGraphQLAPI: 기준 브랜치 SHA 조회
GitHubGraphQLAPI-->>CI워크플로: 502/503/504 오류
CI워크플로->>GitHubGraphQLAPI: 최대 3회 재시도
CI워크플로->>GitHubRESTAPI: live Git ref 조회
GitHubRESTAPI-->>CI워크플로: 기준 브랜치 SHA 반환
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
marked this pull request as ready for review
August 17, 2026 18:44
Contributor
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #412 application CI run
32052374630failed twice atverify live pull-request base before lockfile control. Exact-head jobs95460492226and rerun95463563690each exhausted the existing three-attempt GraphQL retry contract while resolving the livemaintip. #412 already contains protectedmain965939e305f5addc5bfca3001b901b9cac5863df, so the repeated failure is the Noema-owned live-base transport reliability boundary rather than an ancestry defect.RED → GREEN lineage
3d39cb90d9947e61c3424b188f47eda07bfa3995: addedtest/ci-live-base-rest-fallback.test.ts, requiring both pre- and post-verification resolvers to have a live Git-ref REST fallback and forbidding PR snapshotgithub.event.pull_request.base.shaas authority. Its initial runs were superseded when the repair head was pushed.3b24d033bfcbf5f475361d00d482378b4696f7f4: preserves the three bounded GraphQL attempts for HTTP 502/503/504; only after all three transient availability failures does it perform one fail-closedGET repos/${GITHUB_REPOSITORY}/git/ref/heads/${NOEMA_PR_BASE_REF}read. Non-transient GraphQL errors still fail immediately, raw diagnostics are not exposed, and the returned SHA still passes the existing 40-hex, ancestry and mid-run drift checks.Exact-head evidence
For unchanged head
3b24d033bfcbf5f475361d00d482378b4696f7f4:32055665137: success — exact checkout, live-base verification, lockfile control, fullrelease verify, and final live-base drift refusal all passed;32055665227: success;32055665181: success;18794436requires the central Security Scan workflow and contains no counted-approval rule or bypass actor.The PR is Ready. No predecessor-head evidence is used as current success.
Ownership
Only Noema CI/test code is changed. No dedicated dependency repository is mutated.
Summary by CodeRabbit
버그 수정
테스트