Skip to content

fix(governance): separate observed workflow evidence from target policy - #412

Merged
seonghobae merged 8 commits into
mainfrom
fix/governance-observed-workflow-evidence
Aug 17, 2026
Merged

fix(governance): separate observed workflow evidence from target policy#412
seonghobae merged 8 commits into
mainfrom
fix/governance-observed-workflow-evidence

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Problem

Live Noema governance currently enforces the organization-owned central Security Scan workflow, while stronger pull-request/review/status/force-push/deletion controls remain target governance under issue #27. The repository audit correctly keeps the stronger target at FAIL, but protected-main evidence did not preserve the exact required-workflow identity as first-class observed evidence in its durable report.

RED → repair lineage

The existing regression sequence separates observed authority from target policy, propagates it into the durable report/summary, and rejects malformed structured identity fields instead of stringifying them into pseudo-authority. The current branch was then non-destructively reconstructed onto protected main after #416 merged; all four unique governance files were preserved exactly.

Current exact evidence

  • protected base: 28fb5db67c9193f8cf3a96fb3484ff4d6f8fc18b
  • exact head: 29547d965fed9450791f8974c8f98882af2c446b
  • application CI 32056726784: success
  • reviewer-ci 32056726744: success
  • central Security Scan 32056726756: success
  • formal submitted reviews: 0
  • unresolved review threads: 0
  • current branch relation: contains protected base and preserves exactly the four intended governance audit/test files.

The stronger target-governance result remains FAIL when pull-request/review/status/non-fast-forward/deletion controls are absent; observing central Security Scan does not promote those missing controls to PASS. The live ruleset requires the central Security Scan workflow and does not currently impose a counted-approval rule.

Ownership

This PR changes only Noema audit/test code. It does not mutate central .github, weaken the live required-workflow rule, or claim desired future governance controls are already live.

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 56 minutes

Limit details: You’ve used all 1 included review currently available under your plan.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: cbc25603-e8d4-4ed7-8109-7b0d44864224

📥 Commits

Reviewing files that changed from the base of the PR and between 28fb5db and 29547d9.

📒 Files selected for processing (4)
  • scripts/lib/main-governance-audit.mjs
  • scripts/main-governance-audit.mjs
  • test/main-governance-audit-script.test.ts
  • test/main-governance-observed-workflows.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as ready for review August 17, 2026 17:31
@cursor

cursor Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@seonghobae
seonghobae merged commit 70663fb into main Aug 17, 2026
16 checks passed
@seonghobae
seonghobae deleted the fix/governance-observed-workflow-evidence branch August 17, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant