Skip to content

fix(coverage): measure safeHash in operational core - #340

Closed
seonghobae wants to merge 2 commits into
mainfrom
fix/coverage-safehash-26de1c
Closed

fix(coverage): measure safeHash in operational core#340
seonghobae wants to merge 2 commits into
mainfrom
fix/coverage-safehash-26de1c

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Purpose

Advance #84 with the next bounded Region A coverage-truthfulness slice on protected main 26de1c3ab69106900410f6ceb18420109bfd9f8f. This lane measures only private safeHash, immediately after #333 made the adjacent trace helpers measurable. It does not touch the credential/OIDC/GitHub App Region B or claim #84 complete.

Test-first RED

Exact RED head: 36684096751774e77417c9176bceea5e047347ed.

The RED changes only test/coverage-ignore-operational-helpers.test.ts, extending the existing deterministic source contract to require safeHash to be outside any broad v8 ignore region. Protected source currently places safeHash immediately inside Region A, so the new assertion is intentionally RED until production coverage instrumentation is narrowed.

Existing realistic test/worker.test.ts already exercises safeHash through the public Worker boundary: an overlong untrusted client identifier is reduced to a bounded client key and the resulting rate-limit client_hash is checked against an independent FNV-1a test implementation. The GREEN change must therefore remove only the coverage exclusion around this already-observed behavior, not add a no-op direct export or weaken the 100% gate.

Safety / evidence boundary

Keep Draft. RED failure is evidence, not merge authority. After the smallest GREEN, require fresh unchanged-head application ci, reviewer-ci, protected-base central Security Scan, configured exact 100% owned production statement/branch/function/line coverage with realistic tests, and zero valid unresolved findings. Pending/queued/skipped/absent/neutral/failed/cancelled/stale/predecessor/status-only/model-only/rate-limited evidence remains non-passing.

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 208280db-76df-48ce-ad75-2bdc122ec7b2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant