fix(coverage): measure safeHash in operational core - #340
Closed
seonghobae wants to merge 2 commits into
Closed
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Advance #84 with the next bounded Region A coverage-truthfulness slice on protected
main26de1c3ab69106900410f6ceb18420109bfd9f8f. This lane measures only privatesafeHash, immediately after #333 made the adjacent trace helpers measurable. It does not touch the credential/OIDC/GitHub App Region B or claim #84 complete.Test-first RED
Exact RED head:
36684096751774e77417c9176bceea5e047347ed.The RED changes only
test/coverage-ignore-operational-helpers.test.ts, extending the existing deterministic source contract to requiresafeHashto be outside any broadv8 ignoreregion. Protected source currently placessafeHashimmediately inside Region A, so the new assertion is intentionally RED until production coverage instrumentation is narrowed.Existing realistic
test/worker.test.tsalready exercisessafeHashthrough the public Worker boundary: an overlong untrusted client identifier is reduced to a bounded client key and the resulting rate-limitclient_hashis checked against an independent FNV-1a test implementation. The GREEN change must therefore remove only the coverage exclusion around this already-observed behavior, not add a no-op direct export or weaken the 100% gate.Safety / evidence boundary
mainat construction;1d8b9a3fafc07f0df6e79a286f141d21e22bc1f9; this slice changes only private coverage instrumentation and the existing source-contract test;Keep Draft. RED failure is evidence, not merge authority. After the smallest GREEN, require fresh unchanged-head application
ci,reviewer-ci, protected-base centralSecurity Scan, configured exact 100% owned production statement/branch/function/line coverage with realistic tests, and zero valid unresolved findings. Pending/queued/skipped/absent/neutral/failed/cancelled/stale/predecessor/status-only/model-only/rate-limited evidence remains non-passing.