fix(coverage): restack operational trace helper measurement on d8bdcf main - #333
Conversation
|
Warning Review limit reached
Next review available in: 31 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Purpose
Advance #84 with a clean, bounded successor to #332 on the current protected-main lineage after #331 advanced
main. This successor preserves only the test-first operational trace-helper coverage slice and does not transfer predecessor CI, review, scanner, coverage, model, production, release, deployment, or acquisition authority.Exact construction
mainat the final pre-write refetch:d8bdcf79149635e5c34c992e91ce22b9a78c9b49;30dd9bc0e61a6f2304298cdb3ba9fff5e95e0fa0;c3152a571fda79336c46135dff55c723128d4fc8;src/index.ts,test/coverage-ignore-operational-helpers.test.ts, andtest/trace-header-coverage.test.ts;The resulting commit changes only the V8 coverage boundary around three private operational helpers plus the two focused test files. No intervening protected-main bytes are replayed or overwritten.
RED -> GREEN contract retained
The predecessor established a deterministic RED contract that rejects broad V8 exclusion of
jsonResponse,trustedTraceHeader, andtraceIdFromRequest, then added realisticRequest/Responseregressions for validx-request-idpropagation and invalid-request-id fallback to a validx-correlation-id. GREEN moves the first/* v8 ignore start */boundary from beforejsonResponseto immediately beforesafeHash, so those three owned production helpers become measured while the remaining Region A helpers and credential/OIDC/GitHub App Region B remain unchanged.This is a coverage-truthfulness increment, not a claim that #84 is complete or that all security-critical production code is now executed by tests.
Writer and evidence boundary
Stale #86 still has exact unchanged head
1d8b9a3fafc07f0df6e79a286f141d21e22bc1f9; it owns public-API documentation work touchingsrc/index.ts. This successor changes only private coverage instrumentation plus focused tests. Freeze this lane if #86 moves.Keep Draft until this unchanged exact head receives fresh terminal-success application
ci,reviewer-ci, protected-base-eligible centralSecurity Scan, configured exact 100% owned production statement/branch/function/line coverage with realistic tests, and zero valid unresolved findings. Pending, queued, skipped, absent, neutral, failed, cancelled, stale, predecessor, status-only, model-only, or rate-limited evidence is non-passing.No force push, destructive rebase, workflow mutation, gate weakening, secret/reviewer invention, self-approval, release, deployment, persistence claim, or outbound-license decision is introduced.
Supersedes #332 only after this clean successor is independently established; predecessor checks never transfer.