Skip to content

fix(coverage): restack operational trace helper measurement on d8bdcf main - #333

Merged
seonghobae merged 1 commit into
mainfrom
fix/coverage-trace-helpers-d8bdcf
Aug 14, 2026
Merged

fix(coverage): restack operational trace helper measurement on d8bdcf main#333
seonghobae merged 1 commit into
mainfrom
fix/coverage-trace-helpers-d8bdcf

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Purpose

Advance #84 with a clean, bounded successor to #332 on the current protected-main lineage after #331 advanced main. This successor preserves only the test-first operational trace-helper coverage slice and does not transfer predecessor CI, review, scanner, coverage, model, production, release, deployment, or acquisition authority.

Exact construction

  • protected main at the final pre-write refetch: d8bdcf79149635e5c34c992e91ce22b9a78c9b49;
  • predecessor fix(coverage): measure operational trace helpers #332 exact unchanged head at the final pre-write refetch: 30dd9bc0e61a6f2304298cdb3ba9fff5e95e0fa0;
  • successor exact head: c3152a571fda79336c46135dff55c723128d4fc8;
  • parent is exactly the protected-main SHA above;
  • net scope is exactly three paths: src/index.ts, test/coverage-ignore-operational-helpers.test.ts, and test/trace-header-coverage.test.ts;
  • successor source/test blobs are exact predecessor-head blobs, overlaid onto the exact current protected-main tree.

The resulting commit changes only the V8 coverage boundary around three private operational helpers plus the two focused test files. No intervening protected-main bytes are replayed or overwritten.

RED -> GREEN contract retained

The predecessor established a deterministic RED contract that rejects broad V8 exclusion of jsonResponse, trustedTraceHeader, and traceIdFromRequest, then added realistic Request/Response regressions for valid x-request-id propagation and invalid-request-id fallback to a valid x-correlation-id. GREEN moves the first /* v8 ignore start */ boundary from before jsonResponse to immediately before safeHash, so those three owned production helpers become measured while the remaining Region A helpers and credential/OIDC/GitHub App Region B remain unchanged.

This is a coverage-truthfulness increment, not a claim that #84 is complete or that all security-critical production code is now executed by tests.

Writer and evidence boundary

Stale #86 still has exact unchanged head 1d8b9a3fafc07f0df6e79a286f141d21e22bc1f9; it owns public-API documentation work touching src/index.ts. This successor changes only private coverage instrumentation plus focused tests. Freeze this lane if #86 moves.

Keep Draft until this unchanged exact head receives fresh terminal-success application ci, reviewer-ci, protected-base-eligible central Security Scan, configured exact 100% owned production statement/branch/function/line coverage with realistic tests, and zero valid unresolved findings. Pending, queued, skipped, absent, neutral, failed, cancelled, stale, predecessor, status-only, model-only, or rate-limited evidence is non-passing.

No force push, destructive rebase, workflow mutation, gate weakening, secret/reviewer invention, self-approval, release, deployment, persistence claim, or outbound-license decision is introduced.

Supersedes #332 only after this clean successor is independently established; predecessor checks never transfer.

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 31 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 840609ae-907d-437e-9777-32b6787dec0b

📥 Commits

Reviewing files that changed from the base of the PR and between d8bdcf7 and c3152a5.

📒 Files selected for processing (3)
  • src/index.ts
  • test/coverage-ignore-operational-helpers.test.ts
  • test/trace-header-coverage.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as ready for review August 14, 2026 21:35
@seonghobae
seonghobae merged commit 26de1c3 into main Aug 14, 2026
16 checks passed
@seonghobae
seonghobae deleted the fix/coverage-trace-helpers-d8bdcf branch August 14, 2026 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant