fix(security): restack vulnerability response media type on current main - #296
Closed
seonghobae wants to merge 1 commit into
Closed
fix(security): restack vulnerability response media type on current main#296seonghobae wants to merge 1 commit into
seonghobae wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Create a clean current-protected-main successor for #277 after its application CI correctly failed the live-base drift guard. This successor preserves only the reviewed private-vulnerability-reporting response media-type hardening and its focused adapter regressions. No predecessor CI, scanner, review, model, or operational evidence transfers.
Exact construction identity
mainimmediately before construction:e60eff4c71dc4997b9990a79daa5069d6f5e2037;d4020e3c7b1490d3108965debc0099f620ff82d8;72b47a90a46aae44ce72c5da707d54993a0eb4e7;f98166a3b67d9a17bc52b0455ce5f93a73d1a1c0;main, 1 ahead / 0 behind, merge base exactly the protected head;scripts/private-vulnerability-reporting-audit.mjsandtest/private-vulnerability-reporting-adapter.test.ts.RCA and preserved security behavior
#277's exact-head checkout and package-manager verification succeeded; application CI then failed only at
verify live pull-request base before lockfile controlbecause protectedmainhad advanced. The predecessor's reviewer-ci and protected-base Security Scan were terminal success, but those results are historical only.The successor retains the reviewed fail-closed boundary:
application/jsonandapplication/vnd.github+json, case-insensitively;text/plain; profile=application/jsonbefore declared-length processing or response-body access;#277 has no formal reviews or inline review threads at the latest pre-write refetch.
Evidence boundary
Keep Draft until this unchanged exact head has fresh terminal-success application
ci,reviewer-ci, protected-base-eligible centralSecurity Scan, exact 100% owned production statement/branch/function/line coverage with realistic tests, and zero valid unresolved findings. Pending, queued, skipped, absent, neutral, failed, cancelled, stale, predecessor, status-only, model-only, or rate-limited evidence is non-passing.Immediately before Ready or merge, re-resolve protected
main, exact head/ref/ancestry, workflow checkout SHAs, live rulesets, exact central.githubSecurity Scan authority, reviews, threads, and active-writer state. Current live Noema policy requires the central Security Scan workflow and does not currently impose an independent formal-approval rule; no synthetic approval requirement is introduced.This change hardens setting evidence only. It does not prove that private vulnerability reporting is enabled, exposed to reporters, monitored, staffed, or exercised end to end; issue #73 retains those operational acceptance requirements. It does not weaken gates, create a repair workflow, publish/deploy, invent evidence, or select an outbound license.
Supersedes #277 only after fresh exact-head verification.