fix(security): authenticate vulnerability-status JSON media type - #277
fix(security): authenticate vulnerability-status JSON media type#277seonghobae wants to merge 3 commits into
Conversation
|
Warning Review limit reached
Next review available in: 61 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review Review exact current head |
Rate Limit Exceeded
|
Purpose
Harden the read-only private-vulnerability-reporting evidence adapter so JSON-looking bytes cannot become operational setting evidence unless GitHub's response identifies itself with an exact JSON media-type token.
Exact identities
4573a6f7eaf904e19a6e3198c8cabcfd4be40c40e8266f38eebbe1761ed389a090c4745172e2cd1bd4020e3c7b1490d3108965debc0099f620ff82d8fix/private-vulnerability-json-media-typeGREEN implementation
readBoundedJson()now parses only the media-type token before parameters and accepts exactapplication/jsonorapplication/vnd.github+json, case-insensitively. Missing or misleading media types fail closed before declared-length processing or response-body access. Existing 16 KiB streaming bounds, fatal UTF-8 decoding, exact HTTP 200 requirement, redirect refusal, credential omission, boolean-setting evaluation, and read-only evidence semantics remain unchanged.The focused tests prove:
text/plain; profile=application/jsonis rejected before body access;Restack and verification boundary
The branch was merged with protected
mainafter #272, #266, and #275. The current merge tree overlays onlyscripts/private-vulnerability-reporting-audit.mjsandtest/private-vulnerability-reporting-adapter.test.tson current protected-main bytes.Historical predecessor results do not transfer. Application
ci,reviewer-ci, protected-base-eligibleSecurity Scan, and fresh review must complete successfully on unchanged current headd4020e3c7b1490d3108965debc0099f620ff82d8before merge. Pending, queued, skipped, absent, neutral, failed, cancelled, stale, predecessor, status-only, model-only, or rate-limited evidence is non-passing.This evidence-plane hardening does not prove that private vulnerability reporting is enabled, that reporter UI or notifications work, or that response staffing and end-to-end exercises are complete; issue #73 retains those operational requirements.
No repair/self-modifying workflow, protection weakening, secret/reviewer invention, audit waiver, release, or deployment claim.