ci: keep Node24 forcing without tripping scorecard checks

[seonghobae]

Summary

• move FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 from top-level workflow env blocks into per-job env blocks across GitHub Actions workflows
• add a regression test that forbids top-level workflow env blocks while still requiring the Node24 forcing flag on every job
• follow up on the post-merge develop regressions by switching the repository Pages site to build_type=workflow so the Actions-based Pages deploy path can execute

Verification

• uv run pytest -q
• PYTHONWARNINGS=error uv run pytest -q
• uv run pytest --cov=src/newsdom_api --cov-branch --cov-report=term-missing --cov-fail-under=100 -q
• uv run mkdocs build --strict
• python3 -c "import yaml, pathlib; [yaml.safe_load(path.read_text(encoding='utf-8')) for path in pathlib.Path('.github/workflows').glob('*.yml')]; print('workflow yaml ok')"
• gh workflow run .github/workflows/gh-pages.yml --ref develop
• gh run watch 24184778378

Summary by CodeRabbit

릴리스 노트

• Chores

  • GitHub Actions 워크플로우 구성을 최적화하여 유지보수성을 개선했습니다.

• Tests

  • 워크플로우 검증 테스트를 강화하여 전체 워크플로우에 걸친 환경 변수 설정의 일관성을 보장합니다.

[seonghobae]

@coderabbitai review

[seonghobae]

@coderabbitai approve

[seonghobae]

@coderabbitai resolve

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

📝 Walkthrough

개요

GitHub 워크플로우 파일들에서 FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 환경 변수의 범위를 워크플로우 레벨에서 개별 작업 레벨로 변경했습니다. 테스트 파일을 추가하여 각 작업이 이 변수를 정의하고 워크플로우에서 최상위 env 블록을 사용하지 않도록 검증합니다.

변경 사항

Cohort / File(s)	요약
워크플로우 환경 변수 범위 변경 .github/workflows/codeql.yml, .github/workflows/dependency-review.yml, .github/workflows/gh-pages.yml, .github/workflows/quality-gate.yml, .github/workflows/release.yml, .github/workflows/scorecards.yml, .github/workflows/tests.yml	FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 환경 변수를 워크플로우 최상위 env 블록에서 해당 작업의 env 블록으로 이동. 각 워크플로우의 범위가 전역에서 작업별 범위로 변경됨.
워크플로우 테스트 업데이트 tests/test_workflow_runtime_env.py	이전의 단일 테스트를 제거하고 새로운 헬퍼 함수 _workflow_paths()를 추가. 각 워크플로우 작업이 FORCE_JAVASCRIPT_ACTIONS_TO_NODE24를 정의하는지 확인하는 test_each_workflow_job_forces_javascript_actions_to_node24() 테스트와 워크플로우가 최상위 env: 블록을 사용하지 않는지 검증하는 test_workflows_do_not_use_top_level_env_blocks() 테스트 추가.

코드 검토 예상 소요 시간

🎯 2 (Simple) | ⏱️ ~10 분

시

🐰 워크플로우들이 정렬되고,
범위는 좁혀지고,
각 작업이 제대로 숨을 쉬네요.
테스트는 확인하고,
최상위는 비웠으니—
모두 한 곳에서 일하는 행복! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	제목은 주요 변경 사항을 명확하게 요약하고 있습니다. 모든 워크플로우에서 최상위 env 블록을 제거하고 작업별 env 블록으로 이동하는 변경 사항을 정확하게 반영합니다.
Description check	✅ Passed	설명은 템플릿의 필수 섹션을 모두 포함합니다: Summary 섹션에서 변경 사항을 설명하고, Git Flow 안내를 준수하며, Verification에서 테스트 명령어들을 제공합니다.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/workflow-default-branch-regressions

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

tests/test_workflow_runtime_env.py (1)

22-26: Top-level env 검증은 문자열 스캔보다 YAML 파싱 기반 검증이 더 안전합니다.

Line 22-26은 포맷(공백/주석) 변화에 민감할 수 있어, 파싱된 최상위 키 검사로 바꾸는 편이 견고합니다.

제안 diff

 def test_workflows_do_not_use_top_level_env_blocks():
     for workflow_path in _workflow_paths():
-        text = workflow_path.read_text(encoding="utf-8")
-        assert not text.startswith("env:\n")
-        assert "\nenv:\n" not in text.split("jobs:", 1)[0], workflow_path
+        data = yaml.safe_load(workflow_path.read_text(encoding="utf-8")) or {}
+        assert "env" not in data, workflow_path

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/test_workflow_runtime_env.py` around lines 22 - 26, The test
test_workflows_do_not_use_top_level_env_blocks should stop relying on string
searches and instead parse each workflow file as YAML and assert the parsed
top-level mapping does not contain the "env" key; update the test to use a YAML
loader (e.g., yaml.safe_load) to load text into a dict and replace the current
startswith/split checks with an assertion like "'env' not in data" (keeping
workflow_path in the assertion message) so formatting/whitespace/comments don't
cause false positives.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@tests/test_workflow_runtime_env.py`:
- Around line 22-26: The test test_workflows_do_not_use_top_level_env_blocks
should stop relying on string searches and instead parse each workflow file as
YAML and assert the parsed top-level mapping does not contain the "env" key;
update the test to use a YAML loader (e.g., yaml.safe_load) to load text into a
dict and replace the current startswith/split checks with an assertion like
"'env' not in data" (keeping workflow_path in the assertion message) so
formatting/whitespace/comments don't cause false positives.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 01a6ef21-9811-46a4-889c-3729b8ba7353

📥 Commits

Reviewing files that changed from the base of the PR and between 2c92e6a and 7e62b9b.

📒 Files selected for processing (8)

• .github/workflows/codeql.yml
• .github/workflows/dependency-review.yml
• .github/workflows/gh-pages.yml
• .github/workflows/quality-gate.yml
• .github/workflows/release.yml
• .github/workflows/scorecards.yml
• .github/workflows/tests.yml
• tests/test_workflow_runtime_env.py

[coderabbitai]

✅ Actions performed

Comments resolved and changes approved.

[coderabbitai]

✅ Actions performed

Comments resolved and changes approved.