Skip to content

Strix quick gate에 text_safety 컨텍스트 추가 - #208

Merged
seonghobae merged 1 commit into
masterfrom
fix/strix-text-safety-context-20260521
May 21, 2026
Merged

Strix quick gate에 text_safety 컨텍스트 추가#208
seonghobae merged 1 commit into
masterfrom
fix/strix-text-safety-context-20260521

Conversation

@seonghobae

@seonghobae seonghobae commented May 21, 2026

Copy link
Copy Markdown
Contributor

목적

PR #202의 Strix XSS false-positive를 해소하기 위해 trusted-base Strix quick gate가 email_parser.py 스캔 시 sanitizer 컨텍스트인 text_safety.py를 함께 보도록 합니다.

주요 변경 사항

  • scripts/ci/strix_quick_gate.sh backend Python 컨텍스트에 backend/services/text_safety.py 추가
  • scripts/ci/test_strix_quick_gate.sh 회귀 테스트 확장
  • scanner suppression 또는 bypass 없이 분석 컨텍스트만 보강

변경 범위 / 영향도

검증

  • bash -n scripts/ci/strix_quick_gate.sh && bash -n scripts/ci/test_strix_quick_gate.sh && timeout 900 bash scripts/ci/test_strix_quick_gate.sh
  • 결과: test_strix_quick_gate: PASS

Summary by CodeRabbit

  • Chores

    • Updated CI scanning and testing infrastructure to improve code validation coverage.
  • Tests

    • Enhanced test harness to validate scanning behavior with updated coverage scope and batching configuration.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 21, 2026

Copy link
Copy Markdown
Contributor

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key(s) in object: 'version'
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a0513f0d-22a3-45ea-a5e3-3d0dc91d06ef

📥 Commits

Reviewing files that changed from the base of the PR and between 1138cb5 and ee0a81f.

📒 Files selected for processing (2)
  • scripts/ci/strix_quick_gate.sh
  • scripts/ci/test_strix_quick_gate.sh

📝 Walkthrough

Walkthrough

This PR extends the Strix quick-gate CI scanning infrastructure to include backend/services/text_safety.py as part of the backend Python context files. The main script change adds one file to the context list, and the corresponding test updates validate that this file is correctly included in the PR-head scan scope with required markers when email parser context is present.

Changes

Text Safety Backend Context Scanning

Layer / File(s) Summary
Backend context scope expansion
scripts/ci/strix_quick_gate.sh
Add backend/services/text_safety.py to the backend context file list emitted for bounded PR-head Strix scans.
Test validation and fixtures
scripts/ci/test_strix_quick_gate.sh
Extend test workspace setup to create email_parser.py and text_safety.py with marker content; add conditional validation in fake Strix to require both files when email_parser exists; adjust batching to one file per batch; update assertions to verify the scan path runs and match new call counts.

Possibly related PRs

  • Seongho-Bae/naruon#207: Both PRs update the same Strix quick gate CI workflow to extend PR-head backend context file coverage via corresponding mocked scope and marker assertions.
  • Seongho-Bae/naruon#201: Both PRs extend strix_quick_gate.sh and test_strix_quick_gate.sh to broaden which "changed backend context" files are included from the PR head with corresponding marker validation.
  • Seongho-Bae/naruon#206: The retrieved PR overlaps on extending backend context file coverage in the Strix scan scope and validating context markers via the CI test harness.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A rabbit hops through CI gates so swift,
Adding text safety—what a gift! 🐰
One file added, tests aligned with care,
Scanning backends with markers fair.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is in Korean and translates to 'Add text_safety context to Strix quick gate', which directly aligns with the PR's main purpose of adding backend/services/text_safety.py to the Strix quick gate configuration.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/strix-text-safety-context-20260521

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown
Contributor

PR governance metadata gate is not ready for ee0a81fa862036d3cfea3d741974081c7d1c49d8:

  • 2 required check(s) are not successful on ee0a81f.\n- Missing current-head CodeRabbit/coderabbitai evidence for ee0a81f.\n

@github-actions

Copy link
Copy Markdown
Contributor

PR governance metadata gate is not ready for ee0a81fa862036d3cfea3d741974081c7d1c49d8:

  • 1 required check(s) are not successful on ee0a81f.\n- Missing current-head CodeRabbit/coderabbitai evidence for ee0a81f.\n

1 similar comment
@github-actions

Copy link
Copy Markdown
Contributor

PR governance metadata gate is not ready for ee0a81fa862036d3cfea3d741974081c7d1c49d8:

  • 1 required check(s) are not successful on ee0a81f.\n- Missing current-head CodeRabbit/coderabbitai evidence for ee0a81f.\n

@github-actions

Copy link
Copy Markdown
Contributor

PR governance metadata gate is not ready for ee0a81fa862036d3cfea3d741974081c7d1c49d8:

  • Missing current-head CodeRabbit/coderabbitai evidence for ee0a81f.\n

@seonghobae

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented May 21, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@seonghobae
seonghobae merged commit f89f1f7 into master May 21, 2026
16 checks passed
@seonghobae
seonghobae deleted the fix/strix-text-safety-context-20260521 branch May 21, 2026 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant