Strix quick gate에 text_safety 컨텍스트 추가 - #208
Conversation
|
Note
|
| Layer / File(s) | Summary |
|---|---|
Backend context scope expansion scripts/ci/strix_quick_gate.sh |
Add backend/services/text_safety.py to the backend context file list emitted for bounded PR-head Strix scans. |
Test validation and fixtures scripts/ci/test_strix_quick_gate.sh |
Extend test workspace setup to create email_parser.py and text_safety.py with marker content; add conditional validation in fake Strix to require both files when email_parser exists; adjust batching to one file per batch; update assertions to verify the scan path runs and match new call counts. |
Possibly related PRs
- Seongho-Bae/naruon#207: Both PRs update the same Strix quick gate CI workflow to extend PR-head backend context file coverage via corresponding mocked scope and marker assertions.
- Seongho-Bae/naruon#201: Both PRs extend
strix_quick_gate.shandtest_strix_quick_gate.shto broaden which "changed backend context" files are included from the PR head with corresponding marker validation. - Seongho-Bae/naruon#206: The retrieved PR overlaps on extending backend context file coverage in the Strix scan scope and validating context markers via the CI test harness.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
A rabbit hops through CI gates so swift,
Adding text safety—what a gift! 🐰
One file added, tests aligned with care,
Scanning backends with markers fair.
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage | Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title is in Korean and translates to 'Add text_safety context to Strix quick gate', which directly aligns with the PR's main purpose of adding backend/services/text_safety.py to the Strix quick gate configuration. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
📝 Generate docstrings
- Create stacked PR
- Commit on current branch
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Commit unit tests in branch
fix/strix-text-safety-context-20260521
Comment @coderabbitai help to get the list of available commands and usage tips.
1 similar comment
|
PR governance metadata gate is not ready for
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
목적
PR #202의 Strix XSS false-positive를 해소하기 위해 trusted-base Strix quick gate가
email_parser.py스캔 시 sanitizer 컨텍스트인text_safety.py를 함께 보도록 합니다.주요 변경 사항
scripts/ci/strix_quick_gate.shbackend Python 컨텍스트에backend/services/text_safety.py추가scripts/ci/test_strix_quick_gate.sh회귀 테스트 확장변경 범위 / 영향도
검증
bash -n scripts/ci/strix_quick_gate.sh && bash -n scripts/ci/test_strix_quick_gate.sh && timeout 900 bash scripts/ci/test_strix_quick_gate.shtest_strix_quick_gate: PASSSummary by CodeRabbit
Chores
Tests