Strix PR 스코프에서 Next.js 동적 라우트 경로 허용 - #200
Conversation
|
Note
|
| Layer / File(s) | Summary |
|---|---|
Normalize changed-file paths to allow brackets scripts/ci/strix_quick_gate.sh |
normalize_changed_file_path() expands its re.fullmatch() whitelist to include [ and ], allowing parameterized Next.js route paths. |
Make target path resolution strict scripts/ci/strix_quick_gate.sh |
resolve_scan_target_path() and resolve_internal_pr_scope_target_path() call Path.resolve(strict=True), so unresolved targets now cause resolution errors. |
Test assertions for strict resolution and bracket routes scripts/ci/test_strix_quick_gate.sh |
Adds an assertion that the gate script does not use target_path.resolve(strict=False) and a run_pull_request_target_head_scope_case for frontend/src/app/labels/[slug]/page.tsx validating head-only scanning. |
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~20 minutes
Poem
I rabbit-hop through bracketed lanes,
Where[slug]and friends elude old chains,
Resolve stands strict and paths behave—
Tests guard the gate, the scanner's brave. 🐇
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage | Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title 'Strix PR 스코프에서 Next.js 동적 라우트 경로 허용' is in Korean and directly describes the main change: allowing Next.js dynamic route paths in Strix PR scope validation. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
📝 Generate docstrings
- Create stacked PR
- Commit on current branch
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Commit unit tests in branch
fix/strix-nextjs-bracket-paths-20260514
Comment @coderabbitai help to get the list of available commands and usage tips.
1 similar comment
Greptile Summary경로 정규화 regex에서 리터럴
Confidence Score: 5/5변경 범위가 작고 기존 방어 로직(tree_path 일치 검사, fail-closed 동작)이 그대로 유지되어 안전하게 머지 가능합니다. regex 확장은 별도로 주의가 필요한 파일 없음. Important Files Changed
Reviews (2): Last reviewed commit: "fix: harden Strix scan target resolution" | Re-trigger Greptile |
1 similar comment
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
PR governance metadata gate is not ready for
|
|
Closing this PR as superseded by current Current evidence:
No unique implementation needs to be preserved from this PR. |
No linked issue.
목적
pull_request_target기반 Strix 스코프 검증이frontend/src/app/labels/[slug]/page.tsx같은 Next.js 동적 라우트 경로를 잘못 거부해 필수 Strix 스캔이 시작 전 실패하는 문제를 수정합니다.주요 변경
[/]를 허용합니다.:pathspec magic,*, traversal, absolute path, backslash, 앞뒤 공백은 계속 차단합니다.pull-request-target-nextjs-bracket-route-uses-head-blob회귀 케이스를 추가했습니다.검증
bash scripts/ci/test_strix_quick_gate.sh: PASSgit diff --check: PASSpython3 "$HOME/.config/opencode/scripts/lint_by_filetype.py" --json: okSummary by CodeRabbit
Chores
Tests