Skip to content

fix: accept DiskSage readiness schema v4 #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seonghobae wants to merge 1 commit into from
Closed

fix: accept DiskSage readiness schema v4 #1233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/scripts/disksage_copy_readiness_handoff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ def _decode_protocol(result: VerifierResult) -> dict[str, object]:
and payload.get("ok") is True
and payload.get("schema_kind") == "disksage.naruon.cloud-copy-readiness"
and type(payload.get("schema_version")) is int
and payload.get("schema_version") == 3
and payload.get("schema_version") == 4
and payload.get("provider") in PROVIDERS
and payload.get("readiness_state") in READINESS_STATES
and type(payload.get("candidate_count")) is int
Expand Down
3 changes: 2 additions & 1 deletion backend/tests/test_disksage_copy_readiness_handoff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ def _success_payload() -> dict[str, object]:
return {
"ok": True,
"schema_kind": "disksage.naruon.cloud-copy-readiness",
"schema_version": 3,
"schema_version": 4,
"provider": "icloud",
"readiness_state": "blocked",
"candidate_count": 19,
Expand Down Expand Up @@ -711,6 +711,7 @@ def wrapped_popen(*args, **kwargs):
("payload", "exit_code"),
[
({**_success_payload(), "private_path": "/private/source"}, 0),
({**_success_payload(), "schema_version": 3}, 0),
({"ok": False, "error_code": "invalid"}, 0),
(_success_payload(), 65),
({"ok": False, "error_code": "invalid/path"}, 65),
Expand Down
Loading