fix: accept DiskSage readiness schema v4 - #1233
Conversation
|
Warning Review limit reached
Next review available in: 12 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
|
PR governance metadata gate update for PR governance metadata gate is ready; all current-head requirements passed. |
|
@coderabbitai review Please review the exact head |
|
✅ Action performedReview finished.
|
20fdf41 to
70d819f
Compare
|
@coderabbitai review Please review exact head |
|
✅ Action performedReview finished.
|
70d819f to
cb9ad9d
Compare
|
@coderabbitai review Please review exact current head |
🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
target='cb9ad9d61ecfd497597046f4c8cae6a83be74564'
printf '%s\n' '== Requested commit =='
git show -s --format='commit=%H%nparents=%P%nsubject=%s' "$target"
printf '%s\n' '== develop reference =='
git rev-parse develop
base="$(git merge-base develop "$target")"
printf 'merge_base=%s\n' "$base"
printf '%s\n' '== Commit range summary =='
git diff --stat "$base" "$target"
git diff --name-status "$base" "$target"
printf '%s\n' '== Exact changed diff =='
git diff --no-ext-diff --unified=80 "$base" "$target" -- \
scripts/disksage_copy_readiness_handoff.py \
tests/test_disksage_copy_readiness_handoff.py
printf '%s\n' '== Python structure =='
ast-grep outline scripts/disksage_copy_readiness_handoff.py --items all --type function,class
ast-grep outline tests/test_disksage_copy_readiness_handoff.py --items all --type function,classLength of output: 1880 🏁 Script executed: #!/bin/bash
set -euo pipefail
base='e91a0c2676a5dc1788cd24ab2a02e683d7e00768'
target='cb9ad9d61ecfd497597046f4c8cae6a83be74564'
printf '%s\n' '== Exact changed diff =='
git diff --no-ext-diff --unified=100 "$base" "$target" -- \
backend/scripts/disksage_copy_readiness_handoff.py \
backend/tests/test_disksage_copy_readiness_handoff.py
printf '%s\n' '== Implementation structure =='
ast-grep outline backend/scripts/disksage_copy_readiness_handoff.py --items all --type function,class
printf '%s\n' '== Test structure =='
ast-grep outline backend/tests/test_disksage_copy_readiness_handoff.py --items all --type function,class
printf '%s\n' '== Schema references and safety-check references =='
rg -n -C 4 \
-e 'schema' \
-e 'duplicate' \
-e 'allowlist|allow_list' \
-e 'redact|redacted' \
-e 'timeout|bounded' \
backend/scripts/disksage_copy_readiness_handoff.py \
backend/tests/test_disksage_copy_readiness_handoff.py
printf '%s\n' '== Implementation source =='
cat -n backend/scripts/disksage_copy_readiness_handoff.py
printf '%s\n' '== Test source =='
cat -n backend/tests/test_disksage_copy_readiness_handoff.pyLength of output: 110062
No findings. The commit changes only the intended two files. The regression test now rejects a return-code-0 schema-v3 success payload. It verifies exit code I completed a static review. I did not run tests or linters because this environment prohibits repository execution. ✅ Action performedReview finished.
|
|
Superseded by #1239, which carries the focused two-file readiness compatibility patch on the current |
|
Superseded by focused current-develop replacement #1239, which accepts exactly DiskSage readiness schema versions 3 and 4 and carries its own exact-head checks and review evidence. Keep this duplicate closed so one compatibility patch proceeds. |
1 participant
Summary
develophead.Why
DiskSage exports
disksage.naruon.cloud-copy-readinessschema v4. Naruon still required v3, so every current readiness handoff failed closed before it could be consumed.Validation
uv run pytest -q tests/test_disksage_copy_readiness_handoff.py— 43 passed on the implementation source;uv run ruff check scripts/disksage_copy_readiness_handoff.py tests/test_disksage_copy_readiness_handoff.py;uv run ruff format --check scripts/disksage_copy_readiness_handoff.py tests/test_disksage_copy_readiness_handoff.py;git diff --check;No provider write, cloud copy, source eviction, or user-file mutation is performed.