test(cdc): replay connector identity RED on current develop

[seonghobae]

Rebuilds the still-present connector-registry authority defect from exact protected develop@b53a21eaa9a45141498af04427656afc1bd8be33 without rewriting stale Draft #201.

RED state

• exact head: 7835c2e69be81ce1e44d41451c0faadd5b2dda30
• exact parent/live base at construction: b53a21eaa9a45141498af04427656afc1bd8be33
• changed path: only cdc-service/src/test/java/com/xtrmetl/cdc/spi/CdcRegistryIdentityTest.java
• protected source still uses unconditional Map.put in both source and target registries

The test reaches the real registry production boundary and requires null, blank and duplicate connector identities to fail closed rather than overwrite registration authority. Valid hosted RED is the six focused assertions failing because production accepts those invalid registrations after normal compilation/test startup; setup, dependency, fixture or runner failure does not qualify.

Only after current-base RED is observed will the narrow putIfAbsent/validation/Javadoc GREEN be replayed. No checks, reviews or approvals from #201 transfer. Keep Draft through fresh current-head proof. #201 is superseded only after unique-work preservation is proven on this replacement.

[coderabbitai]

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 3 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0b1f47d5-4ac0-429d-be6f-04b842ed389a

📥 Commits

Reviewing files that changed from the base of the PR and between 502d1e2 and 34f85a7.

📒 Files selected for processing (3)

• cdc-service/src/main/java/com/xtrmetl/cdc/spi/CdcSourceRegistry.java
• cdc-service/src/main/java/com/xtrmetl/cdc/spi/CdcTargetRegistry.java
• cdc-service/src/test/java/com/xtrmetl/cdc/spi/CdcRegistryIdentityTest.java

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[seonghobae]

@coderabbitai review

Please review exact source head 34f85a7151471cd1ae018ada0b409d2bd7bcfd6c against current develop@502d1e2136f18b7dea3baa792559128dc87fec39. The branch now contains the bounded connector-identity GREEN implementation plus focused fail-closed/null/blank/duplicate and collection-authority tests; stale #201 evidence does not transfer.

[coderabbitai]

@seonghobae I will review the current connector-identity GREEN changes against the specified develop base. I will not use evidence from stale PR #201.

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[seonghobae]

Superseded by current-base replacement #315 after fresh content comparison. Exact legacy head 34f85a7151471cd1ae018ada0b409d2bd7bcfd6c and replacement head d86af1013f09a8a063bba34341b3a74800b00ad4 exercise the same production-boundary contract: reject null, blank and duplicate source/target connector identities before mutation and prevent callers from deleting registration authority through all(). #315 preserves those assertions and strengthens the returned collection contract to an immutable snapshot (List.copyOf) rather than an unmodifiable live view. Fresh exact-head CI on #315 is successful for CI, Dependency Review, SBOM, Semgrep and Security Scan. No review/check evidence transfers from this PR; this closure only removes superseded duplicate work.