Skip to content

feat(identity): add tenant-scoped data-rights status lookup - #143

Closed
seonghobae wants to merge 2 commits into
mainfrom
feat/data-rights-request-status-v2
Closed

feat(identity): add tenant-scoped data-rights status lookup#143
seonghobae wants to merge 2 commits into
mainfrom
feat/data-rights-request-status-v2

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Intent

Advance #55 with the tenant-scoped persistence primitive needed by the authenticated data-rights status resource, rebuilt from exact protected main after the predecessor #141 became stale behind the protected-main Today slice.

TDD evidence

The predecessor RED head failed because PostgresDataRightsRequestLedger.getRequest did not exist. This clean successor starts from protected main f4cae6d83eadb00019d2962a650c55c59a3349ae and implements the minimal persistence lookup on top of that integrated baseline.

Implemented

  • validated GetDataRightsRequest input with opaque UUIDv4 request/workspace/requesting-user IDs
  • one fixed parameterized PostgreSQL lookup scoped simultaneously by request ID, workspace ID and requesting user ID
  • inaccessible/cross-tenant lookup returns undefined rather than revealing request existence
  • malformed lookup identifiers fail before SQL
  • duplicate persisted rows fail closed as persistence corruption
  • existing immutable request/terminal-receipt semantics remain unchanged

Exact-head evidence

Current contributor head 57fe98d7a18f734dbe358c5dbeb91459034f5a3b is based on live main f4cae6d83eadb00019d2962a650c55c59a3349ae. On that unchanged head, CI, AppGuardrail, SAST Semgrep, Security Scan and Commercial Readiness completed successfully; CodeRabbit commit status is successful and there are no unresolved review threads. The PR can therefore leave Draft, while merge still requires a final unchanged-head/live-base recheck and any review/policy gate triggered by the Ready transition.

Scope

This is the persistence boundary needed for the next authenticated status-resource slice. It does not yet expose a public HTTP status endpoint or complete #55 export/erasure orchestration.

Refs #55, #141 and #21.

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 17 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f87ed87b-16de-40f2-920b-8f52e92377a8

📥 Commits

Reviewing files that changed from the base of the PR and between f4cae6d and 57fe98d.

📒 Files selected for processing (2)
  • apps/identity-service/src/data-rights-request-ledger.test.ts
  • apps/identity-service/src/data-rights-request-ledger.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as ready for review August 9, 2026 23:29

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link
Copy Markdown
Contributor Author

Superseded by #144 after protected main advanced to eb4ff993a6c8f948377d68d186130c149f370154. The exact two-file implementation/test tree was copied onto a one-commit clean successor whose parent is current main, so #143 no longer adds unique current evidence and would only duplicate checks on stale ancestry.

@seonghobae seonghobae closed this Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant