forked from yencarnacion/html4tree
-
Notifications
You must be signed in to change notification settings - Fork 0
π¨ Palette: [UX improvement] λ€κ΅μ΄ νμΌλͺ λ° μλ°©ν₯(BiDi) ν μ€νΈ μ§μμ μν λ λλ§ κ°μ #507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
seonghobae
wants to merge
10
commits into
master
Choose a base branch
from
palette-bidi-text-support-6806216931577145038
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
2cdf489
feat(ui): add bidi text support using dir="auto"
seonghobae 89d143f
feat(ui): add bidi text support using dir="auto"
seonghobae ebd251d
test(ui): cover bidi filename direction
seonghobae ef867b2
feat(ui): add bidi text support using dir="auto"
seonghobae 13b0113
feat(ui): add bidi text support using dir="auto"
seonghobae 4dba6b8
feat(ui): add bidi text support using dir="auto"
seonghobae 574b126
feat(ui): add bidi text support using dir="auto"
seonghobae 759eb03
feat(ui): add bidi text support using dir="auto"
seonghobae 1b93de0
feat(ui): add bidi text support using dir="auto"
seonghobae b179fe4
feat(ui): add bidi text support using dir="auto"
seonghobae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -426,7 +426,7 @@ fun process_dir(curr_dir: File, excludeSet: Set<String>? = null, dirFiles: Array | |
| </head> | ||
| <body> | ||
| <main> | ||
| <h1>${directoryName.escapeHtml()}</h1> | ||
| <h1 dir="auto">${directoryName.escapeHtml()}</h1> | ||
| <nav aria-label="λλ ν 리 λͺ©λ‘"> | ||
| <ul role="list"> | ||
| <li><a class="dir-link" href="./.." title="μμ λλ ν λ¦¬λ‘ μ΄λ"><span class="icon" aria-hidden="true">↰</span> <span aria-hidden="true">..</span> <span class="visually-hidden">μμ λλ ν λ¦¬λ‘ μ΄λ</span></a></li> | ||
|
|
@@ -460,7 +460,7 @@ fun process_dir(curr_dir: File, excludeSet: Set<String>? = null, dirFiles: Array | |
| val ariaLabel = "${fileName} ${if (isLinkedDirectory) { "λλ ν 리" } else { "νμΌ" }}".escapeHtml() | ||
| val typeLabel = if (isLinkedDirectory) { "λλ ν 리" } else { "νμΌ" } | ||
| val icon = if (isLinkedDirectory) { "📁" } else { "📄" } | ||
| l.append(""" <li><a class="dir-link" href="${encodedHref}" title="${ariaLabel}"><span class="icon" aria-hidden="true">${icon}</span> <span>${fileName.escapeHtml()}</span> <span class="visually-hidden">${typeLabel}</span></a></li>""") | ||
| l.append(""" <li><a class="dir-link" href="${encodedHref}" title="${ariaLabel}"><span class="icon" aria-hidden="true">${icon}</span> <span dir="auto">${fileName.escapeHtml()}</span> <span class="visually-hidden">${typeLabel}</span></a></li>""") | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| l.append('\n') | ||
| } | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.