Skip to content

🎨 Palette: [UX improvement] λ‹€κ΅­μ–΄ 파일λͺ… 및 μ–‘λ°©ν–₯(BiDi) ν…μŠ€νŠΈ 지원을 μœ„ν•œ λ Œλ”λ§ κ°œμ„  - #507

Open
seonghobae wants to merge 10 commits into
masterfrom
palette-bidi-text-support-6806216931577145038
Open

🎨 Palette: [UX improvement] λ‹€κ΅­μ–΄ 파일λͺ… 및 μ–‘λ°©ν–₯(BiDi) ν…μŠ€νŠΈ 지원을 μœ„ν•œ λ Œλ”λ§ κ°œμ„ #507
seonghobae wants to merge 10 commits into
masterfrom
palette-bidi-text-support-6806216931577145038

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

πŸ’‘ What: μƒμ„±λœ HTMLμ—μ„œ 디렉토리 이름(<h1>)κ³Ό 파일 이름(<span>)을 λ Œλ”λ§ν•˜λŠ” νƒœκ·Έμ— dir="auto" 속성을 μΆ”κ°€ν•˜μ—¬ λ‹€κ΅­μ–΄ μ–‘λ°©ν–₯(BiDi) ν…μŠ€νŠΈ 지원을 κ΅¬ν˜„ν–ˆμŠ΅λ‹ˆλ‹€.
🎯 Why: μ•„λžμ–΄(Arabic)λ‚˜ νžˆλΈŒλ¦¬μ–΄(Hebrew)와 같이 Right-to-Left (RTL)둜 μž‘μ„±λ˜λŠ” μ–Έμ–΄κ°€ κΈ°λ³Έ Left-to-Right (LTR) ν™˜κ²½μ—μ„œ λ Œλ”λ§λ  λ•Œ, ν…μŠ€νŠΈ λ°©ν–₯이 μ˜¬λ°”λ₯΄κ²Œ ν‘œμ‹œλ˜μ§€ μ•Šμ•„ κΈ€μžκ°€ κΉ¨μ§€κ±°λ‚˜ 가독성이 ν˜„μ €νžˆ μ €ν•˜λ˜λŠ” λ¬Έμ œκ°€ λ°œμƒν•˜κΈ° λ•Œλ¬Έμž…λ‹ˆλ‹€.
πŸ“Έ Before/After: RTL μ–Έμ–΄λ‘œ 된 파일λͺ…듀이 LTR λ°©ν–₯μ—μ„œ ν‘œμ‹œλ  λ•Œ λ ˆμ΄μ•„μ›ƒμ΄ μ–΄μƒ‰ν•˜κ²Œ κΉ¨μ§€λ˜ λ¬Έμ œκ°€ ν•΄κ²°λ˜μ–΄ μ›μ–΄λ―Όμ—κ²Œ 더 μžμ—°μŠ€λŸ½κ³  읽기 μ‰¬μš΄ λ ˆμ΄μ•„μ›ƒμœΌλ‘œ λ³€κ²½λ˜μ—ˆμŠ΅λ‹ˆλ‹€.
β™Ώ Accessibility: dir="auto"λ₯Ό μ‚¬μš©ν•˜μ—¬ λΈŒλΌμš°μ €κ°€ μ½˜ν…μΈ  자체λ₯Ό 기반으둜 λ°©ν–₯을 μΆ”λ‘ ν•˜κ²Œ λ§Œλ“€μ—ˆμœΌλ―€λ‘œ ν™”λ©΄ νŒλ…κΈ°λ‚˜ 기타 보쑰 기술이 RTL μ–Έμ–΄λ₯Ό 더 μ •ν™•ν•˜κ²Œ μ²˜λ¦¬ν•  수 μžˆλ„λ‘ λ•μŠ΅λ‹ˆλ‹€. ν…ŒμŠ€νŠΈ μ½”λ“œ(MainTest.kt) μ—…λ°μ΄νŠΈ 및 .jules/palette.md에 이와 κ΄€λ ¨λœ UX κ·œμΉ™μ„ μƒˆλ‘œ κΈ°λ‘ν–ˆμŠ΅λ‹ˆλ‹€.


PR created automatically by Jules for task 6806216931577145038 started by @seonghobae


Open in Devin Review

Summary by CodeRabbit

  • μƒˆλ‘œμš΄ κΈ°λŠ₯

    • μƒμ„±λ˜λŠ” 디렉터리 λͺ©λ‘ νŽ˜μ΄μ§€κ°€ μ΄λ¦„μ˜ μ–Έμ–΄λ₯Ό μžλ™μœΌλ‘œ 감지해 μ™Όμͺ½μ—μ„œ 였λ₯Έμͺ½ λ˜λŠ” 였λ₯Έμͺ½μ—μ„œ μ™Όμͺ½μœΌλ‘œ μ˜¬λ°”λ₯΄κ²Œ ν‘œμ‹œν•©λ‹ˆλ‹€.
  • ν…ŒμŠ€νŠΈ

    • 디렉터리 제λͺ©κ³Ό 파일 이름에 ν…μŠ€νŠΈ λ°©ν–₯ μžλ™ 감지가 μ μš©λ˜λŠ”μ§€ 검증을 μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
  • λ¬Έμ„œ

    • ν…μŠ€νŠΈ λ°©ν–₯ μžλ™ 감지 κΈ°λŠ₯에 λŒ€ν•œ λ³€κ²½ 사항을 κΈ°λ‘ν–ˆμŠ΅λ‹ˆλ‹€.

@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

This report is out of date. Scroll down for Devin Review's latest report on this PR.

βœ… Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. πŸŽ‰

ℹ️ Recent review info
βš™οΈ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f5e4363a-505d-48b1-a456-3caa300d2a31

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 89d143f and ebd251d.

πŸ“’ Files selected for processing (1)
  • src/test/kotlin/html4tree/BidiDirectionTest.kt

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


πŸ“ Walkthrough

Walkthrough

process_dirκ°€ μƒμ„±ν•˜λŠ” 디렉토리 제λͺ©κ³Ό 파일λͺ… μš”μ†Œμ— dir="auto"λ₯Ό μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€. κ΄€λ ¨ ν…ŒμŠ€νŠΈμ™€ λ³€κ²½ 기둝도 κ°±μ‹ ν–ˆμŠ΅λ‹ˆλ‹€.

Changes

HTML ν…μŠ€νŠΈ λ°©ν–₯ μžλ™ 감지

Layer / File(s) Summary
HTML λ Œλ”λ§ 및 검증
src/main/kotlin/html4tree/main.kt, src/test/kotlin/html4tree/MainTest.kt, src/test/kotlin/html4tree/BidiDirectionTest.kt, .jules/palette.md
디렉토리 제λͺ©κ³Ό 파일λͺ…에 dir="auto"λ₯Ό μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€. ν…ŒμŠ€νŠΈλŠ” 제λͺ©κ³Ό 파일λͺ… λ§ˆν¬μ—…μ„ κ²€μ¦ν•©λ‹ˆλ‹€. λ³€κ²½ 기둝에 ν•΄λ‹Ή λ‚΄μš©μ„ μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: βšͺ Minimal Β· up to ebd25

This localized change adds automatic text-direction handling for generated directory and file labels and includes regression coverage. No actionable merge-blocking risk remains after normal checks and review.

Possibly related PRs

  • ContextualWisdomLab/html4tree#300: process_dir의 생성 <h1> μš”μ†Œμ™€ κ΄€λ ¨ ν…ŒμŠ€νŠΈλ₯Ό μˆ˜μ •ν•œ λ³€κ²½μž…λ‹ˆλ‹€.
  • ContextualWisdomLab/html4tree#447: process_dir와 κ΄€λ ¨ ν…ŒμŠ€νŠΈμ— dir="auto"λ₯Ό μΆ”κ°€ν•œ λ³€κ²½μž…λ‹ˆλ‹€.
  • ContextualWisdomLab/html4tree#496: 디렉토리 제λͺ©κ³Ό 파일λͺ… μš”μ†Œμ˜ dir="auto"λ₯Ό κ²€μ¦ν•œ λ³€κ²½μž…λ‹ˆλ‹€.
πŸš₯ Pre-merge checks | βœ… 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 3 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
βœ… Passed checks (4 passed)
Check name Status Explanation
Description Check βœ… Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check βœ… Passed 제λͺ©μ€ λ‹€κ΅­μ–΄ 파일λͺ…κ³Ό μ–‘λ°©ν–₯ ν…μŠ€νŠΈ λ Œλ”λ§ κ°œμ„ μ„ λͺ…ν™•νžˆ μ„€λͺ…ν•˜λ©°, λ³€κ²½ λ‚΄μš©μ˜ μ£Όμš” λͺ©μ κ³Ό μΌμΉ˜ν•©λ‹ˆλ‹€.
Linked Issues check βœ… Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check βœ… Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches πŸ’‘ 1
πŸ“ Generate docstrings πŸ’‘
  • Create stacked PR
  • Commit on current branch
πŸ§ͺ Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette-bidi-text-support-6806216931577145038

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]

This comment was marked as resolved.

@opencode-agent opencode-agent Bot added priority: medium Normal-priority or P2 work status: needs-review Open pull request requiring current-head review or checks type: feature New or expanded product capability labels Aug 22, 2026

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

Devin Review

val typeLabel = if (isLinkedDirectory) { "디렉토리" } else { "파일" }
val icon = if (isLinkedDirectory) { "&#128193;" } else { "&#128196;" }
l.append(""" <li><a class="dir-link" href="${encodedHref}" title="${ariaLabel}"><span class="icon" aria-hidden="true">${icon}</span> <span>${fileName.escapeHtml()}</span> <span class="visually-hidden">${typeLabel}</span></a></li>""")
l.append(""" <li><a class="dir-link" href="${encodedHref}" title="${ariaLabel}"><span class="icon" aria-hidden="true">${icon}</span> <span dir="auto">${fileName.escapeHtml()}</span> <span class="visually-hidden">${typeLabel}</span></a></li>""")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ” Filename direction lacks regression coverage

The final test suite checks dir="auto" on headings only. A later filename-template regression can pass without detecting broken BiDi rendering.

Devin Review

Was this helpful? React with πŸ‘ or πŸ‘Ž to provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: medium Normal-priority or P2 work status: needs-review Open pull request requiring current-head review or checks type: feature New or expanded product capability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant