test(serving): prove plausible-value control rejections before core - #934
Merged
seonghobae merged 13 commits intoAug 17, 2026
Merged
Conversation
Add pre-core regressions for bool/np.bool_, floats, n_draws domain bounds, __index__ providers, and valid-request core discovery so the #914 contract is evidenced the same way as DETECT/G-theory siblings. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
seonghobae
marked this pull request as ready for review
August 17, 2026 02:51
Contributor
Author
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
seonghobae
enabled auto-merge (squash)
August 17, 2026 02:51
seonghobae
approved these changes
Aug 17, 2026
seonghobae
deleted the
cursor/bc-31f2be25-44b8-4584-b3f3-3d0b6417fd0c-4db4
branch
August 17, 2026 05:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the #914 / #915 evidence gap. Keep #915 open only as the source hardening PR; land this head (or cherry-pick
55070a98onto #915) before merge.Why this exists
#915 already validates and normalizes
n_draws,seed, anddevicebefore_core_module()and uses identity-only NumPy integer admission. The public suite did not yet prove the cases #914 and the doctoring note claim:bool/np.bool_, non-integer floats,n_drawsdomain0andMAX_DRAWS + 1,__index__providers, and valid-request core discovery exactly once at dispatch.What changed
tests/test_serving_plausible_control_safety.pywith those pre-core regressions, matching DETECT (fix(detect): validate inputs before native discovery #904) and G-theory sibling evidence.docs/doctoring/plausible_values_control_safety.md.Local evidence
PYTHONPATH=python python3 -m pytest tests/test_serving_plausible_control_safety.py— 21 passed.Do not do
b1ffa305without this evidence.score_respondents/bank_information/cat_next_itemdevice hardening into this slice. Those remain a follow-up after Harden plausible-values control marshalling before native dispatch #914 closes.Closes #914 once this head or the cherry-pick is the merge candidate.