fix(detect): validate inputs before native discovery - #904
Conversation
|
Warning Review limit reached
Next review available in: 57 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Scope
Fix #903 by keeping invalid DETECT/DIMTEST requests inside the Python validation/marshalling boundary until their public inputs are fully validated.
Test-first lineage
02bb29458754288696f395ca10c1d5b2db575920adds public regressions proving malformed DETECT response shapes and malformed DIMTEST partitions must fail without touching compiled-core discovery, plus valid-input/core-absent controls that require discovery exactly at the dispatch boundary.b5b7fe0fef2997ac098f3c3995a60217750ba5fdmoves_core_module()discovery after the existing response/cluster and response/AT-set validation paths.661afbbd68831d0cb22b391959ee445d2bf6fa97records bounded release evidence.f2534cf8ecc22e11bf22ad3ff9ed3d4834009805proves an out-of-domain non-binary DETECT response must also be rejected before native discovery.5a88c704a8614e43119c09262ced34b1bef77a3bcloses that public-domain gap by enforcing the documented exact 0/1 response contract before compiled-core discovery.Preserved boundary
RuntimeErrorwhen it is unavailable.Lifecycle discipline
This PR remains Draft while current exact-head CI/security/package/provenance evidence is still running. Protected base, exact source identity, reviews, threads, and required checks must be refetched before any Ready or integration action; predecessor-head evidence does not transfer.
Fixes #903.