Skip to content

fix(selection): redact hostile model-comparison input failures - #802

Merged
seonghobae merged 2 commits into
mainfrom
fix/model-comparison-redaction-green
Aug 12, 2026
Merged

fix(selection): redact hostile model-comparison input failures#802
seonghobae merged 2 commits into
mainfrom
fix/model-comparison-redaction-green

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Summary

  • Model-comparison parameter counts and casewise iterables redact hostile conversion/iteration callbacks into stable package-owned ValueErrors.
  • Preserves MemoryError.
  • Stacked on fitstats/docs fail-closed base for product CI.

Supersedes

Test plan

  • tests/test_model_comparison_input_error_boundary.py
  • docs + fitstats fail-closed smoke

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 42 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: ebd90542-3e5d-4eed-915e-ec3ae568709f

📥 Commits

Reviewing files that changed from the base of the PR and between b4f39da and 0283f40.

📒 Files selected for processing (3)
  • docs/changelog.d/784-model-comparison-input-error-boundary.md
  • python/fast_mlsirm/model_comparison.py
  • tests/test_model_comparison_input_error_boundary.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as draft August 12, 2026 07:22
@seonghobae
seonghobae changed the base branch from main to fix/fitstats-m2-infit-docs-green August 12, 2026 07:23
@seonghobae
seonghobae marked this pull request as ready for review August 12, 2026 08:14
Base automatically changed from fix/fitstats-m2-infit-docs-green to main August 12, 2026 08:14
@seonghobae
seonghobae force-pushed the fix/model-comparison-redaction-green branch from c1456c6 to 4f0c2e9 Compare August 12, 2026 10:03
@seonghobae
seonghobae enabled auto-merge (squash) August 12, 2026 11:03
@seonghobae
seonghobae merged commit 5231438 into main Aug 12, 2026
35 checks passed
@seonghobae
seonghobae deleted the fix/model-comparison-redaction-green branch August 12, 2026 11:13
seonghobae added a commit that referenced this pull request Aug 12, 2026
Fail closed on hostile iterable setup/iteration with package-owned
messages while preserving MemoryError. Rebuilt on current main after
#788/#789/#800/#802 landings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant