Skip to content

fix(fitstats): require Rust for public infit/outfit and ordinary M2 - #791

Closed
seonghobae wants to merge 4 commits into
mainfrom
fix/fitstats-infit-outfit-failclosed-green
Closed

fix(fitstats): require Rust for public infit/outfit and ordinary M2#791
seonghobae wants to merge 4 commits into
mainfrom
fix/fitstats-infit-outfit-failclosed-green

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Summary

Public infit_outfit() and ordinary public m2() no longer silently fall back to Python/NumPy residual/reference arithmetic when the compiled core is absent or incomplete. Matches the S-X² / person-fit fail-closed ownership from #771.

Also retargets remaining S-X² / person-fit / infit / M2 NumPy-fallback coverage suites to the fail-closed contract.

Supersedes closed #774/#776 drafts and #775 (issue #627).

Evidence

  • Local targeted ownership + cov suites: 43 passed
  • Native core smoke: m2 and infit_outfit execute on compiled core

Product gates

Merge when python (aggregate + 3.12/3.14), rust, package, fuzz are green.

Fail closed when the compiled core or infit_outfit_stat is missing, and
retarget former NumPy-fallback coverage to the fail-closed ownership
contract (issue #627).
Retarget S-X² and person-fit NumPy-fallback coverage tests to the
Rust-required ownership contract so product CI stays green with
public infit/outfit fail-closed ownership.
Require m2_stat for ordinary public m2(), refuse incomplete cores before
the private NumPy reference, and retarget coverage that still expected
silent fallback. Extends #627 ownership with infit/outfit (#776).
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 55 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 129c8027-0ff0-4fe5-93b5-b91a65f3c588

📥 Commits

Reviewing files that changed from the base of the PR and between c91ae21 and 2946ffe.

📒 Files selected for processing (7)
  • CHANGELOG.md
  • docs/changelog.d/775-fitstats-infit-outfit-failclosed.md
  • python/fast_mlsirm/fitstats.py
  • tests/test_cov_c_fitstats.py
  • tests/test_fitstats_infit_outfit_allocations.py
  • tests/test_fitstats_infit_outfit_rust_ownership_failclosed.py
  • tests/test_fitstats_m2_rust_ownership.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Closing as duplicate of #788, which carries the same public infit_outfit() / ordinary m2() fail-closed ownership on main plus documentation maturity vocabulary sync. Prefer the single canonical line to avoid competing product PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant