Skip to content

test(fitstats): align fallback suites with fail-closed ownership - #774

Closed
seonghobae wants to merge 1 commit into
mainfrom
fix/fitstats-fallback-tests-failclosed
Closed

test(fitstats): align fallback suites with fail-closed ownership#774
seonghobae wants to merge 1 commit into
mainfrom
fix/fitstats-fallback-tests-failclosed

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Summary

#771 made public S-X² and person-fit fail closed on incomplete Rust cores, but several coverage tests still expected the old NumPy fallback path. This retargets those regressions to the fail-closed contract so product CI stays green.

Evidence

  • Local targeted fitstats ownership + former fallback tests green

Product gates

Merge when python + rust + package + fuzz are green.

Superseded — 2026-08-12

Closed in favor of the cleaner current-base lines #776 and #778.

  • fix(fitstats): require Rust for public infit/outfit #776 carries the same tests/test_cov_c_fitstats.py S-X²/person-fit fail-closed correction and extends the actual production ownership boundary to infit_outfit() with dedicated ownership/allocation regressions.
  • test(judge): close accepted-type and ownership gaps #778 carries the focused S-X²/person-fit coverage correction while also repairing the stale ownership/documentation vocabulary on the same protected-main base.
  • The remaining unique tests/test_fitstats.py edit here is intentionally not transferred: protected main already proves an incomplete core fails closed while preserving a successful native extreme-probability execution/parity assertion. Removing that native assertion would reduce useful accepted coverage rather than preserve a required delta.
  • This PR's changelog fragment is therefore duplicate lineage, not an independent product change.

No unique valuable implementation delta remains in this branch. Checks/reviews from this predecessor head do not transfer to #776 or #778.

After #771, incomplete-core S-X² and person-fit paths raise RuntimeError.
Retarget the former NumPy-fallback regressions to the fail-closed contract
so CI matches production numerical ownership.
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 47 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 0041dddb-80c3-4fd7-a4f2-6bd84dcb530b

📥 Commits

Reviewing files that changed from the base of the PR and between c91ae21 and 621709e.

📒 Files selected for processing (4)
  • CHANGELOG.md
  • docs/changelog.d/773-fitstats-fallback-tests-failclosed.md
  • tests/test_cov_c_fitstats.py
  • tests/test_fitstats.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant