Skip to content

test(cat): preserve public selection input immutability - #745

Closed
seonghobae wants to merge 1 commit into
mainfrom
test/cat-input-immutability-main-20260811
Closed

test(cat): preserve public selection input immutability#745
seonghobae wants to merge 1 commit into
mainfrom
test/cat-input-immutability-main-20260811

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Why

PR #741 moved public CAT item information and final next-item selection into Rust/PyO3, but stale predecessor #735 carried a non-duplicative caller-array immutability regression that did not land with the production migration. Issue #629 explicitly requires immutable public marshalling.

What

Add current-main regression coverage proving item_information() and select_cat_item() do not mutate caller-provided theta, factor-map, or administered-item arrays while exercising the installed Rust-backed public path.

No numerical formula, selection policy, dependency, workflow, provider, documentation authority, version, or release behavior changes.

Acceptance

Require focused/full Python 3.12/3.14 plus applicable repository CI/Security/SAST review gates on one unchanged head. After protected integration this PR absorbs the remaining valuable verification delta from stale Draft #735, allowing #735 to close without losing evidence. Advances #629.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 287f06dd-dd1c-48ea-90f5-a8ed8944fa7c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Superseded by clean current-main Draft #749. Fresh exact evidence before replacement: #745 head 0cc214165d6753d90b8233c9b717acc0fe8a4d6b is three protected-main commits behind and its only changed path is tests/test_cat_selection_input_immutability.py. #749 was recreated from protected main cd9e55f7f1735e9d73e73c11f5790d3c8e2f2b55 and preserves that test file byte-for-byte on head 631aab89fb4b477231e37ad7f5a51c12d69154bd. No checks/reviews/approval from #745 transfer; #749 must earn fresh exact-head/live-base evidence.

@seonghobae seonghobae closed this Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant