perf(mmle): restore clean current-main EAP matrix-vector projection - #572
seonghobae wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
Operate only on exact current head First run the authoritative renderer directly on this branch: python scripts/render_changelog_fragments.py --update CHANGELOG.md
python scripts/render_changelog_fragments.py --check CHANGELOG.md
pytest -q tests/test_changelog_fragment_contract.py tests/test_mmle_fallback_eap_matmul.py
git diff --checkCommit only the deterministic rendered
Do not create a patch/journal/source-snapshot/branch-writer workflow, another PR, dependency/lockfile/version/API change, or force-push. Preserve Rust as the production backend and the one-line |
|
Final supersession reconciliation: original clean-current-main PR #568 is live again at exact head |
|
@opencode-agent address Operate only on exact current Draft head |
|
/oc Exact-head deterministic completion only. Before writing, assert |
Purpose
Restore the reviewed NumPy fallback EAP projection on a clean branch rooted directly at current protected
mainafter predecessor PR #568 was closed with its head reset tomainbefore the product change was integrated.Exact reconstruction boundary
This branch starts at protected
main29570236d86aa6eb819da246a0c44c310764f3c7and restores only the four previously reviewed scientific artifacts from predecessor exact headd0b29282cf7f20f1b474e314731f5a2c1373651a:python/fast_mlsirm/estimators/mmle.py: replace(posterior * nodes[None, :]).sum(axis=1)with the mathematically equivalentposterior @ nodes;tests/test_mmle_fallback_eap_matmul.py: independent one-iteration partially observed parity plus source allocation regression;docs/doctoring/mmle-fallback-eap-matmul.md: statistical/architectural boundary and APA 7 references;docs/changelog.d/mmle-fallback-eap-matmul.md: authoritative fragment.No stale predecessor
CHANGELOG.md, patch/journal/source-snapshot workflow, dependency, lockfile, version, public API, model identity, or branch-history artifact is carried forward. Current-mainmmle.pyhad the same blob as predecessor base before this one-line change, so no intervening accepted estimator edit is lost.Required completion
Keep Draft. Render the authoritative current fragment set into current-main
CHANGELOG.mdwithpython scripts/render_changelog_fragments.py --update CHANGELOG.mdand verify--check; the resulting PR diff must preserve every current-main Unreleased note and contain only the four artifacts above plus renderedCHANGELOG.md.Then run exact-current-head focused EAP parity, complete Python statement/branch/public-docstring gates, Rust/PyO3, package/release acceptance, explicit GPU no-skip, fuzz, Security Scan, SAST, compilation, provenance/supply-chain gates,
git diff --check, current-head automated review, zero actionable threads, and a qualifying independent non-author approval before Ready/merge. Rust remains the production psychometric backend; this makes no universal performance claim.Supersedes closed unmerged PR #568. No predecessor-head check or review evidence transfers.