Skip to content

perf(mmle): restore clean current-main EAP matrix-vector projection - #572

Closed
seonghobae wants to merge 1 commit into
mainfrom
perf/mmle-eap-matmul-clean-main
Closed

seonghobae wants to merge 1 commit into
mainfrom
perf/mmle-eap-matmul-clean-main

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Purpose

Restore the reviewed NumPy fallback EAP projection on a clean branch rooted directly at current protected main after predecessor PR #568 was closed with its head reset to main before the product change was integrated.

Exact reconstruction boundary

This branch starts at protected main 29570236d86aa6eb819da246a0c44c310764f3c7 and restores only the four previously reviewed scientific artifacts from predecessor exact head d0b29282cf7f20f1b474e314731f5a2c1373651a:

  • python/fast_mlsirm/estimators/mmle.py: replace (posterior * nodes[None, :]).sum(axis=1) with the mathematically equivalent posterior @ nodes;
  • tests/test_mmle_fallback_eap_matmul.py: independent one-iteration partially observed parity plus source allocation regression;
  • docs/doctoring/mmle-fallback-eap-matmul.md: statistical/architectural boundary and APA 7 references;
  • docs/changelog.d/mmle-fallback-eap-matmul.md: authoritative fragment.

No stale predecessor CHANGELOG.md, patch/journal/source-snapshot workflow, dependency, lockfile, version, public API, model identity, or branch-history artifact is carried forward. Current-main mmle.py had the same blob as predecessor base before this one-line change, so no intervening accepted estimator edit is lost.

Required completion

Keep Draft. Render the authoritative current fragment set into current-main CHANGELOG.md with python scripts/render_changelog_fragments.py --update CHANGELOG.md and verify --check; the resulting PR diff must preserve every current-main Unreleased note and contain only the four artifacts above plus rendered CHANGELOG.md.

Then run exact-current-head focused EAP parity, complete Python statement/branch/public-docstring gates, Rust/PyO3, package/release acceptance, explicit GPU no-skip, fuzz, Security Scan, SAST, compilation, provenance/supply-chain gates, git diff --check, current-head automated review, zero actionable threads, and a qualifying independent non-author approval before Ready/merge. Rust remains the production psychometric backend; this makes no universal performance claim.

Supersedes closed unmerged PR #568. No predecessor-head check or review evidence transfers.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 9efa197c-a0d0-4c5f-9373-31a25b38fe03

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

/oc @opencode-agent @jules

Operate only on exact current head 59e1a20e15ecb5e1387bb73251a6bd4677f1e39a of this clean current-main replacement. The branch is intentionally reconstructed from protected main 29570236d86aa6eb819da246a0c44c310764f3c7 and contains exactly four reviewed scientific artifacts; predecessor #568 was closed with its branch reset before integration, so none of its old checks/reviews transfer.

First run the authoritative renderer directly on this branch:

python scripts/render_changelog_fragments.py --update CHANGELOG.md
python scripts/render_changelog_fragments.py --check CHANGELOG.md
pytest -q tests/test_changelog_fragment_contract.py tests/test_mmle_fallback_eap_matmul.py
git diff --check

Commit only the deterministic rendered CHANGELOG.md. Before committing, verify the diff against current protected main contains exactly these five paths and no deletion/rewrite of unrelated live-main Unreleased notes:

  • CHANGELOG.md
  • docs/changelog.d/mmle-fallback-eap-matmul.md
  • docs/doctoring/mmle-fallback-eap-matmul.md
  • python/fast_mlsirm/estimators/mmle.py
  • tests/test_mmle_fallback_eap_matmul.py

Do not create a patch/journal/source-snapshot/branch-writer workflow, another PR, dependency/lockfile/version/API change, or force-push. Preserve Rust as the production backend and the one-line posterior @ nodes change. Then rerun complete exact-head Python statement/branch/public-docstring coverage, Rust/PyO3, package/release acceptance, explicit GPU no-skip, fuzz, Security Scan, SAST, compilation, provenance/supply-chain checks, and current-head review surfaces. Keep Draft; do not approve, merge, release, or weaken any gate.

@seonghobae seonghobae closed this Aug 7, 2026

seonghobae commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

Final supersession reconciliation: original clean-current-main PR #568 is live again at exact head e397f0d70d1469f1ab708d794544ca07ce235af2, targets the same protected-main base, and carries the same four product blobs as this temporary replacement. #568 now also has fresh exact-head Security/SAST success and CI running, while this branch has no unique content. #572 is therefore closed unmerged and must stay closed. Continue only on #568; no #572 checks, comments, or review evidence transfer.

@seonghobae seonghobae reopened this Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

@opencode-agent address

Operate only on exact current Draft head 59e1a20e15ecb5e1387bb73251a6bd4677f1e39a. Complete the declared deterministic repository step now: run python scripts/render_changelog_fragments.py --update CHANGELOG.md from this branch, verify python scripts/render_changelog_fragments.py --check CHANGELOG.md, and commit only the resulting managed CHANGELOG.md update. Preserve every protected-main Unreleased note, especially merged #570's bounded fit-statistics fallback-buffer entry; do not carry predecessor #568 history or any patch/journal/source-snapshot artifact. Then rerun focused EAP parity/source-allocation tests and exact-head full CI/security/package/GPU/fuzz/review gates. Keep Draft until all required checks and qualifying independent approval succeed; no universal performance claim or branch-policy change.

Copy link
Copy Markdown
Contributor Author

/oc

Exact-head deterministic completion only. Before writing, assert git rev-parse HEAD is 59e1a20e15ecb5e1387bb73251a6bd4677f1e39a; abort if it moved. Run python scripts/render_changelog_fragments.py --update CHANGELOG.md, then --check, pytest -q tests/test_changelog_fragment_contract.py tests/test_mmle_fallback_eap_matmul.py, and git diff --check. Commit only the generated CHANGELOG.md; the resulting PR must contain exactly five changed paths: CHANGELOG.md, the EAP changelog fragment, EAP doctoring, python/fast_mlsirm/estimators/mmle.py, and tests/test_mmle_fallback_eap_matmul.py. Preserve every protected-main Unreleased note including merged #570. No workflow, dependency, API, version, second PR, branch-state, protection, or reviewer change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant