perf(mmle): use matrix-vector EAP projection - #568
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
@opencode-agent address Complete this current-main replacement without scope expansion:
Do not force-push, alter public APIs or workflows, claim a universal speedup, create another PR, or merge without the current-head gates. |
|
@opencode-agent address Exact head Make one ordinary direct documentation commit on python scripts/render_changelog_fragments.py --update CHANGELOG.md
python scripts/render_changelog_fragments.py --check CHANGELOG.mdDo not alter the numerical implementation, test fixture, fragment, workflow, dependency, version, or branch state. Then rerun the full exact-head CI, Security Scan, and SAST. Keep Draft until every check, current-head review, and independent approval pass. |
|
@opencode-agent address Refetch PR #568 and repair the exact live head only; predecessor-head evidence is stale. Current head Run the repository-owned renderer against the current branch: python scripts/render_changelog_fragments.py --update CHANGELOG.md
python scripts/render_changelog_fragments.py --check CHANGELOG.md
pytest -q tests/test_changelog_fragment_contract.py tests/test_mmle_fallback_eap_matmul.pyThe authoritative fragment is |
|
@jules Repair the sole exact-head CI failure on this Draft branch without changing the MMLE implementation or test semantics. CI Run: python scripts/render_changelog_fragments.py --update CHANGELOG.md
python scripts/render_changelog_fragments.py --check CHANGELOG.mdCommit only the deterministic managed |
|
@jules Repair the sole exact-head CI failure on |
|
The exact head is functionally green except for the authoritative changelog contract: 2,913 tests passed and only |
|
@jules On exact head |
seonghobae
left a comment
There was a problem hiding this comment.
Current-head repair contract: render and commit authoritative CHANGELOG.md, then rerun the complete exact-head CI. The existing head already has Rust, package, GPU no-skip, fuzz, Security Scan, and SAST success; Python has one deterministic changelog-parity failure after 2,913 passing tests. Keep Draft until the replacement head is fully green and reviewed.
|
@opencode-agent address Repair exact current Draft head Run |
|
/oc Fix the sole exact-head CI failure directly: render the authoritative fragment set into the managed Then run |
|
@opencode-agent address Current exact Draft head now contains one inert deterministic patch at set -euo pipefail
git apply --check docs/superpowers/patches/2026-08-07-mmle-eap-changelog.patch
git apply docs/superpowers/patches/2026-08-07-mmle-eap-changelog.patch
rm docs/superpowers/patches/2026-08-07-mmle-eap-changelog.patch
python scripts/render_changelog_fragments.py --check CHANGELOG.md
git diff --checkCommit only the managed |
|
@opencode-agent address Current head git apply --check docs/superpowers/patches/2026-08-07-mmle-eap-changelog.patch
git apply docs/superpowers/patches/2026-08-07-mmle-eap-changelog.patch
rm -rf docs/superpowers/patches
python scripts/render_changelog_fragments.py --check CHANGELOG.md
pytest -q tests/test_changelog_fragment_contract.py tests/test_mmle_fallback_eap_matmul.pyThe final PR diff must contain the one-line |
|
@jules The latest head Apply that patch to the real
No patch-part, workflow, helper, dependency, version, or other source file. Run renderer |
|
@jules Apply the single inert changelog patch already committed on this Draft branch, delete the patch file, run the repository changelog renderer check, and commit only |
|
/oc The exact-head CI now proves the product change itself is correct: Rust, fuzz, explicit GPU no-skip, package acceptance, Security Scan, SAST, and 2,913 of 2,914 Python tests pass. Finish the branch directly with repository hygiene only.
Keep Draft until that exact head is fully green, then request current-head review and enable protected auto-merge. |
|
@jules Exact current Draft head is Apply that patch by running the repository renderer against the exact current fragments, commit the resulting |
|
@jules Apply the repository renderer directly on the current Draft branch: remove |
|
@opencode-agent fix Apply the existing reviewed patch file to the real |
|
@jules Fix this existing Draft PR in place. The exact current head |
|
@opencode-agent address Exact head Make one ordinary direct documentation commit on python scripts/render_changelog_fragments.py --update CHANGELOG.md
python scripts/render_changelog_fragments.py --check CHANGELOG.mdDo not alter the EAP implementation, numerical fixture, fragment, workflow, dependency, lockfile, version, or branch state. Then rerun the full exact-head CI, Security Scan, and SAST. Keep Draft until every current-head check, review, and independent approval passes. |
|
@jules Fix the only current exact-branch CI failure from run |
|
@jules Exact-head CI diagnosis for |
|
@opencode-agent address Current exact head Run: git apply --check docs/superpowers/patches/2026-08-07-mmle-eap-changelog.patch
git apply docs/superpowers/patches/2026-08-07-mmle-eap-changelog.patch
rm docs/superpowers/patches/2026-08-07-mmle-eap-changelog.patch .github/workflows/dev-source-snapshot.yml
python scripts/render_changelog_fragments.py --update CHANGELOG.md
python scripts/render_changelog_fragments.py --check CHANGELOG.md
pytest -q tests/test_changelog_fragment_contract.py tests/test_mmle_fallback_eap_matmul.py
python -m compileall -q python/fast_mlsirm/estimators/mmle.py tests/test_mmle_fallback_eap_matmul.py
git diff --checkIf |
|
@jules Before Ready status, remove the two transport-only artifacts still present in the PR diff: |
|
@opencode-agent address Exact current Draft head: The sole product failure remains the managed changelog contract. Apply the repository-owned renderer on this exact branch: python scripts/render_changelog_fragments.py --update CHANGELOG.md
python scripts/render_changelog_fragments.py --check CHANGELOG.md
pytest -q tests/test_changelog_fragment_contract.py tests/test_mmle_fallback_eap_matmul.pyCommit the deterministic |
|
@jules CI |
d0b2928 to
2957023
Compare
|
/oc Continue from the exact current head. The final product diff must contain only the MMLE fallback EAP matrix-vector production change, its focused parity/allocation regression, authoritative changelog fragment, APA 7 doctoring, and rendered |
|
@opencode-agent Please repair only the deterministic authoritative-changelog failure on exact current head The branch was cleanly replayed onto protected python scripts/render_changelog_fragments.py --update CHANGELOG.md
python scripts/render_changelog_fragments.py --check CHANGELOG.mdCommit only the resulting current-fragment rendering of |
|
Exact-current-head completion gate for Apply one ordinary direct documentation commit only: python scripts/render_changelog_fragments.py --update CHANGELOG.md
python scripts/render_changelog_fragments.py --check CHANGELOG.md
pytest -q tests/test_changelog_fragment_contract.py tests/test_mmle_fallback_eap_matmul.py
git diff --checkBefore commit, compare to current protected main and prove the PR diff contains exactly five paths: the existing four plus |
|
/oc Abort unless the live branch is still |
|
@opencode-agent address Operate only if the live PR head is still exactly Do only the required deterministic repair on this existing branch:
The predecessor exact-head CI must not be rerun or counted after the head changes. |
|
@opencode-agent address Refetch PR #568 and write only if its exact Draft head is still |
|
@opencode-agent address Use the exact-head repair instructions already recorded in comment 5218396624. Refetch the live head first and abort if it differs. |
|
@opencode-agent address Refetch exact current Draft head Perform the single ordinary repository-owned repair now: python scripts/render_changelog_fragments.py --update CHANGELOG.md
python scripts/render_changelog_fragments.py --check CHANGELOG.md
pytest -q tests/test_changelog_fragment_contract.py tests/test_mmle_fallback_eap_matmul.pyIf and only if the exact head is unchanged, commit the resulting managed |
|
/oc Operate only on exact Draft head |
|
@opencode-agent address Exact current Draft head Make exactly the repository-prescribed release-record repair on the same branch: run |
|
@jules Work only on exact Draft head |
|
Correction on 2026-08-09: the earlier integration claim was invalid because it interpreted a reversed compare direction. With the exact live protected tip |
|
Closing now as superseded by #574, not as integrated by ancestry. Exact replacement evidence was independently checked against #574 head The correctly directed live compare still shows this head has four unique commits relative to protected main. Those commits are intentionally not merged because their domain-equivalent behavior and stronger safety evidence are retained in the live replacement. No checks, reviews, approvals, or commit ancestry are transferred from #568 to #574. |
|
@opencode-agent address Reopened after corrected ancestry verification. Protected main Refetch exact head/main before acting. If unchanged, non-destructively reconcile current main, preserve only the reviewed EAP optimization/test/doctoring/fragment, run the authoritative changelog renderer/check, run focused EAP/changelog tests, and keep Draft. No force-push, scope expansion, new PR, merge, release, or predecessor-head evidence reuse. |
|
Closing as superseded by the broader controlled replacement in #574, not as already integrated. Exact protected |
|
@jules address RCA is complete for exact head First re-read the branch head and current protected python scripts/render_changelog_fragments.py --update CHANGELOG.md
python scripts/render_changelog_fragments.py --check CHANGELOG.md
python -m pytest -q tests/test_mmle_fallback_eap_matmul.py tests/test_changelog_fragment_contract.pyCommit the normal main merge plus rendered |
Purpose
Rebase the reviewed NumPy fallback EAP projection onto current protected
mainwithout retaining the stale/diverged predecessor branch.Change
(posterior * nodes[None, :]).sum(axis=1)with the mathematically equivalentposterior @ nodes;Merge gates
CHANGELOG.mdwithout losing intervening release notes;Supersedes stale/diverged PR #549. No release is included.