feat(enterprise): parse explicit source values - #533
Conversation
|
@jules Implement the full draft slice on this branch from |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughAdds a deterministic, provider-neutral parser for explicit enterprise values. It creates immutable, content-addressed records for dates, deadlines, currencies, frequencies, and customer identifiers. It validates spans, ordering, limits, metadata, and custom-provider output. ChangesEnterprise explicit-value parsing
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant SourceRecord
participant Parser
participant CustomProvider
participant ExplicitValueRecord
participant EvidenceSpanRecord
SourceRecord->>Parser: verify source replay and span offsets
Parser->>CustomProvider: request explicit-value records
CustomProvider-->>Parser: return candidate records
Parser->>ExplicitValueRecord: reconstruct and validate canonical records
ExplicitValueRecord->>EvidenceSpanRecord: convert accepted records to evidence spans
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@jules Exact-head CI on
Then run at minimum: |
|
@opencode-agent @cwl-noema-review Please fix the two exact-head CI failures on this branch without weakening tests: (1) make |
|
@coderabbitai review |
|
|
@cwl-noema-review Review the exact current implementation after the payload-hardening workflow completes. Focus on fail-closed construction for non-mapping or adversarial payloads, provider-protocol output validation against the exact source revision/span, metadata privacy, deterministic ordering/overlap rules, complete branch coverage, and conservative statistical/product claims. Commit only valid fixes directly to this branch, remove any one-shot workflow from the final tree, and report exact validation results. |
|
@coderabbitai review |
|
|
@opencode-agent @cwl-noema-review Final exact-head review requested for |
|
@opencode-agent @cwl-noema-review Final exact-head review requested for |
Summary
Advances issue #404 with the next reviewable enterprise-evidence vertical slice after #529 and #532.
EnterpriseSourceRecordcontent fingerprint and Python Unicode-code-point character count before parsing;ExplicitValueRecordvalues and compiles exact occurrences into the acceptedEvidenceSpanRecordboundary without creating competing scoring, observation, result, or engine schemas;Refs #404
Validation
explicit_values.pyevidence is 100% statements and 100% branches (294 statements, 122 branches, no missing lines or partial branches);CHANGELOG.mdinclude the parser boundary, interpretation limits, whole-document fail-closed scope, and APA 7th references to ISO 8601-1, ISO 4217, ISO/IEC 42001, NIST AI RMF, Python standard-library semantics, and Unicode text segmentation;Exact-head CI, Security Scan, SAST, repository coverage, packaging, and final review remain merge gates.
Summary by CodeRabbit
New Features
Documentation
Tests