🎨 Palette: HTML 리포트의 본문 건너뛰기 링크 타겟에 대한 키보드 포커스 시각 피드백 추가 by seonghobae · Pull Request #330 · ContextualWisdomLab/fast-mlsirm

seonghobae · 2026-07-27T19:07:23Z

💡 What (무엇을 변경했는가)

HTML 진단 리포트(python/fast_mlsirm/report.py)의 CSS에 main:focus-visible 속성을 추가하여 <main> 요소가 키보드 탐색을 통해 포커스될 때 시각적인 테두리(outline)가 나타나도록 개선했습니다.

🎯 Why (왜 변경했는가)

기존 코드에는 main:focus { outline: none; }만 설정되어 있어, 키보드 사용자나 스크린 리더 사용자가 'Skip to main content(본문으로 건너뛰기)' 링크를 사용해 <main> 영역으로 이동했을 때 초점(Focus)이 어디에 있는지 시각적인 피드백을 제공하지 못하는 접근성 문제가 있었습니다. 마우스 클릭 시의 불필요한 포커스 링은 숨기면서, 키보드 탐색 사용자에게만 포커스 테두리를 제공하여 사용성을 향상시키기 위함입니다.

📸 Before/After (변경 전후)

Before: 'Skip to main content' 링크 작동 시 화면 상단 본문 영역으로 포커스가 이동하지만, 화면에 시각적인 테두리가 전혀 나타나지 않았습니다.
After: 'Skip to main content' 링크를 통해 포커스 이동 시 <main> 영역 주변에 기존 디자인과 어울리는 3px 두께의 청록색 테두리가 명확하게 표시됩니다. (Playwright 시각 검증 완료)

♿ Accessibility (접근성 개선 사항)

이 PR은 WCAG 초점(Focus) 표시 관련 가이드라인을 준수합니다. :focus-visible 가상 클래스를 활용하여 마우스/터치 사용자의 경험은 방해하지 않고, 오직 키보드 사용자에게만 논리적인 시각적 흐름(visual indicator)을 제공하도록 정밀하게 설계되었습니다.

PR created automatically by Jules for task 10892328335187518171 started by @seonghobae

This commit fixes an accessibility issue where the `<main>` element, acting as the target for the "Skip to main content" link, lacked a visible focus state. By adding a `:focus-visible` CSS rule alongside the existing `:focus { outline: none; }`, keyboard users now receive clear visual feedback (a 3px teal outline) when they navigate to the main content area, without introducing unnecessary focus rings on mouse clicks.

google-labs-jules · 2026-07-27T19:07:24Z

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

coderabbitai · 2026-07-27T19:07:35Z

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 36 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: be553de0-75da-4c2c-9b6c-7e54e3308aec

📥 Commits

Reviewing files that changed from the base of the PR and between a3123a2 and 7a04b5c.

📒 Files selected for processing (2)

python/fast_mlsirm/report.py
python/fast_mlsirm/report.py.orig

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch palette/a11y-focus-visible-10892328335187518171

_{Comment @coderabbitai help to get the list of available commands.}

Copilot

Pull request overview

This PR aims to improve keyboard accessibility in the standalone HTML diagnostics report by ensuring the <main> skip-link target provides a visible focus indicator during keyboard navigation.

Changes:

Added a main:focus-visible outline style in the report CSS to show a focus ring when <main> receives keyboard focus.
Added a new python/fast_mlsirm/report.py.orig file that appears to be a full duplicate of report.py (not referenced elsewhere).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
python/fast_mlsirm/report.py	Adds a `main:focus-visible` rule intended to restore visible focus indication for keyboard users.
python/fast_mlsirm/report.py.orig	Introduces a duplicate “.orig” copy of the report module (likely accidental / out of scope).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+main:focus-visible {
+  outline: 3px solid #0f766e;
+  outline-offset: 3px;
+}


+from __future__ import annotations
+
+import hashlib
+import json
+import math


seonghobae · 2026-07-29T12:42:51Z

중복/junk 정리: skip-link focus-visible 취지는 리뷰 대기 중인 #167 과 동일하며, 이 PR에는 report.py.orig(+700줄대 백업 파일)가 실수로 커밋되어 있습니다. 그룹당 대표 1건만 남기는 백로그 정리 방침에 따라 닫습니다. 필요 시 재오픈 가능합니다.

Generated by Claude Code

google-labs-jules · 2026-07-29T12:44:02Z

중복/junk 정리: skip-link focus-visible 취지는 리뷰 대기 중인 #167 과 동일하며, 이 PR에는 report.py.orig(+700줄대 백업 파일)가 실수로 커밋되어 있습니다. 그룹당 대표 1건만 남기는 백로그 정리 방침에 따라 닫습니다. 필요 시 재오픈 가능합니다.

Generated by Claude Code

Understood. Acknowledging that this PR is being closed due to duplicate backlog item (#167) and stopping work.

Copilot AI review requested due to automatic review settings July 27, 2026 19:07

Copilot started reviewing on behalf of seonghobae July 27, 2026 19:08 View session

Copilot AI reviewed Jul 27, 2026

View reviewed changes

seonghobae closed this Jul 29, 2026

Navigation Menu

Uh oh!

🎨 Palette: HTML 리포트의 본문 건너뛰기 링크 타겟에 대한 키보드 포커스 시각 피드백 추가 - #330

🎨 Palette: HTML 리포트의 본문 건너뛰기 링크 타겟에 대한 키보드 포커스 시각 피드백 추가#330
seonghobae wants to merge 1 commit into
mainfrom
palette/a11y-focus-visible-10892328335187518171

seonghobae commented Jul 27, 2026

Uh oh!

google-labs-jules Bot commented Jul 27, 2026

Uh oh!

coderabbitai Bot commented Jul 27, 2026

Review limit reached

Uh oh!

Copilot AI left a comment

Uh oh!

seonghobae commented Jul 29, 2026

Uh oh!

google-labs-jules Bot commented Jul 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

seonghobae commented Jul 27, 2026

💡 What (무엇을 변경했는가)

🎯 Why (왜 변경했는가)

📸 Before/After (변경 전후)

♿ Accessibility (접근성 개선 사항)

Uh oh!

google-labs-jules Bot commented Jul 27, 2026

Uh oh!

coderabbitai Bot commented Jul 27, 2026

Review limit reached

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

seonghobae commented Jul 29, 2026

Uh oh!

google-labs-jules Bot commented Jul 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants