Skip to content

🎨 Palette: 빈 μƒνƒœ(Empty State)에 ARIA status μ—­ν•  μΆ”κ°€ #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seonghobae wants to merge 1 commit into from
Closed

🎨 Palette: 빈 μƒνƒœ(Empty State)에 ARIA status μ—­ν•  μΆ”κ°€ #323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .Jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,6 @@
## 2024-10-24 - CSS Bar Chart Animation
**Learning:** CSS animations can enhance static data visualizations without requiring JavaScript, providing visual polish and reducing perceived loading times for data.
**Action:** Use CSS keyframe animations for simple visual improvements in static reports.
## 2024-11-05 - ARIA Live Region for Empty States
**Learning:** Using `role="status"` (an ARIA live region role) on empty state container elements (like a `<div>`) instead of standard paragraph tags ensures assistive technologies like screen readers actively announce when no data or rows are recorded, without interrupting the user's flow.
**Action:** Always use `<div class="empty-state" role="status">` for empty states instead of basic paragraphs.
Comment on lines +11 to +13
2 changes: 1 addition & 1 deletion python/fast_mlsirm/report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ def _bar_chart(rows: list[dict[str, Any]], value_key: str | None) -> str:

def _table(rows: list[dict[str, Any]], *, label: str, limit: int = 12) -> str:
if not rows:
return '<p class="empty-state">No rows were recorded in this section.</p>'
return '<div class="empty-state" role="status">No rows were recorded in this section.</div>'
Comment on lines 313 to +315

columns = _columns(rows)
body_rows = []
Expand Down
Loading