π¨ Palette: λΉ μν(Empty State)μ ARIA status μν μΆκ° - #323
π¨ Palette: λΉ μν(Empty State)μ ARIA status μν μΆκ°#323seonghobae wants to merge 1 commit into
Conversation
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
No actionable comments were generated in the recent review. π βΉοΈ Recent review infoβοΈ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: π Files selected for processing (2)
π WalkthroughWalkthroughλΉ ν
μ΄λΈμ empty-state λ§ν¬μ
μ΄ ARIA ChangesλΉ μν μ κ·Όμ±
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: π₯ Pre-merge checks | β 5β Passed checks (5 passed)
β¨ Finishing Touchesπ Generate docstrings
π§ͺ Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
Improve the accessibility of the Python HTML reportβs βempty stateβ messaging by converting the empty-state markup to an ARIA live-region (role="status") and documenting the pattern in the palette guidance.
Changes:
- Update
_table()to render empty states as<div class="empty-state" role="status">β¦</div>instead of a<p>. - Document the recommended empty-state live-region pattern in
.Jules/palette.md.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| python/fast_mlsirm/report.py | Switch empty-state output to a role="status" container for improved screen reader behavior. |
| .Jules/palette.md | Add palette guidance describing the role="status" empty-state pattern. |
π‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| def _table(rows: list[dict[str, Any]], *, label: str, limit: int = 12) -> str: | ||
| if not rows: | ||
| return '<p class="empty-state">No rows were recorded in this section.</p>' | ||
| return '<div class="empty-state" role="status">No rows were recorded in this section.</div>' |
| ## 2024-11-05 - ARIA Live Region for Empty States | ||
| **Learning:** Using `role="status"` (an ARIA live region role) on empty state container elements (like a `<div>`) instead of standard paragraph tags ensures assistive technologies like screen readers actively announce when no data or rows are recorded, without interrupting the user's flow. | ||
| **Action:** Always use `<div class="empty-state" role="status">` for empty states instead of basic paragraphs. |
|
μ€λ³΅ μ 리: 리ν¬νΈ λΉ μν(empty state)μ ARIA Generated by Claude Code |
μκ² μ΅λλ€. ν΄λΉ PRμ΄ μ€λ³΅μΌλ‘ μΈν΄ λ«νμμ νμΈνμμΌλ©°, μ΄ μμ μ μ¬κΈ°μ μ€λ¨νκ² μ΅λλ€. |
What: ν μ΄λΈμ΄λ μΉμ μ λ°μ΄ν°κ° μμ λ νμλλ λΉ μν(Empty State) μμλ₯Ό
<p>νκ·Έμμ<div class="empty-state" role="status">λ‘ λ³κ²½νμ΅λλ€.Why: λ°μ΄ν°κ° μμ λ μ€ν¬λ¦° 리λ μ¬μ©μκ° ν΄λΉ μ¬μ€μ λ°©ν΄λ°μ§ μκ³ μμ°μ€λ½κ² μΈμ§ν μ μλλ‘ λκΈ° μν¨μ λλ€.
Before/After: μκ°μ μΈ λ³κ²½ μ¬νμ μμΌλ©° μ€ν¬λ¦° 리λ κ²½νλ§ κ°μ λ©λλ€.
Accessibility: ARIA live region μμ±μΈ
role="status"λ₯Ό μΆκ°νμ¬ λΉ μν λ©μμ§κ° μ μ ν λλ λλλ‘ κ°μ νμ΅λλ€.PR created automatically by Jules for task 6135135559410135008 started by @seonghobae
Summary by CodeRabbit
κ°μ μ¬ν
λ¬Έμ