Skip to content

๐ŸŽจ Palette: HTML ๋ฆฌํฌํŠธ ๋ณธ๋ฌธ ๊ฑด๋„ˆ๋›ฐ๊ธฐ ํƒ€๊ฒŸ์˜ ํ‚ค๋ณด๋“œ ํฌ์ปค์Šค ๊ฐ€์‹œ์„ฑ ๋ณด์žฅ - #245

Closed
seonghobae wants to merge 2 commits into
mainfrom
palette/focus-visible-6037622873512656685
Closed

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

๐Ÿ’ก What (๋ฌด์—‡์„ ๋ณ€๊ฒฝํ–ˆ๋‚˜์š”?)

HTML ๋ฆฌํฌํŠธ ํ…œํ”Œ๋ฆฟ์˜ CSS์—์„œ main:focus-visible ์„ ํƒ์ž๋ฅผ ์ถ”๊ฐ€ํ•˜์—ฌ, <main> ์š”์†Œ์— ํฌ์ปค์Šค๊ฐ€ ์ด๋™ํ–ˆ์„ ๋•Œ ํ‚ค๋ณด๋“œ ์‚ฌ์šฉ์ž์—๊ฒŒ๋งŒ ๋ช…ํ™•ํ•œ ํฌ์ปค์Šค ์œค๊ณฝ์„ (outline)์ด ํ‘œ์‹œ๋˜๋„๋ก ๊ฐœ์„ ํ–ˆ์Šต๋‹ˆ๋‹ค.

๐ŸŽฏ Why (์™œ ๋ณ€๊ฒฝํ–ˆ๋‚˜์š”?)

์ด์ „์— ์ ์šฉ๋œ main:focus { outline: none; } ์†์„ฑ์€ ๋งˆ์šฐ์Šค ํด๋ฆญ ์‹œ ๋ถˆํ•„์š”ํ•œ ์œค๊ณฝ์„ ์ด ๋‚˜ํƒ€๋‚˜๋Š” ๊ฒƒ์„ ๋ฐฉ์ง€ํ–ˆ์ง€๋งŒ, "๋ณธ๋ฌธ์œผ๋กœ ๊ฑด๋„ˆ๋›ฐ๊ธฐ(Skip to main content)" ๋งํฌ๋ฅผ ํ†ตํ•ด ํ‚ค๋ณด๋“œ๋กœ ๋„ค๋น„๊ฒŒ์ด์…˜ํ•˜๋Š” ์Šคํฌ๋ฆฐ ๋ฆฌ๋” ๋ฐ ํ‚ค๋ณด๋“œ ์ „์šฉ ์‚ฌ์šฉ์ž์—๊ฒŒ๋„ ํฌ์ปค์Šค ์œ„์น˜๋ฅผ ์‹œ๊ฐ์ ์œผ๋กœ ์ˆจ๊ธฐ๋Š” ์ ‘๊ทผ์„ฑ ๋ฌธ์ œ๋ฅผ ๋ฐœ์ƒ์‹œ์ผฐ์Šต๋‹ˆ๋‹ค.

๐Ÿ“ธ Before/After (๋ณ€๊ฒฝ ์ „/ํ›„)

  • Before: ํ‚ค๋ณด๋“œ๋กœ skip-link๋ฅผ ํ†ตํ•ด main ์š”์†Œ์— ์ง„์ž…ํ•ด๋„ ํ™”๋ฉด์— ์–ด๋–ค ํฌ์ปค์Šค ํ‘œ์‹œ๋„ ๋‚˜ํƒ€๋‚˜์ง€ ์•Š์•„ ํ˜„์žฌ ํฌ์ปค์Šค ์œ„์น˜๋ฅผ ์‹œ๊ฐ์ ์œผ๋กœ ์•Œ ์ˆ˜ ์—†์—ˆ์Šต๋‹ˆ๋‹ค.
  • After: ํ‚ค๋ณด๋“œ ๋„ค๋น„๊ฒŒ์ด์…˜์„ ํ†ตํ•ด ์ง„์ž…ํ•  ๊ฒฝ์šฐ์—๋งŒ outline: 3px solid #0f766e๊ฐ€ ์ ์šฉ๋˜์–ด ๋ช…ํ™•ํ•˜๊ฒŒ ๋ณธ๋ฌธ ์˜์—ญ์— ํฌ์ปค์Šค๊ฐ€ ์œ„์น˜ํ•จ์„ ์‹œ๊ฐ์ ์œผ๋กœ ์•ˆ๋‚ดํ•ฉ๋‹ˆ๋‹ค. ๋งˆ์šฐ์Šค ํด๋ฆญ ์‹œ์—๋Š” ๊ธฐ์กด์ฒ˜๋Ÿผ ์œค๊ณฝ์„ ์ด ๋‚˜ํƒ€๋‚˜์ง€ ์•Š์Šต๋‹ˆ๋‹ค.

โ™ฟ Accessibility (์ ‘๊ทผ์„ฑ ๊ฐœ์„  ์‚ฌํ•ญ)

  • ํ”„๋กœ๊ทธ๋žจ์ ์œผ๋กœ ํฌ์ปค์Šค๋ฅผ ๋ฐ›๋Š” ์˜์—ญ(tabindex="-1")์— ๋Œ€ํ•ด :focus-visible์„ ์ ์ ˆํžˆ ํ˜ผํ•ฉ ์‚ฌ์šฉํ•˜์—ฌ ๋งˆ์šฐ์Šค ์‚ฌ์šฉ์ž์˜ ์‚ฌ์šฉ์„ฑ์„ ํ•ด์น˜์ง€ ์•Š์œผ๋ฉด์„œ๋„ ํ‚ค๋ณด๋“œ ์‚ฌ์šฉ์ž์˜ ํฌ์ปค์Šค ์ถ”์ ์„ฑ(Focus Traceability)์„ ์™„๋ฒฝํ•˜๊ฒŒ ํ™•๋ณดํ–ˆ์Šต๋‹ˆ๋‹ค. ๊ด€๋ จํ•˜์—ฌ ํ–ฅํ›„ ๋™์ผํ•œ ํŒจํ„ด์ด ์ง€์† ์ ์šฉ๋  ์ˆ˜ ์žˆ๋„๋ก .jules/palette.md ์ €๋„์— ํ•ต์‹ฌ ํ•™์Šต ๋‚ด์šฉ(Critical Learning)์„ ์ถ”๊ฐ€ ๊ธฐ๋กํ–ˆ์Šต๋‹ˆ๋‹ค.

PR created automatically by Jules for task 6037622873512656685 started by @seonghobae

@google-labs-jules

Copy link
Copy Markdown

๐Ÿ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a ๐Ÿ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI review requested due to automatic review settings July 24, 2026 19:07

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves the standalone HTML reportโ€™s keyboard accessibility by restoring a visible focus indicator when the skip-to-content link moves focus to the <main> element, while keeping mouse-click outlines suppressed. Also updates Rust dependency locking and documents the accessibility pattern in the projectโ€™s palette journal.

Changes:

  • Add main:focus-visible styling so keyboard users see a clear outline when focus lands on <main> via the skip link.
  • Bump the locked pollster crate version in crates/fast-mlsirm-py/Cargo.lock.
  • Record the :focus + :focus-visible pairing pattern for programmatic focus targets in .jules/palette.md.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
python/fast_mlsirm/report.py Adds main:focus-visible outline to ensure skip-link target focus is visible for keyboard users.
crates/fast-mlsirm-py/Cargo.lock Updates locked pollster dependency version/checksum.
.jules/palette.md Documents the focus-visible pattern for programmatic skip-link targets.

๐Ÿ’ก Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings July 25, 2026 22:51

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment thread python/fast_mlsirm/report.py
Comment thread .jules/palette.md

## 2024-07-14 - Programmatic Focus Indicators with :focus-visible
**Learning:** When using `<main tabindex="-1">` as the target for a skip-to-content link, simply setting `:focus { outline: none; }` solves the issue of mouse clicks causing an unwanted visual outline. However, this entirely removes the focus indicator for keyboard users who navigate via the skip-link, degrading accessibility.
**Action:** Always pair `target:focus { outline: none; }` with `target:focus-visible { outline: [visible style]; }` for programmatic focus targets, so that focus outlines correctly appear only during keyboard navigation and not on mouse interactions.
@seonghobae
seonghobae enabled auto-merge (squash) July 26, 2026 09:01
@opencode-agent
opencode-agent Bot disabled auto-merge July 26, 2026 09:44

Copy link
Copy Markdown
Contributor Author

์ค‘๋ณต ์ •๋ฆฌ: report.py์˜ skip-link ํƒ€๊ฒŸ main:focus-visible ๊ทœ์น™ ์ถ”๊ฐ€๋กœ, ๋ฆฌ๋ทฐ ๋Œ€๊ธฐ ์ค‘์ธ #167 ๊ณผ ๋™์ผ ๋Œ€์ƒยท๋™์ผ ์ทจ์ง€์ž…๋‹ˆ๋‹ค. ๊ทธ๋ฃน๋‹น ๋Œ€ํ‘œ 1๊ฑด๋งŒ ๋‚จ๊ธฐ๋Š” ๋ฐฑ๋กœ๊ทธ ์ •๋ฆฌ ๋ฐฉ์นจ์— ๋”ฐ๋ผ ๋‹ซ์Šต๋‹ˆ๋‹ค. ํ•„์š” ์‹œ ์žฌ์˜คํ”ˆ ๊ฐ€๋Šฅํ•ฉ๋‹ˆ๋‹ค.


Generated by Claude Code

@google-labs-jules

Copy link
Copy Markdown

์ค‘๋ณต ์ •๋ฆฌ: report.py์˜ skip-link ํƒ€๊ฒŸ main:focus-visible ๊ทœ์น™ ์ถ”๊ฐ€๋กœ, ๋ฆฌ๋ทฐ ๋Œ€๊ธฐ ์ค‘์ธ #167 ๊ณผ ๋™์ผ ๋Œ€์ƒยท๋™์ผ ์ทจ์ง€์ž…๋‹ˆ๋‹ค. ๊ทธ๋ฃน๋‹น ๋Œ€ํ‘œ 1๊ฑด๋งŒ ๋‚จ๊ธฐ๋Š” ๋ฐฑ๋กœ๊ทธ ์ •๋ฆฌ ๋ฐฉ์นจ์— ๋”ฐ๋ผ ๋‹ซ์Šต๋‹ˆ๋‹ค. ํ•„์š” ์‹œ ์žฌ์˜คํ”ˆ ๊ฐ€๋Šฅํ•ฉ๋‹ˆ๋‹ค.


Generated by Claude Code

์•Œ๊ฒ ์Šต๋‹ˆ๋‹ค. ์ค‘๋ณต๋œ ์ž‘์—…์ž„์„ ์ธ์ง€ํ•˜์˜€์œผ๋ฉฐ ํ•ด๋‹น ์ž‘์—…์€ ์ค‘๋‹จํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค.

@seonghobae seonghobae closed this Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants