๐จ Palette: HTML ๋ฆฌํฌํธ ๋ณธ๋ฌธ ๊ฑด๋๋ฐ๊ธฐ ํ๊ฒ์ ํค๋ณด๋ ํฌ์ปค์ค ๊ฐ์์ฑ ๋ณด์ฅ - #245
๐จ Palette: HTML ๋ฆฌํฌํธ ๋ณธ๋ฌธ ๊ฑด๋๋ฐ๊ธฐ ํ๊ฒ์ ํค๋ณด๋ ํฌ์ปค์ค ๊ฐ์์ฑ ๋ณด์ฅ#245seonghobae wants to merge 2 commits into
Conversation
|
๐ Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a ๐ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
Improves the standalone HTML reportโs keyboard accessibility by restoring a visible focus indicator when the skip-to-content link moves focus to the <main> element, while keeping mouse-click outlines suppressed. Also updates Rust dependency locking and documents the accessibility pattern in the projectโs palette journal.
Changes:
- Add
main:focus-visiblestyling so keyboard users see a clear outline when focus lands on<main>via the skip link. - Bump the locked
pollstercrate version incrates/fast-mlsirm-py/Cargo.lock. - Record the
:focus+:focus-visiblepairing pattern for programmatic focus targets in.jules/palette.md.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| python/fast_mlsirm/report.py | Adds main:focus-visible outline to ensure skip-link target focus is visible for keyboard users. |
| crates/fast-mlsirm-py/Cargo.lock | Updates locked pollster dependency version/checksum. |
| .jules/palette.md | Documents the focus-visible pattern for programmatic skip-link targets. |
๐ก Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| ## 2024-07-14 - Programmatic Focus Indicators with :focus-visible | ||
| **Learning:** When using `<main tabindex="-1">` as the target for a skip-to-content link, simply setting `:focus { outline: none; }` solves the issue of mouse clicks causing an unwanted visual outline. However, this entirely removes the focus indicator for keyboard users who navigate via the skip-link, degrading accessibility. | ||
| **Action:** Always pair `target:focus { outline: none; }` with `target:focus-visible { outline: [visible style]; }` for programmatic focus targets, so that focus outlines correctly appear only during keyboard navigation and not on mouse interactions. |
|
์ค๋ณต ์ ๋ฆฌ: Generated by Claude Code |
์๊ฒ ์ต๋๋ค. ์ค๋ณต๋ ์์ ์์ ์ธ์งํ์์ผ๋ฉฐ ํด๋น ์์ ์ ์ค๋จํ๊ฒ ์ต๋๋ค. |
๐ก What (๋ฌด์์ ๋ณ๊ฒฝํ๋์?)
HTML ๋ฆฌํฌํธ ํ ํ๋ฆฟ์ CSS์์
main:focus-visible์ ํ์๋ฅผ ์ถ๊ฐํ์ฌ,<main>์์์ ํฌ์ปค์ค๊ฐ ์ด๋ํ์ ๋ ํค๋ณด๋ ์ฌ์ฉ์์๊ฒ๋ง ๋ช ํํ ํฌ์ปค์ค ์ค๊ณฝ์ (outline)์ด ํ์๋๋๋ก ๊ฐ์ ํ์ต๋๋ค.๐ฏ Why (์ ๋ณ๊ฒฝํ๋์?)
์ด์ ์ ์ ์ฉ๋
main:focus { outline: none; }์์ฑ์ ๋ง์ฐ์ค ํด๋ฆญ ์ ๋ถํ์ํ ์ค๊ณฝ์ ์ด ๋ํ๋๋ ๊ฒ์ ๋ฐฉ์งํ์ง๋ง, "๋ณธ๋ฌธ์ผ๋ก ๊ฑด๋๋ฐ๊ธฐ(Skip to main content)" ๋งํฌ๋ฅผ ํตํด ํค๋ณด๋๋ก ๋ค๋น๊ฒ์ด์ ํ๋ ์คํฌ๋ฆฐ ๋ฆฌ๋ ๋ฐ ํค๋ณด๋ ์ ์ฉ ์ฌ์ฉ์์๊ฒ๋ ํฌ์ปค์ค ์์น๋ฅผ ์๊ฐ์ ์ผ๋ก ์จ๊ธฐ๋ ์ ๊ทผ์ฑ ๋ฌธ์ ๋ฅผ ๋ฐ์์์ผฐ์ต๋๋ค.๐ธ Before/After (๋ณ๊ฒฝ ์ /ํ)
main์์์ ์ง์ ํด๋ ํ๋ฉด์ ์ด๋ค ํฌ์ปค์ค ํ์๋ ๋ํ๋์ง ์์ ํ์ฌ ํฌ์ปค์ค ์์น๋ฅผ ์๊ฐ์ ์ผ๋ก ์ ์ ์์์ต๋๋ค.outline: 3px solid #0f766e๊ฐ ์ ์ฉ๋์ด ๋ช ํํ๊ฒ ๋ณธ๋ฌธ ์์ญ์ ํฌ์ปค์ค๊ฐ ์์นํจ์ ์๊ฐ์ ์ผ๋ก ์๋ดํฉ๋๋ค. ๋ง์ฐ์ค ํด๋ฆญ ์์๋ ๊ธฐ์กด์ฒ๋ผ ์ค๊ณฝ์ ์ด ๋ํ๋์ง ์์ต๋๋ค.โฟ Accessibility (์ ๊ทผ์ฑ ๊ฐ์ ์ฌํญ)
tabindex="-1")์ ๋ํด:focus-visible์ ์ ์ ํ ํผํฉ ์ฌ์ฉํ์ฌ ๋ง์ฐ์ค ์ฌ์ฉ์์ ์ฌ์ฉ์ฑ์ ํด์น์ง ์์ผ๋ฉด์๋ ํค๋ณด๋ ์ฌ์ฉ์์ ํฌ์ปค์ค ์ถ์ ์ฑ(Focus Traceability)์ ์๋ฒฝํ๊ฒ ํ๋ณดํ์ต๋๋ค. ๊ด๋ จํ์ฌ ํฅํ ๋์ผํ ํจํด์ด ์ง์ ์ ์ฉ๋ ์ ์๋๋ก.jules/palette.md์ ๋์ ํต์ฌ ํ์ต ๋ด์ฉ(Critical Learning)์ ์ถ๊ฐ ๊ธฐ๋กํ์ต๋๋ค.PR created automatically by Jules for task 6037622873512656685 started by @seonghobae