Skip to content

docs(adr): bind Figma buyer evidence identity - #1130

Merged
seonghobae merged 3 commits into
mainfrom
docs/figma-adr-boundary-1190
Aug 24, 2026
Merged

docs(adr): bind Figma buyer evidence identity#1130
seonghobae merged 3 commits into
mainfrom
docs/figma-adr-boundary-1190

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Record the authoritative buyer-review Figma File ID and URL in ADR-0016.
  • Define the repository-local packet validation boundary and keep Code Connect downstream.
  • Index the decision and add a changelog fragment.

Verification

  • tests/test_governance_index_contract.py
  • tests/test_architecture_documentation_contract.py
  • tests/test_documentation_coverage_fitness.py
  • 23 passed; JSON validation and git diff --check passed.

No psychometric formula, runtime dependency, or hosted UI ownership changes.


Open in Devin Review

@seonghobae
seonghobae enabled auto-merge (squash) August 21, 2026 04:39
@seonghobae

Copy link
Copy Markdown
Contributor Author

Current-head review record for 240b539277f946a32cc50d8056b05769ca4cbdc5: ADR-0016 now binds Figma File ID qD34PfMH8Kr41tFdqLCkem and its design URL to the repository-local buyer-evidence packet boundary, while keeping Code Connect and hosted UI ownership downstream. Governance, architecture-documentation, and documentation-fitness tests pass (23 passed); JSON validation and git diff --check pass. Remote head was verified and auto-merge is enabled; hosted Checks are newly queued with no failure observed. Review only this exact HEAD; no self-approval or bypass.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 19 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 571628ff-878a-4463-9580-9126780ed820

📥 Commits

Reviewing files that changed from the base of the PR and between 04d0bc2 and 890ba99.

📒 Files selected for processing (4)
  • docs/GOVERNANCE_INDEX.md
  • docs/adr/0016-figma-buyer-evidence-design-boundary.md
  • docs/adr/README.md
  • docs/changelog.d/1190-figma-adr-boundary.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

devin-ai-integration[bot]

This comment was marked as resolved.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Current-head follow-up for 890ba99f3d3a8f2f51898860bbc86f968b6e42e3: normalized ADR formatting removes diff-check whitespace defects and records the official Figma Help Center reference in APA-style form. Governance, architecture-documentation, and documentation-fitness tests still pass (23 passed), and working-tree git diff --check is clean. Remote head was verified after a normal push; hosted Checks are newly queued and auto-merge remains enabled. Review only this exact HEAD; no self-approval or bypass.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Exact current head 890ba99fb0fcb3679494a62776b0588de6fe7a80 is documentation-only and records the required Figma File ID qD34PfMH8Kr41tFdqLCkem in ADR-0016. Packet evidence already binds the same design URL and code_connect=false; governance and ADR indexes are updated. Figma/sales-readiness tests pass with committed pytest path configuration (13 focused tests); without prerequisite PR #1091 they reproduce the known PYTHONPATH root-cause. No source edit is justified here; protected auto-merge remains gate-controlled.

@opencode-agent opencode-agent Bot added area: auth Authentication, authorization, identity, or tenant isolation area: ui-ux Frontend, interaction, design, or user experience priority: medium Normal-priority or P2 work status: needs-review Open pull request requiring current-head review or checks type: docs Documentation, ADR, PRD, or technical writing labels Aug 22, 2026
@coderabbitai

coderabbitai Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

An error occurred during the review process. Please try again later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

The fragment used "## Documentation", which is not one of
render_changelog_fragments.py's _ALLOWED_SECTIONS (Added, Changed,
Deprecated, Removed, Fixed, Security), so
test_changelog_fragment_contract.py failed closed on this branch:
"unsupported section 'Documentation'". Matches the existing precedent
for ADR/governance-only fragments (docs/changelog.d/governance-index.md,
canonical-architecture-baseline.md), which both use "## Added".
@coderabbitai

coderabbitai Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

An error occurred during the review process. Please try again later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 new potential issues.

Open in Devin Review

Comment thread docs/changelog.d/1190-figma-adr-boundary.md
Comment thread docs/adr/0016-figma-buyer-evidence-design-boundary.md
@opencode-agent
opencode-agent Bot disabled auto-merge August 22, 2026 09:58
@seonghobae
seonghobae enabled auto-merge (squash) August 24, 2026 01:04
@opencode-agent
opencode-agent Bot disabled auto-merge August 24, 2026 02:20
@seonghobae
seonghobae merged commit 12b6356 into main Aug 24, 2026
38 checks passed
@seonghobae
seonghobae deleted the docs/figma-adr-boundary-1190 branch August 24, 2026 05:57
seonghobae added a commit that referenced this pull request Aug 25, 2026
Pin the baseline to protected main@9c12eab1 (v0.9.0). The open-PR queue
collapsed from 74 to 6 since the previous snapshot; replace the stale PR
table with the current six lanes (#1363, #1345, #1279, #1029, #1005, #998)
including their merge-forward state. Update gap-matrix evidence columns for
landed work: automatic Rust backend (#951/#1070), crossed multiple-membership
(#1014), the Figma design-boundary ADR now at docs/adr/0016 via merged
#1130, and cross-engine conformance (#1082) after #1077 closed as completed.
No production code, formula, estimator, or release surface changed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: auth Authentication, authorization, identity, or tenant isolation area: ui-ux Frontend, interaction, design, or user experience priority: medium Normal-priority or P2 work status: needs-review Open pull request requiring current-head review or checks type: docs Documentation, ADR, PRD, or technical writing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant