Skip to content

fix(test): update stale NIM outage-domain test to match #941's independent-account contract #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seonghobae merged 1 commit into from
Aug 31, 2026
Merged

fix(test): update stale NIM outage-domain test to match #941's independent-account contract #945

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions tests/test_discovery_bootstrap_selection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,8 +323,16 @@ def test_bootstrap_selector_prefers_provider_diversity_before_duplicates() -> No
assert selected == [router_cheapest, nim_model, openai_model]


def test_bootstrap_selector_treats_nim_primary_and_sub_as_one_outage_domain() -> None:
"""Two NIM keys must not displace an independently hosted provider."""
def test_bootstrap_selector_keeps_nim_primary_and_sub_credential_accounts_independent() -> None:
"""Two NIM keys are independent credential accounts, not one collapsed family.

Superseded 2026-08-31 (see ``docs/product-technical-gap-baseline.md`` and
ADR 0032): treating ``nvidia_nim``/``nvidia_nim_sub`` as one outage domain
assumed the two credentials expose the same model catalog. They may not --
each API key can be entitled to different models -- so the selector must
not collapse them by provider-name family. Only an explicit ``model_group``
establishes logical equivalence between discovered models.
"""
selector = getattr(
model_discovery,
"select_bootstrap_discovered_agents",
Expand All @@ -346,7 +354,7 @@ def test_bootstrap_selector_treats_nim_primary_and_sub_as_one_outage_domain() ->
2,
)

assert selected == [nim_primary, openrouter]
assert selected == [nim_primary, nim_sub]


def test_bootstrap_selector_is_deterministic_when_every_model_is_unpriced() -> None:
Expand Down
Loading