fix(test): update stale NIM outage-domain test to match #941's independent-account contract - #945
Conversation
…ndent-account contract test_bootstrap_selector_treats_nim_primary_and_sub_as_one_outage_domain asserted the pre-#941 behavior (select_bootstrap_discovered_agents collapsing nvidia_nim/nvidia_nim_sub into one provider family). 5224a4c (part of #941) deliberately removed that grouping -- documented in docs/product-technical-gap-baseline.md and ADR 0032 as superseded, since each credential's API key may be entitled to a different model catalog -- but left this one test asserting the old behavior, making it fail unconditionally on main. Verified this fails identically on a clean origin/main checkout with none of this PR's changes present. No production code changed; the test now asserts the documented, already-shipped independent-account contract.
|
Warning Review limit reachedNext included review available in 42 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
|
Generated by Claude Code |
Brings in #945's already-merged, authoritative fix for the stale test_bootstrap_selector_treats_nim_primary_and_sub_as_one_outage_domain (main @ bffbc72, merged via 0adca47) instead of keeping this branch's own port of the equivalent #947 fix, which #945 beat to main and #947 was then closed as superseded. Conflict in tests/test_discovery_bootstrap_selection.py resolved by taking main's version of that one test function entirely (git checkout --theirs) rather than reconciling two different renames of the same fix. Added a short "Update" note to this branch's earlier docs/product-technical-gap-baseline.md entry recording that #945 landed first; no other file conflicted. tests/test_discovery_bootstrap_selection.py -q: 14 passed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015Gs7KmNvH75nxz1sL8mKjw
2 participants
Summary
tests/test_discovery_bootstrap_selection.py::test_bootstrap_selector_treats_nim_primary_and_sub_as_one_outage_domainfails unconditionally on currentmain(verified on a clean checkout). It asserts the pre-fix(discovery): keep credential catalogs independent #941 behavior ofselect_bootstrap_discovered_agents— thatnvidia_nim/nvidia_nim_subcollapse into one provider family so only one of the two can be selected alongside another provider.5224a4c4(part of fix(discovery): keep credential catalogs independent #941, "codex/all-key-discovery-latency-routing") deliberately removed that grouping from the implementation and documented the reversal indocs/product-technical-gap-baseline.mdand ADR 0032: "this historical provider-family conclusion is no longer the product contract... every credential account is discovered and judged independently" — because each NIM API key (NVIDIA_NIM_API_KEYvsNVIDIA_NIM_API_KEY_SUB) can be entitled to a different model catalog and must not be assumed identical or collapsible. That commit updated the implementation and both docs but never touched this one test in a different test file, leaving it asserting the now-superseded behavior — red onmainever since.nvidia_nimandnvidia_nim_subas the two cheapest candidates andlimit=2, both are now selected ([nim_primary, nim_sub]), matching how every other independent provider pair in this file already behaves.Developer experience
No API or behavior change — production code is untouched.
select_bootstrap_discovered_agents's own docstring already states "No vendor or endpoint name is used to infer a shared family or collapse credential state"; this test now matches that docstring instead of contradicting it.User experience
None — test-only change.
Test plan
origin/maincheckout (git worktree add+pytest tests/test_discovery_bootstrap_selection.py::test_bootstrap_selector_treats_nim_primary_and_sub_as_one_outage_domain) to confirm it is pre-existing and unrelated to any other in-flight change.python -m pytest tests/test_discovery_bootstrap_selection.py -q— 14/14 pass after the fix.interrogate(project-wide,fail-under = 80): 100%.Generated by Claude Code