fix: preserve multimodal evidence through deep workflows - #778
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@opencode-agent Please review the exact current head 6e0daf8. Verify that every evidence-bearing workflow step retains source image blocks, Responses input_image normalization stays provider-neutral, and image failover never selects a text-only agent. |
|
@opencode-agent Review exact current HEAD |
|
Validated the exact stack head |
|
Runtime acceptance update for exact HEAD |
|
Current-head review refresh: the remote branch has advanced beyond the previously reviewed |
|
OpenCode review requested for exact current head 49c6d93. The new boundary regression exposed that an explicit text-only primary could bypass required_tags=(vision); the shared failover candidate builder now excludes capability-ineligible primaries and fails closed when no matching agent exists. Focused multimodal and provider-reliability verification: 21 passed. |
|
Private consumer-runtime aggregate evidence for the image propagation path (non-identifying): the authorized LineageWeave run obtained image analysis for all 5 source images and persisted 776 image-OCR characters, 5 Markdown table signals, 31 visual regions, and 773 region-OCR characters. This runtime used the image-propagation implementation from 6e0daf8; exact-head 49c6d93 additionally closes the explicit-primary required-tag bypass and is verified by 21 focused multimodal/reliability tests. |
|
Exact-head verification update for 49c6d93: the complete local suite passes, 1472 passed in 527.42s. A correctly configured private consumer structure request also returned complete cardinality (23 input semantic units, 23 structured decisions); no private content or identifiers are included. |
|
Remote exact head advanced to |
|
|
|
@devin review exact current HEAD 915f780. This branch was updated onto current parent b225e13; the merge preserves multimodal evidence changes, parent capability/temperature/provider changes, and inbound framing/deadline. Integrated focused suite passes (58 passed) with changed-file Ruff/diff clean. Revalidate this exact head only. |
|
Current exact HEAD:
Normal auto-squash merge is now armed; no approval or bypass is used. |
0a3ab0b
into
fix/auto-reasoning-effort-contract-rebased
Buyer-visible gap
An authorized, non-identifying five-image runtime check completed transport and stored five captions but zero OCR characters. The conducted workflow had converted the source pixels into a text marker before thinker, worker, verifier, and synthesizer execution, so successful transport was not successful evidence extraction.
Behavior
input_imageURL blocks into the existing Chatimage_urlrepresentation without provider-specific routing.vision; it fails before provider I/O when the pool has no such agent.Verification
python -m pytest -q->1471 passed in 539.13s6 passed30 passedpython -m compileall -q contextual_orchestrator tests/test_multimodal_workflow_evidence.pygit diff --checkcodegraph sync && codegraph status-> healthy, up to dateStack contract
This PR is intentionally based on #765 at exact head
d3f9a9b96523ed572b908c8abba1afa527eb49dc. It does not modify #765's gateway/reasoning work or #776's inbound-framing work. ADR 0018 avoids the concurrent ADR 0017 allocation in #776.Remaining runtime acceptance
Repository behavior and contracts are verified here. A follow-up private LineageWeave backfill must restore non-empty OCR and region evidence before this is represented as live product recovery; only aggregate, non-identifying evidence will be reported.