Skip to content

fix(security): bound inbound request framing - #776

Merged
seonghobae merged 2 commits into
fix/auto-reasoning-effort-contract-rebasedfrom
fix/issue-119-inbound-framing
Aug 20, 2026
Merged

fix(security): bound inbound request framing#776
seonghobae merged 2 commits into
fix/auto-reasoning-effort-contract-rebasedfrom
fix/issue-119-inbound-framing

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

No description provided.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Current exact head is 3830f38. Review evidence: 1483 full tests on #765 substrate, 38 framing/security focused tests after final change, compileall, ruff, actionlint, osv-scanner no issues, and diff check passed. This PR intentionally remains stacked on #765 until parent reaches protected main; then retarget/rebase and rerun all hosted gates before normal merge.

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 97206cf9-a919-4b46-9098-d9d5521c6812

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae

Copy link
Copy Markdown
Contributor Author

@opencode-agent Review exact current HEAD 3830f38 only. Verify strict fixed-length framing, duplicate/malformed/oversized Content-Length rejection, unsupported Transfer-Encoding rejection, bounded socket read timeout restoration, close-on-error behavior, and RFC 9112 evidence. Submit a formal exact-head verdict without modifying the branch.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Exact-head review at 0ec115134d21d1fbee17cc5431e1c9433667ee5a reproduced a real failure:

  • pytest -q tests/test_inbound_request_total_deadline.py tests/test_inbound_request_framing.py -> 1 failed, 18 passed.
  • The new slow-progress regression fails because _read_json only sets a per-read socket timeout; it never checks a total monotonic deadline, so byte trickling can extend the request indefinitely.

I am preserving this branch and preparing a stacked root-cause fix that recalculates the remaining deadline before every read and fails closed with 408. Do not merge 0ec1151 until the exact-head test is green.

@seonghobae

Copy link
Copy Markdown
Contributor Author

@seonghobae
seonghobae merged commit 3e6c420 into fix/auto-reasoning-effort-contract-rebased Aug 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant