Skip to content

test(api): lock chat/Completions OpenAI metadata honesty over HTTP - #432

Closed
seonghobae wants to merge 1 commit into
mainfrom
feat/chat-openai-metadata-http-honesty-20260814000228
Closed

test(api): lock chat/Completions OpenAI metadata honesty over HTTP#432
seonghobae wants to merge 1 commit into
mainfrom
feat/chat-openai-metadata-http-honesty-20260814000228

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Summary

  • Lock OpenAI chat/Completions metadata fail-closed honesty over real HTTP: string pairs accepted; non-object, non-string values, >16 entries, oversized keys/values rejected.
  • Re-ships tip substrate (server.py, orchestrator.py, cost_ledger.py) from bare main with model-required fixture alignment.
  • Complements feat(api): enforce OpenAI-shaped metadata on Completions and chat #383 unit enforcement with buyer-facing HTTP outcomes on tip substrate.

Test plan

  • Full unit suite locally
  • tests/test_chat_openai_metadata_http_honesty.py (8 HTTP cases)

Product gates

Full unit + Semgrep only; Strix noise ignored.

OpenAI metadata must be string pairs (≤16 entries, key≤64, value≤512).
Non-string entries must fail closed so buyers cannot store untyped junk
that observability would silently drop. Lock HTTP outcomes; re-ship tip
substrate from bare main with model-required fixture alignment.
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 83 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6f26bfa4-3c8e-44a7-8127-3de95fb8d6e1

📥 Commits

Reviewing files that changed from the base of the PR and between 6841b71 and 9881d25.

📒 Files selected for processing (13)
  • contextual_orchestrator/cost_ledger.py
  • contextual_orchestrator/orchestrator.py
  • contextual_orchestrator/server.py
  • tests/test_analytics_runtime.py
  • tests/test_budget_enforcement.py
  • tests/test_chat_openai_metadata_http_honesty.py
  • tests/test_commercial_readiness.py
  • tests/test_cost_review_server.py
  • tests/test_openai_passthrough.py
  • tests/test_sales_readiness.py
  • tests/test_security_hardening.py
  • tests/test_streaming.py
  • tests/test_true_streaming.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae enabled auto-merge (squash) August 13, 2026 15:04
@seonghobae
seonghobae marked this pull request as draft August 13, 2026 15:12
auto-merge was automatically disabled August 13, 2026 15:12

Pull request was converted to draft

@seonghobae seonghobae closed this Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant