fix: govern Rust 1.98.1 baseline upgrade - #308
Conversation
Bumps [rust-toolchain](https://github.com/rust-lang/rust) from 1.97.1 to 1.98.1. - [Release notes](https://github.com/rust-lang/rust/releases) - [Changelog](https://github.com/rust-lang/rust/blob/main/RELEASES.md) - [Commits](rust-lang/rust@1.97.1...1.98.1) --- updated-dependencies: - dependency-name: rust-toolchain dependency-version: 1.98.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
left a comment
There was a problem hiding this comment.
Exact-head product/docs review for 0cf4275d364f529eb3c23dbbfec5ce20113db47e: the predecessor #301 contract failure is repaired without weakening exact pinning. The successor inherits the sole Dependabot manifest delta, advances both independent repository expectations to 1.98.1, adds Proposed ADR 0115, aligns AGENTS/README/documentation indexes/toolchain doctoring/CHANGELOG, and leaves the historical 1.97.1 records plus nightly-2026-08-18 untouched. Main-to-head comparison is 10 commits ahead / 0 behind across exactly 10 paths; .github/** is absent from the patch. This is not approval or merge-ready evidence: native CI on this Draft head is skipped by policy, and protected workflow-owned paths still materialize stable 1.97.1. Keep Draft and fail closed until the authorized workflow owner removes that split compiler provenance and the same exact lineage receives executed repository contracts, formatting, locked workspace tests, strict Clippy, rustdoc, exact coverage, security and central verdicts.
seonghobae
left a comment
There was a problem hiding this comment.
Fresh exact-head verification update for 0cf4275d364f529eb3c23dbbfec5ce20113db47e: the product/docs Rust 1.98.1 baseline repair remains structurally unchanged and Draft. Security Scan 34339120753 and Semgrep 34339120692 are terminal success; native CI 34339120719 is intentionally skipped by Draft admission and therefore is not repository GREEN. CodeQL 34339120658 is terminal failure, but its three compatibility shards all read the current-head state successfully and fail only because the same-generation terminal verdict is still pending; coordinator 102426226732 starts later and dispatches successfully for this exact repo/PR/head/live-base/run-id. This matches canonical .github#1929 sequencing/publication ownership and has been handed off there as 5600783436. No approval or merge-ready claim: keep Draft until #279's stable-toolchain workflow provenance split is repaired by the authorized owner, .github#1929 provides unchanged-head terminal-verdict proof, and the exact lineage receives executed repository contracts/fmt/locked tests/Clippy/rustdoc/exact coverage plus required central verdicts.
Purpose
Repair Dependabot #301 as a governed Rust stable-baseline change instead of treating the manifest-only bump as mergeable.
Predecessor RED
#301 exact
ddff2b88a8557374237f916cfc3beaabf5629760changed onlyrust-toolchain.toml. Native CI34320596205failed atCheck Python repository contracts; both exact baseline contracts still required Rust1.97.1, so formatting, workspace tests, strict Clippy, and rustdoc did not execute. Production coverage success on that predecessor is not a substitute for the failed Rust-contract lane.Repair
This successor completely inherits #301's Rust
1.98.1bump and adds only the missing governed baseline delta:1.98.1rather than floatingstable;1.98.1rather than weakening/removing them;AGENTS.md,README.md, ADR/documentation indexes, toolchain doctoring, andCHANGELOG.md;1.97.1at their time;nightly-2026-08-18branch-coverage pin unchanged.Rust 1.98.1 is the current stable point release as of 2026-09-09 and includes the upstream vtable-generation miscompilation fix described by the Rust project.
Current exact-head evidence
Exact head:
0cf4275d364f529eb3c23dbbfec5ce20113db47eon protected base87c4daa1830bac5a5228b6036752ad5633232085.34339120719: skipped by the intentional Draft admission guard; this is not repository GREEN.34339120753: success.34339120692: success.34339120658: failure, but the exact failure is central verdict publication/wake orchestration rather than an OriginWeave query or source finding. Detect-languages102425458729succeeded. Actions102425518002, Python102425518052, and JavaScript/TypeScript102425518077each read the current-head state successfully and fail only atRelease runner or enforce current-head CodeQL verdict; Python recordsDISPATCH_OUTCOME=success,VERDICT_STATE=pending. Same-generation coordinator102426226732starts afterwards and dispatches successfully.34339474860re-validates this exact repo/PR/head/base/run identity.validate-dispatch102426599375succeeds. All three scan jobs — actions102428563574, JavaScript/TypeScript102428563629, Python102428563658— successfully materialize the exact head, run CodeQL analysis, pass the Medium+ SARIF gate, preserve evidence, and fail only atWake exact CodeQL required job.CODEQL_SARIF files=1 results=0 medium_plus=0; artifactcodeql-dispatch-python-34339474860-1, ID10099385445, SHA-2566661ad42b03f64c0589283e19827929043c4fdf49649fe73c33d541fadd000de.Resource not accessible by integration (HTTP 403). The wake step then has blankGH_TOKEN,WAKE_TOKEN_SOURCE=unavailable, and fails withActions-capable CodeQL wake credential is unavailable.Nocodeql-dispatch/*context is present on the target commit. This evidence is therefore a canonical credential/publication+wake defect, not a clean-scan-to-source-failure reinterpretation.ContextualWisdomLab/.github#1929; initial exact reproduction is comment5600783436and the dispatch-run RCA is comment5600829345. Do not add an OriginWeave-local CodeQL shim, no-op commit, synthetic status, or gate weakening.Owner boundaries still blocking promotion
Protected-main
.github/workflows/ci.ymland the hourly workflow still materialize stable1.97.1explicitly in workflow-owned paths. This product/docs successor does not edit.github/**to hide that provenance split. OriginWeave #279 owns the protected CI reconstruction/adoption path; exact #308 handoff is comment5600210525, with current owner separation restated in5600795536.Separately,
.github#1929owns the current CodeQL cross-repository verdict-publication and exact-job wake defect. A central repair must be proven on an unchanged exact downstream head before its verdict can count here.The authorized workflow owner must adopt the stable-version change, the central CodeQL owner must provide an authenticated same-generation terminal verdict, and then this exact lineage must rerun Python repository contracts, formatting, locked workspace tests, strict Clippy, rustdoc, exact 100% production coverage, Security Scan, Semgrep, and all required central checks.
Keep this PR Draft until those owner prerequisites are integrated/adopted and exact-head executable evidence is available. Do not close #301 merely to reduce PR count; this PR is its repair successor and must preserve the complete valid Dependabot delta.