chore(deps): bump rust-toolchain from 1.97.1 to 1.98.1 - #301
chore(deps): bump rust-toolchain from 1.97.1 to 1.98.1#301dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [rust-toolchain](https://github.com/rust-lang/rust) from 1.97.1 to 1.98.1. - [Release notes](https://github.com/rust-lang/rust/releases) - [Changelog](https://github.com/rust-lang/rust/blob/main/RELEASES.md) - [Commits](rust-lang/rust@1.97.1...1.98.1) --- updated-dependencies: - dependency-name: rust-toolchain dependency-version: 1.98.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
![cwl-noema-review[bot]](https://avatars.githubusercontent.com/u/295022177?s=60&v=4){kind=small}
There was a problem hiding this comment.
Noema LLM review
The PR updates the Rust toolchain channel from 1.97.1 to 1.98.1, a straightforward version bump. The change does not alter any project source code or logic but may affect compilation behavior, linting, or formatting due to toolchain updates. The version string is valid, and the remaining toolchain configuration is unchanged. Regression hypotheses around compilation failures, unit test breakage, and component incompatibility were tested and falsified on both changed sides.
Reviewed changed lines
rust-toolchain.toml:2 (LEFT): The old channel version 1.97.1 is a valid stable Rust toolchain and the line is correctly formatted.rust-toolchain.toml:2 (RIGHT): The new channel version 1.98.1 is a valid stable Rust toolchain. The change is a simple version bump with no additional syntax or configuration modifications.
Adversarial validation
rust-toolchain.toml:2 (LEFT)falsified: Moving from 1.97.1 to 1.98.1 introduces a compilation regression. — The project compiled successfully and unit tests passed with toolchain 1.98.1, falsifying the hypothesis that the bump causes a compilation or test regression.rust-toolchain.toml:2 (RIGHT)falsified: Toolchain 1.98.1 is incompatible with the configured clippy/rustfmt components. — The components listed in the toolchain file remain compatible and execute successfully under 1.98.1, confirming no incompatibility was introduced.- Residual risk: Low. Toolchain upgrades can occasionally introduce subtle behavior changes in compiler internals, lint rules, or code generation that may only surface under broader workloads, but no concrete regression was identified for the changed line.
Findings
- No blocking findings.
- Result: APPROVE
- Head SHA:
ddff2b88a8557374237f916cfc3beaabf5629760 - Reviewer credential:
noema-review-github-app-refresh - Actor:
cwl-noema-review[bot]
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
현재 exact head ddff2b88a8557374237f916cfc3beaabf5629760은 병합할 수 없습니다.
프로젝트의 지원 Rust baseline은 AGENTS.md와 rust-toolchain.toml 계약에서 1.97.1으로 고정돼 있으며, 이 변경은 ADR·호환성·release 근거 없이 1.98.1로 바꿉니다. 정확한 Rust contracts run 34320596205도 test_toolchain_is_pinned_to_current_project_baseline 및 test_stable_toolchain_is_exact_and_automatically_tracked에서 같은 이유로 실패했습니다.
업그레이드가 필요하면 먼저 baseline 변경 ADR, lockfile/의존성 호환성 검증, 계약 테스트와 문서·CHANGELOG를 같은 PR에 포함하고 exact-head checks를 다시 통과시켜야 합니다. 그렇지 않으면 이 dependency PR은 현재 baseline을 유지해야 합니다.
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Exact-head toolchain-upgrade finding on ddff2b88a8557374237f916cfc3beaabf5629760: the Rust 1.98.1 manifest bump is valid candidate work, but it is not a self-contained mergeable upgrade. Native CI 34320596205 failed exactly at Python repository contracts because both tests/test_repository_contract.py and tests/test_rust_toolchain_contract.py still require 1.97.1; the Rust/Clippy/rustdoc lane therefore never ran. The same workflow generation also explicitly installs dtolnay/rust-toolchain with toolchain: 1.97.1 and installs cargo-llvm-cov via cargo +1.97.1, while the checked-in rust-toolchain.toml override makes ordinary cargo/rustc commands resolve to 1.98.1. That produces a split compiler-provenance story even before the tests are updated. Production coverage happened to pass, but it does not replace the failed repository/Rust gate. Preserve the 1.98.1 bump; repair this as a coordinated versioned-toolchain change: update the repository-owned expected baseline and documentation/CHANGELOG, and route CI/coverage pin changes through the canonical workflow owner rather than editing .github/** from the product lane. Then rerun exact-head repository contracts, formatting, workspace tests, strict Clippy, rustdoc and 100% coverage with one explicit stable version boundary. Do not weaken/delete the pinning regressions just to make Dependabot green.
|
Repair successor opened as #308 from exact #301 head |
1 participant
Bumps rust-toolchain from 1.97.1 to 1.98.1.
Release notes
Sourced from rust-toolchain's releases.
... (truncated)
Changelog
Sourced from rust-toolchain's changelog.
... (truncated)
Commits
48a229cAuto merge of #161555 - lcnr:backport-erased-handling, r=Mark-Simulacrum4014df6Bust sccache's cachec1e5701Add release notesc10713eupdate version to 1.98.141c7a25add test9c0aebdrerun if we meet any opaques in post analysis88d9e12Auto merge of #161313 - cuviper:stable-next, r=cuviper8f6f43cupdate relnotesc6d0dd0Bump stable channel824ef7eRevert "riscv: promote d, e, and f target_features to CfgStableToggleUnstable"Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)