test(#828): verify grouping axis-share accessible semantics - #981
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1472d98
into
feat/leftover-map-compare-axis-share-v2500
Draft repair-validation lane for #828. Base is exact product #828
7b6dbbb99a09d0523bce43c6872bbd9fa382a43a; do not merge while the exact-head GREEN and product repair are incomplete.Fresh current-head review found the grouping-comparison axis-share badge is a plain
<span>carryingaria-label. Its implicit ARIA role isgeneric, for which author-provided accessible naming is prohibited. The visible localized persistedσ²/Σσ²text must remain ordinary readable content; do not add a synthetic role, recompute/clamp the psychometric value, or change translation ownership.The first validation attempt was not product evidence: its source anchor had drifted and failed before reaching the intended assertion. Commit
1472d98b7513c360ca1c7cf6da4a401a716bc53crepairs only that harness anchor. Hosted run34171799327, frontend job101893369069, is now a realistic RED: lint passes, existingApp.test.tsxtests pass, and the sole failing new regression isleftoverMapCompareAxisAccessibility.test.ts, which sees the current axis-share block'saria-label={t(LEFTOVER_MAP_COMPARE_AXIS_SHARE_LABEL)}. Result at that step: 65 test files passed and 1 failed; 729 tests passed and 1 failed. Build/Storybook are correctly skipped after the intentional RED.Minimal causal repair remains exactly two source deletions in
frontend/src/App.tsx: remove the unusedLEFTOVER_MAP_COMPARE_AXIS_SHARE_LABELimport and remove thearia-labelfrom that axis-sharepost-badge. Preserve the visibletf(LEFTOVER_MAP_COMPARE_AXIS_SHARE, comparisonAxisShare)output. After repair, require fresh lint/test/build/Storybook plus repository-required exact-head gates before promotion.This finding belongs to #828, the earliest owner of the axis-share presentation. #829/#830/#831 evidence cannot be promoted across a repaired #828 parent without fresh non-force descendant convergence. Keep historical product ancestry; no force-push, destructive rebase, self-approval, synthetic status, or workflow-based source mutation.