test(#830): validate exact #829 descendant convergence - #980
Conversation
…rip (v2.51.0)
Caption persisted leftover-map singular values on GET /api/reports/compare/{period} through leftoverMapCompareAxisSingular (ADR 0294). Distinct aria-label Leftover map comparison axis singular. Omit missing, non-finite, or negative leftover-map singular value independently of leftover-map comparison axis share. Do not invent leftover-map singular value from leftover-map axis share. No SQL. No leftover score or theta.
Add the persistent governance contract before allocating ADR 0370 / v2.56.0 so the reconstructed #830 delta cannot inherit the predecessor release identity.
Repair the reconstructed #830 release identity without reusing historical ADR 0294 / v2.51.0. Keep the decision Proposed, synchronize Python/frontend package versions, and record the persisted axis-singular product contract.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Leftover-map validation #980 already allocated ADR 0370 for comparison axis-singular. Keep that number on the leftover stack and record Ask claim-generation liveness as Proposed ADR 0371.
|
Noting an ADR-number collision with #979: this validation lane allocated ADR 0370 for leftover-map comparison axis-singular. #979 had used 0370 for Ask claim-generation liveness and has now reallocated that decision to Proposed ADR 0371 ( This PR remains a non-product validation lane and must not be merged as the product path. Full test suite on |
The grouping comparison singular badge is a generic span. Remove the prohibited aria-label and assert the persisted σ_k text instead.
|
Intended RED observed: Tests run Repair |
|
Exact-head |
Ephemeral validation lane for #830 only. Base is exact live #829
07301271f813b8bb0e40f57aa22373baf5efbf01; this PR is not a replacement product lane and must never be merged as the product path.The initial workflow-free convergence candidate
4c71c0679fa5fa1cde6807e43b5002346ada5875preserves historical #830b36b2534c9b3a63b66c56ae22ff3dcad40ae5c67as first parent and exact #829 as second parent. Current-parent review found ADR 0370 still named stale predecessor0e4fd581…; the regression/fix bound ADR 0370 to07301271…while retaining Proposed/v2.56.0.A second current-parent review found the reconstructed singular-value badge applied
aria-labelto a plain<span>. The minimum repair removes that singular badge's unnecessary author name, retains its visible localized persistedσ_ktext, and replaces the stale frontend expectation for generic labels with rendered axis/value assertions. It does not add a synthetic role, alter psychometric computation, couple singular visibility to axis-share validity, or create another translation source.The validation lane has advanced non-force to exact
4c93e91ebe3fe7302545f861d7c0fba003e077f8. It is a descendant of both historical #830b36b2534…and exact #82907301271…; compare from #829 contains the bounded #830 source/test/ADR/release delta and no temporary workflow. Tests run34171114817is terminal GREEN on this exact head: frontend lint, frontend tests, production build and Storybook all pass, and the complete PostgreSQL-backed suite passes. A later same-head run34174346335is skipped only because this validation PR is Draft; it does not invalidate the earlier unchanged-head GREEN.Do not promote this validation head to the #830 product ref yet. Fresh owner review on #828 has established an earlier accessibility RED: the inherited grouping axis-share generic
<span>still carriesaria-label={t(LEFTOVER_MAP_COMPARE_AXIS_SHARE_LABEL)}. #981@1472d98b7513c360ca1c7cf6da4a401a716bc53c, run34171799327, is the realistic RED for that earlier owner defect. Required serialized repair order is #828 first, then fresh non-force #829 convergence, then a new #830 convergence. The current34171114817GREEN is valid evidence for this exact historical-parent candidate but cannot transfer across that future parent movement.Keep this PR Draft and unmerged. No force-push, destructive rebase, self-approval, gate weakening, stale-parent GREEN transfer, synthetic status, no-op validation churn, or merge of this validation lane.