Skip to content

test(#830): validate exact #829 descendant convergence - #980

Draft
seonghobae wants to merge 17 commits into
feat/leftover-map-compare-unexplained-share-v2520from
automation/830-current-829-convergence-20260908-0648
Draft

test(#830): validate exact #829 descendant convergence#980
seonghobae wants to merge 17 commits into
feat/leftover-map-compare-unexplained-share-v2520from
automation/830-current-829-convergence-20260908-0648

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Ephemeral validation lane for #830 only. Base is exact live #829 07301271f813b8bb0e40f57aa22373baf5efbf01; this PR is not a replacement product lane and must never be merged as the product path.

The initial workflow-free convergence candidate 4c71c0679fa5fa1cde6807e43b5002346ada5875 preserves historical #830 b36b2534c9b3a63b66c56ae22ff3dcad40ae5c67 as first parent and exact #829 as second parent. Current-parent review found ADR 0370 still named stale predecessor 0e4fd581…; the regression/fix bound ADR 0370 to 07301271… while retaining Proposed/v2.56.0.

A second current-parent review found the reconstructed singular-value badge applied aria-label to a plain <span>. The minimum repair removes that singular badge's unnecessary author name, retains its visible localized persisted σ_k text, and replaces the stale frontend expectation for generic labels with rendered axis/value assertions. It does not add a synthetic role, alter psychometric computation, couple singular visibility to axis-share validity, or create another translation source.

The validation lane has advanced non-force to exact 4c93e91ebe3fe7302545f861d7c0fba003e077f8. It is a descendant of both historical #830 b36b2534… and exact #829 07301271…; compare from #829 contains the bounded #830 source/test/ADR/release delta and no temporary workflow. Tests run 34171114817 is terminal GREEN on this exact head: frontend lint, frontend tests, production build and Storybook all pass, and the complete PostgreSQL-backed suite passes. A later same-head run 34174346335 is skipped only because this validation PR is Draft; it does not invalidate the earlier unchanged-head GREEN.

Do not promote this validation head to the #830 product ref yet. Fresh owner review on #828 has established an earlier accessibility RED: the inherited grouping axis-share generic <span> still carries aria-label={t(LEFTOVER_MAP_COMPARE_AXIS_SHARE_LABEL)}. #981@1472d98b7513c360ca1c7cf6da4a401a716bc53c, run 34171799327, is the realistic RED for that earlier owner defect. Required serialized repair order is #828 first, then fresh non-force #829 convergence, then a new #830 convergence. The current 34171114817 GREEN is valid evidence for this exact historical-parent candidate but cannot transfer across that future parent movement.

Keep this PR Draft and unmerged. No force-push, destructive rebase, self-approval, gate weakening, stale-parent GREEN transfer, synthetic status, no-op validation churn, or merge of this validation lane.

seonghobae and others added 12 commits August 30, 2026 15:40
…rip (v2.51.0)

Caption persisted leftover-map singular values on GET /api/reports/compare/{period} through leftoverMapCompareAxisSingular (ADR 0294). Distinct aria-label Leftover map comparison axis singular. Omit missing, non-finite, or negative leftover-map singular value independently of leftover-map comparison axis share. Do not invent leftover-map singular value from leftover-map axis share. No SQL. No leftover score or theta.
… current stack

Preserve the valid historical #830 delta on exact #829; consume only persisted singular values, accept the persisted field as optional at the read boundary, and keep share/singular omission independent.
Add the persistent governance contract before allocating ADR 0370 / v2.56.0 so the reconstructed #830 delta cannot inherit the predecessor release identity.
Repair the reconstructed #830 release identity without reusing historical ADR 0294 / v2.51.0. Keep the decision Proposed, synchronize Python/frontend package versions, and record the persisted axis-singular product contract.
@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: d239b599-c19d-451b-9493-6f4ca4406101

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as draft September 7, 2026 22:38
@seonghobae
seonghobae marked this pull request as ready for review September 7, 2026 22:39
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

seonghobae pushed a commit that referenced this pull request Sep 7, 2026
Leftover-map validation #980 already allocated ADR 0370 for comparison
axis-singular. Keep that number on the leftover stack and record Ask
claim-generation liveness as Proposed ADR 0371.

Copy link
Copy Markdown
Contributor Author

Noting an ADR-number collision with #979: this validation lane allocated ADR 0370 for leftover-map comparison axis-singular. #979 had used 0370 for Ask claim-generation liveness and has now reallocated that decision to Proposed ADR 0371 (fef48b14f) so 0370 stays here.

This PR remains a non-product validation lane and must not be merged as the product path. Full test suite on 921dc73f is pending and is not polled. After terminal Tests evidence, return the lane to Draft as the PR body already requires.

The grouping comparison singular badge is a generic span. Remove the
prohibited aria-label and assert the persisted σ_k text instead.

Copy link
Copy Markdown
Contributor Author

Intended RED observed: Tests run 34167409504 failed test_grouping_comparison_singular_badge_does_not_name_generic_span (aria-label= on the generic singular span). Frontend on that run was GREEN.

Repair 4c93e91eb removes only that prohibited aria-label and asserts the persisted σ_k text (leftover map comparison axis {n} σ …) instead of four generic names. Local: python a11y test GREEN; shows the grouping comparison strip vitest GREEN. This lane stays a non-product validation path — do not merge. Repository Tests on the new head are not polled. After terminal GREEN, return to Draft as the PR body requires.

@seonghobae
seonghobae marked this pull request as draft September 8, 2026 00:45

Copy link
Copy Markdown
Contributor Author

Exact-head 4c93e91eb Tests run 34171114817 is terminal GREEN (23m46s) + Frontend GREEN. This remains a non-product validation lane for #830 on exact #829. Converted back to Draft per the PR body. Do not merge this lane as the product path. Only an exact-head GREEN on the repaired tree authorizes a fresh workflow-free two-parent #830 product commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant